if statement selects all in db????

rdkd1970

I am testing my welcome page and when I complete the form it welcomes everyone of my tested names in the database. How can I narrow it down to only welcome the one name that filled out the form. Here is my coding.

 <?php
 session_start();
      ini_set ("display_errors", "1");
 error_reporting(E_ALL);
?>
         <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <title>Welcome</title> <style type="text/css"> .background {color: #B56AFF; } </style> </head>  <body> <p>  

<?php
 /* Program: login.php
  * Desc:    Displays the new member welcome page. Greets
  *            member by name and gives a choice to enter
  *            restricted section or go back to main page.
  */
  if (isset($_SESSION['id'])) {
                 // Set the users session ID    include("Connections/connect_to_mysql.php");
  //Formulate Query 
//This is the best way to perform an SQL query
 $query = "SELECT id, firstname FROM `Members` WHERE id={$_SESSION['id']}";
 $result = mysql_query($query);
 $numrows = mysql_num_rows($result);
  //Check result
 //This shows the actual query sent to MySQL and the error. Useful for debugging. 
 if(!$result){
       $message = 'Invalid query:' . mysql_error() . "\n";
       $message .= 'Whole query:' . $query;
         die($message);
}
 //Use result //Attempting to print $result won't allow access to information in the resource
 //One of the mysql result functions must be used
 //See also mysql_result(), mysql_fetch_array(), mysql_fetch_row(), etc.
 if($numrows!=0){
  while($row=mysql_fetch_assoc($result)){
       echo "Welcome, {$row['firstname']}";
       }
       //Free the resources associated with the result set
       mysql_free_result($result);
 }
 }
 ?> 
</p> <p>&nbsp; </p>
 <p>Your new Member accounts lets you enter the members only section   of our web site. You'll find special discounts, a profile of matches, live advise from experts, and much more.</p>
 <p>Your new Member ID and password were emailed to you. Store them carefully for future use.
</p> <div style="text-align: center">
 <p style="margin-top: .5in; font-weight: bold"> Glad you could join us!</p> <form action="profile.php" method="post">
     <input type="submit"         value="Enter the Members Only Section">
         </form> <form action="index.php" method="post">
     <input type="submit" value="Go to Main Page">     </form>
                 </div> </body> </html>

bradgrafelman

Do all of those names share the same 'id' value? If so, why? What is this 'id' value supposed to represent? Do you have a PRIMARY or UNIQUE index on that column?

rdkd1970

all the id are unique and primary. I went into the db and did a sql query for the query I have in my codes it produces all the names. But each row is unique id.

bradgrafelman

What is the exact SQL query you're running? Also, can you show us the rows that were selected as a result?

rdkd1970

this is what happens when I input into the db. and it goes to the welcome page

OceanwildWelcome, WheelsWelcome, BermudianWelcome, BarneyWelcome, WarrenWelcome, BrianWelcome, SpideyWelcome, OutWelcome, BabyfaceWelcome, ClipsWelcome, RoyalWelcome, Post

Your new Member accounts lets you enter the members only section of our web site. You'll find special discounts, a profile of matches, live advise from experts, and much more.

Your new Member ID and password were emailed to you. Store them carefully for future use.

Oh and after Welcome is the names I give I am running out of names.🙂

bradgrafelman

You still haven't shown us either of the things I asked for in the previous post.

Not much else I can do to help.