[RESOLVED] php/internet explorer help

msnhockey

The script i have below works in Firefox as intended and in Internet Explorer 9 the rotating doesnt rotate as intended.

Any help on where or what i should add/delete is appriciated

you can view the scoreboard rotating thing here.. www.theufhl.com

hopefully i just missed something small

<script language="JavaScript1.2">

//IFRAME TICKER- By Dynamic Drive (http://www.dynamicdrive.com)

//configure delay between changing messages (3000=3 seconds)
var delay=3000

var ie4=document.all

var curindex=0
var totalcontent=0

function get_total(){
if (ie4){
while (eval("document.all.content"+totalcontent))
totalcontent++
}
else{
while (document.getElementById("content"+totalcontent))
totalcontent++
}
}

function contract_all(){
for (y=0;y<totalcontent;y++){
if (ie4)
eval("document.all.content"+y).style.display="none"
else
document.getElementById("content"+y).style.display="none"
}
}

function expand_one(which){
contract_all()
if (ie4)
eval("document.all.content"+which).style.display=""
else
document.getElementById("content"+which).style.display=""
}

function rotate_content(){
get_total()
contract_all()
expand_one(curindex)
curindex=(curindex<totalcontent-1)? curindex+1: 0
setTimeout("rotate_content()",delay)
}

window.onload=rotate_content

</script>

<div style="width:190px;border:0px solid #000">
<div class="borderedBox">
<div class="colMainWrap">
<img width="190" src="http://theufhl.com/images/banners/scoreboard.png">
<body>
<div class="feature colMain">
<table cellspacing=0 cellpadding=0><tr><td width=175>
<table cellspacing=0 cellpadding=0><tr><td>
<? 
$scoreboard="0";
while ($scoreboard < "3") { ?>
<div id="content<?=$scoreboard?>" style="display:''">
<?
$col2w="90";
$gamequery=mysql_query("select * from schedule_scores where (team1_score !='') order by id desc limit $scoreboard,1");
echo "<table width=175>";
while ($game=mysql_fetch_array($gamequery))
{
$team1=mysql_fetch_array(mysql_query("select * from teams where (id='$game[team1]')"));
$team2=mysql_fetch_array(mysql_query("select * from teams where (id='$game[team2]')"));
?>
<tr><td width=40><a href="http://theufhl.com/?opt=viewteam&id=<?=$team1[id]?>&divid=<?=$game[team1_div]?>&sid=<?=$game[season]?>" target="_top"><img border="0" width="35" height="35" src=http://theufhl.com/images/<?=$game[team1pic]?>></a></td><td width=<?=$col2w?> align=left><?=$team1[city]?></td><td><?=$game[team1_score]?></td></tr>

<tr><td width=40><a href="http://theufhl.com/?opt=viewteam&id=<?=$team2[id]?>&divid=<?=$game[team2_div]?>&sid=<?=$game[season]?>" target="_top"><img border="0" width="35" height="35" src=http://theufhl.com/images/<?=$game[team2pic]?>></a></td><td width=<?=$col2w?> align=left><?=$team2[city]?></td><td><?=$game[team2_score]?></td></tr>
<?
}
echo "</table>";
?>
</div>
<? 
$scoreboard++;
} 
?>
</td></tr></table>
</td><td valign=center width=10 align=right>F </td></tr></table>
</div>
</body>
</div></div></div>

Weedpacket

The first problem I see is that you're still bothering to support IE4 - that's basically been extinct since 2009.

There are multiple issues the HTML, JavaScript, and PHP code. There are <body> and <html> elements in the middle of the page, multiple elements with the same ID attribute, there is a missing " in the dynamically generated links (on the live site, though not in the code you posted). Both IE and FireFox complain about jQuery-related errors (most notably, neither know what '$' refers to). With all those problems, whether any part of it works or not is down more to chance than design. Even if they aren't the cause of the problem, they do nothing to make it easier to find what is.

As I said, there are PHP issues as well, but they wouldn't affect client-side activity.

msnhockey

thanks for reply and disabling IE4 from the code made it work for now until i get time to rewrite to newer stuff.

I also cleaned up the html and php code as well.. and got rid of that $... i had someone write the code for me and thought it was all good but i guess i was wrong.

Thanks for looking through and giving me the advice.. I am new to javascript and php so this was a good learning experience.