why? Notice: Undefined index

fati

this is my html form

<DIV ID= "logIn" STYLE="float:right">
<TABLE>
<FORM NAME = "LogIn" ACTION= "AcademicLogIn.php" METHOD = "post">
<TR>
	<TD>
		Username:
	</TD>
	<TD>
		<INPUT TYPE="text" NAME="usrName" />
	</TD>
</TR>
<TR>
	<TD>
		Password:
	</TD>
	<TD>
	<INPUT TYPE="password" NAME="usrPswrd" />
	</TD>
</TR>
<TR>
	<TD>

	</TD>
	<TD>
	<INPUT TYPE="submit" VALUE="Submit" />
	</TD>
</TR>
</FORM>
</TABLE>
</DIV>

this is my php

require("conDB.php");

$tblName = "usr";

mysql_select_db($tblName);

$usrName = $_POST['usrName'];
$usrPswrd = $_POST['usrPswrd'];

$sql = "SELECT * FROM $tblName WHERE usrName = '$usrName' && usrPswrd = '$usrPswrd'";

if(mysql_query($sql))
echo "Welcom $usrName";

this is the error
Notice: Undefined index: usrName in C:\xampp\htdocs\AcademicUnit\AcademicLogIn.php on line 9

Notice: Undefined index: usrPswrd in C:\xampp\htdocs\AcademicUnit\AcademicLogIn.php on line 10

what is wrong? the spelling is correct

A-GB

You should check if the POST data is empty before checking MySQL. For example...

if (isset($POST['value'])) {
// do something with $POST['value']
}

fati

thank u 4 ur rply
are u sure abt this

bcos the error in the previous line
I really don't understand why?

i have similar code in another project that is working fine,

A-GB

Even so, this isn't actually a login script..

if(mysql_query($sql)) 
echo "Welcom $usrName";

Apart from missing the {}, the IF statement would return TRUE every single time.

bradgrafelman

fati;10981116 wrote:
bcos the error in the previous line
I really don't understand why?

The above suggestion is indeed correct. You should never attempt to access external data without first verifying that it exists. In other words, code like this:

$id = $_GET['id'];

is bad and prone to errors, while this:

$id = (isset($_GET['id']) ? $_GET['id'] : NULL);

will never generate errors since it first uses [man]isset/man (could also use [man]empty/man) to verify that the external data exists before attempting to use it.

fati;10981116 wrote:
i have similar code in another project that is working fine,

Irrelevant (and possibly incorrect, too). Given the right set of conditions, even poorly written code will appear to be "working fine."

That, however, doesn't mean it isn't poorly written or error-free.

A-GB;10981153 wrote:
Apart from missing the {}

... which are optional... 😉

fati

thank you
what i understand from isset is to check if there is value or not , if there is no value entered by user it will generate an error, if there is a value it should be fine

my real problem is that i have entered a value in the form but it seems there no value. the value is not retrieved

Pikachu2000

A-GB;10981153 wrote:
Even so, this isn't actually a login script..
if(mysql_query($sql)) 
echo "Welcom $usrName";
Apart from missing the {}, the IF statement would return TRUE every single time.

No, if the query fails it will return FALSE.

bradgrafelman

Pikachu2000;10981209 wrote:
No, if the query fails it will return FALSE.

Right, that's exactly what A-GB said.

Entering an invalid username/password is not going to cause the query to fail (it'll just return 0 rows).

fati

the problem is the php dose not recogize the variable $_POST['variable']

as if it does not exist

i have checked the spelling of the name in the form and the variable name in the $_POST['']

what could cause such problem if the spieling is not wrong?

bradgrafelman

Is the PHP code you showed us what is used in the 'AcademicLogIn.php' file that the form is submitting to?

Also, try doing a:

echo '<pre>' . print_r($_REQUEST, true) . '</pre>';

and paste the output here for use to see.