[RESOLVED] href & <form action not working

donglass

I am a newbie, and need some help, so I hope someone who knows the solution to this problem will respond. This problem is an obstacle to setting up my online store, which I need to have working ASAP. I am trying to prevent the customer from a quantity of zero to be going to the checkout pages. In the program view_product.php, I intentionally set the default quantity to zero; the customer needs to change the quantity before proceeding, and is accompanied by an 'Add to Cart' button. The idea is when the customer does not change the quantity to a positive integer, it should go back to the same web page, and the error message 'Cannot have a quantity of zero or less' should be displayed in the web page produced by view_product.php. The following code should be working correctly, and is not. Prior to the commands below, only <html>, <head>, <title>, <style>, <body>, and <br> HTML commands are used. All I am getting is a blank screen with the 'Cannot have a quantity of zero or less' error message.

<?php // <-- Only used for syntax highlighting
if ($qty <= 0) {
echo '<form method="post" action="view_product.php">';
echo '<div>';
echo '<p><a href="view_product.php"></a></p>';
echo '<label id="errormsg1">Cannot have a quantity of zero or less </label>';
echo '</div>';
echo '</form>';
} else if // ...etc...{ 
// ...etc...

aplusguy

bpat1434

I don't see any syntax errors. From what you posted it should work fine. What's the rest of your file look like? I'm betting there's a syntax error or something somewhere.

donglass

I am leaning toward your conclusion that there must be a syntax error somewhere in my code. I am pasting all of edit_cart.php below. view_product.php displays details of product, including a small picture, and should not be a blank screen. Hope this information helps.

<html>
	<head>
		<title>Your Shopping Cart</title>
		<style> type="text/css">
		th { backgound-color: #999; }
		td { vertical-align: top; }
		tr { background-color: #ABF }
		.odd_row { background-color: #EEE }
		.even_row { background-color: #FFF }
		</style>
	</head>
	<body text=#0000FF>
		<br>

	<?php

	session_start();
	$session = session_id();

	//print_r($session);

	$prodcode = $_POST['prodcode'];
	$qty = $_POST['qty'];
	$pass = $_POST['pass'];
	$dt = date('Ymd');

	require 'db.inc.php';

	$db = mysql_connect('localhost', 'root', 'd7f13g7') or
	die ('Unable to connect. Check your connection parameters.');
	mysql_select_db('DonsStore', $db) or die(mysql_error($db));

	$query = 'SELECT
	prodcode, prodname, price, prodtype
	FROM
	DonsStore.products
	WHERE
	prodcode = "' . mysql_real_escape_string($prodcode, $db) . '"';

	$result = mysql_query($query, $db)or die(mysql_error($db));

	$row = mysql_fetch_array($result);


	$prodname = $row[1];
	$price = $row[2];
	$prodtype = $row[3];

	$prodcode = $_POST['prodcode'];
	$qty = $_POST['qty'];
	$total = number_format(($price * $qty), 2);

	mysql_free_result($result);

	if ($qty <= 0) {

		echo '<form method="post" action="view_product.php">';
		echo '<div>';
		echo '<p><a href="view_product.php?prodcode=$prodcode"></a></p>';
		echo '<label id="errormsg1">Cannot have a quantity of zero or less </label>';
		echo '</div>';
		echo '</form>';

	} else if ($qty > 0 && $pass == 1) {

		$query = 'INSERT INTO cart
		(session, prodcode, qty, actdate)
		VALUES ("' . mysql_real_escape_string($session, $db) . '",
		"' . mysql_real_escape_string($prodcode, $db) . '",
		"' . mysql_real_escape_string($qty, $db) . '",
		"' . $dt . '")';

		$result = mysql_query($query, $db)or die(mysql_error($db));

		echo '<h1>Shopping Cart for The Spiritual Writings of Don Glass</h1>';

		echo 'Data inserted/added';

		echo '<table style="width: 95%">';
		echo '<tr>';
		echo '<th>Book Cover</th></th><th>Book Title</th><th>Quantity</th>
		<th>Price Each</th><th>Extended Price</th>';
		echo '</tr>';

		echo '<tr>';
		echo '<td style="text-align: center"><a href="edit_cart.php?prodcode=' . $prodcode . '">
		<img src="images/' . $prodcode . '_t.png"; alt=' . $prodname . '></a></td>';
		echo '<td>' . $prodname . '</td>';
		echo '<td>';
		echo '<form action="edit_cart.php" method="post">';
		echo '<div>';
		//echo '<label for="qty"><strong>Quantity: </strong></label>';
		echo '<input type="text" name="qty" maxlength="5" size="5" value="' . $qty . '">';
		echo '<input type="hidden" name=prodcode" value="' . $prodcode . '">';
		echo '<input type="submit" name="submit" value="Change Qty">';
		echo '</div>';
		echo '</form>';
		echo '</td>';
		echo '<td style="text-align: right;"> $' . $price . '</td>';
		echo '<td style="text-align: right;"> $' . $total . '</td>';
		echo '</tr>';

		$odd = true;
		while ($row = mysql_fetch_array($result)) {
		echo ($odd == true) ? '<tr class="odd_row">' : '<tr class="even_row">';
		$odd = !$odd;
		extract($row);
	}

		echo '</table><br>';
		echo '<p>Your total before tax (if applicable) and shipping is:
		<strong>$<?php echo number_format($total, 2); ?></strong></p><br>';

		echo '<form>';
		echo '<input type="button" value="Back to Previous Page"
		onClick="javascript: history.go(-1)">';
		echo '</form>';

		echo '<form method="post" action="checkout.php">';
		echo '<div>';
		echo '<input type="submit" name="submit" value="Proceed to Checkout"
		style="font-weight: bold;">';
		echo '<p><a href="checkout.php"><Proceed to Checkout</a></p>';
		echo '</div><br>';
		echo '</form>';
		//echo '</hr>';
		echo '<p><a href="shop.php"><< Back to Home Page</a></p>';

	} else {

		$query = 'UPDATE cart
		SET qty=' . mysql_real_escape_string($qty, $db) . '
		WHERE
		session = "' . mysql_real_escape_string($session, $db) . '"
		AND
		prodcode = "' . mysql_real_escape_string($prodcode, $db) . '"';

		$result = mysql_query($query, $db)or die(mysql_error($db));

		echo '<h1>Shopping Cart for The Spiritual Writings of Don Glass</h1>';

		echo 'Cart updated';

		echo '<table style="width: 90%">';
		echo '<tr>';
		echo '<th>Book Cover</th></th><th>Book Title</th><th>Quantity</th>
		<th>Price Each</th><th>Extended Price</th>';
		echo '</tr>';

		echo '<tr>';
		echo '<td style="text-align: center"><a href="checkout.php?prodcode=' . $prodcode . '">
		<img src="images/' . $prodcode . '_t.png"; alt=' . $prodname . '></a></td>';
		echo '<td>' . $prodname . '</td>';
		echo '<td>';
		echo '<form action="checkout.php" method="post">';
		echo '<div>';
		echo '<input type="text" name="qty" maxlength="5" size="5" value="' . $qty . '">';
		echo '<input type="hidden" name=prodcode" value="' . $prodcode . '">';
		echo '<input type="submit" name="submit" value="Change Qty">';
		echo '<label for="qty"><strong>Quantity: </strong></label>';
		echo '</div>';
		echo '</form>';
		echo '</td>';
		echo '<td style="text-align: right;"> $' . $price . '</td>';
		echo '<td style="text-align: right;"> $' . $total . '</td>';
		echo '</tr>';

		$odd = true;
		while ($row = mysql_fetch_array($result)) {
			echo ($odd == true) ? '<tr class="odd_row">' : '<tr class="even_row">';
			$odd = !$odd;
			extract($row);
		}

		echo '</table><br>';
		echo '<p>Your total before tax (if applicable) and shipping is:
		<strong>$<?php echo number_format($total, 2); ?></strong></p><br>';

		echo '<form>';
		echo '<input type="button" value="Back to Previous Page"
		onClick="javascript: history.go(-1)">';
		echo '</form>';

		echo '<form method="post" action="checkout.php">';
		echo '<div>';
		echo '<input type="submit" name="submit" value="Proceed to Checkout"
		style="font-weight: bold;">';
		echo '<p><a href="checkout.php">Proceed to Checkout</a></p>';
		echo '</div><br>';
		echo '</form>';
		echo '<p><a href="shop.php"><< Back to Home Page</a></p>';
	}

	?>

</body>
</html>

cretaceous

you should put this bit at the very top before everything else
(you mustn't have any output to the page before session start)
<?php

session_start();
$session = session_id();

and then you have

that should be
<style type="text/css">

this line
echo '<p><a href="view_product.php?prodcode=$prodcode"></a></p>';
should be:
echo '<p><a href="view_product.php?prodcode='.$prodcode.'"></a></p>';

there may be others
are you sure your posted form is submitting a quantity value?

donglass

You have a very good eye for catching coding errors.I have made the changes to the errors you found, and I still get the same result. Yes the $qty value value posted is being passed successfully to edit_cart.php. I have input a 'echo $qty;' line in the code, and the value I set in view_product.php is passed to the $_POST in edit_cart.php. In fact, when I input a quantity value, say 7, it is inserted into the cart table along with the prodcode, session_id, and date, which I then delete via the command line so I do not get a 'duplicate entry' message later. I have not tested the update portion of the code as I feel it is more important to get this qty <= 0 problem working first. Any other ideas?

cretaceous

I bet that $qty is not being passed to this script..
it may be in edit_cart but is it in view_product?
(we're looking at view_product right?)

you access the value twice:
$qty = $_POST['qty'];
so though that should be ok, it can be confusing

by the way there is nothing within this 'a' tag to display a link:

<?php // <-- Only used for syntax highlighting
if ($qty <= 0) {
echo '<form method="post" action="view_product.php">';
echo '<div>';
echo '<p><a href="view_product.php"></a></p>';
echo '<label id="errormsg1">Cannot have a quantity of zero or less </label>';
echo '</div>';
echo '</form>';
} else if // ...etc...{

not clear where the problem is!

cretaceous

maybe the script is running, doing the insert and then returning to itself but this time with a $qty of 0 ??

you are not showing all the script as you have more closing curly braces than opening ones - so that will cause an error

donglass

I have been experimenting with and trying different approaches to try to figure out this problem. I have discovered that href requires a mouse click on text within an HTML <label, and possibly some other methods, i.e. href does not work automaticlally without interaction from a user. I don't remember the details now, but I came to the realization that I had to put the $qty logic in the previous web page, i.e. view_product.php. The href command is working as it should now, and is going back to the web page created by view_product..php.

However, when a quantity of zero is still there and when the 2nd pass of zero is there, the $prodcode comes in blank, and I lose all of the other needed values. So I have figured out and resolved the problem for which this thread was created. But I can't seem to find a way to mark this thread as resolved. This problem has mutated into a new and different problem, and will create a new thread for that. Thanks for your intent to help.

DonG

cretaceous

mark it in 'thread tools' in blue bar above your first post
at least you have one problem fixed!