[RESOLVED] Debugging PHP Send Form

[tiridako]

I figured that jumping right in and start learning PHP by actually coding my website. I was able to debug several errors on my own. I've now run into a wall trying to figure out the following error:

Parse error: syntax error, unexpected T_BOOLEAN_OR in [sic]/sendform_email.php on line 17 (for the copied code below, it is line 3)

if (!isset($_POST['first']) ||
	!isset($_POST['email']) ||
	!isset($_POST['comments'])) || {
	die('Sorry, there is a problem with your submission.');
}

May I use this thread to contain all of the errors I am trying to work through for the sendform_email as opposed to creating multiple threads for different errors?

[tiridako]

Gah, I thought I closed the tag.

if (!isset($_POST['first']) ||
	!isset($_POST['email']) ||
	!isset($_POST['comments'])) || {
	die('Sorry, there is a problem with your submission.');
}

[NogDog]

The double-pipe "or" highlighted in red below does not belong:

if (!isset($_POST['first']) ||
    !isset($_POST['email']) ||
    !isset($_POST['comments'])) [B][COLOR="Red"]||[/COLOR][/B] {
    die('Sorry, there is a problem with your submission.');
}

[tiridako]

Thanks a lot, NogDog!

I was able to fix the rest of the problems syntaxically. It makes more sense now. I have been following the howto site, and am wondering if the tutorial failed to mention a step or I skipped something. I would love for you to be my second pair of eyes to see what's wrong with the code.

When I tried the email form, no errors came up and only shows a white page. I also tried inputting an incorrect e-mail to see if it would tell me I got an invalid e-mail. Nothing happened. I'll link you to the following problematic page as well PHP code and the contact source.

I am also getting nothing in my inbox.

http://tdkohnen.com/contact.php

<?php
 if (!isset($_POST['email'])) {
$email_to="[e-mail]";
$email_subject="Tdkohnen.com Contact Reply";
}
function died($error) {
	echo "Error(s) are found with your submission. Please check the info you typed in and send again. ";
	echo "These errors appear below.<br /><br /> ";
	echo $error."<br /><br />";
	echo "Pleae go back and fix these errors. <br /> <br />";
	die ();
}

if (!isset($_POST['first']) ||
	!isset($_POST['email']) ||
	!isset($_POST['comments'])) {
	die('Sorry, there is a problem with your submission.');
}
	$first=$_POST ['first']; //required
	$email=$_POST ['email']; //required
	$comments=$_POST['comments']; //required

$error_message= " ";
$email_exp= '/^[A-Za-z0-9._%-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}$/';

if(!preg_match($email_exp,$email_from)) {
$error_message .='The Email Address you entered does not appear to be valid.<br />'; }
$string_exp ="/^[A-Za-z .'-]+$/";
if(!preg_match($string_exp, $first)) {
$error_message .= 'The First Name you entered does not appear to be valid. Do you not have one?<br />';

if(strlem($error_message) < 2 )  {
$error_message .= 'The comments you entered is not valid.<br />';
}
	if(strlem($error_message) >0 ){
	died($error_message);
}
	$email_message = "Form details below. \n\n";
	function clean_string ($string) {
	$bad = array ("content-type", "bcc:", "to:","cc:","href");
	return str_replace($bad, "", $string);
}
	$email_message .="First name:" .clean_string($first_name)."\n";
	$email_message .="Email:" .clean_string($email)."\n";
	$email_message .="Comments:" .clean_string($comments)."\n";

//create email headers
	$headers='From:'.$email_from. "\r\n".
'Reply-To: '.$email_from."\r\n" .
'X-Mailer: PHP/' . phpversion();
@mail($email_to, $email_subject, $email_message, $headers); ?>


Thank you for contacting me. I'll be in touch with you very soon.

<?php
}
?>

Contact source (nix'd the unnecessary code)

	        <p>If you just want to get in touch with me by email or form, you can email me using the form.</p>
    <div id="contact">        <form name="contact" method="post" action="sendform_email.php">

           <p> <label for="first">First Name *</label>
             <input class="first" type="text" name="first" maxlength="50" size="30"></p>

<p>                <label for="email">Email Address*</label>
                <input  class="email" type="text" name="email" maxlength="80" size="30"></p>

 <p>               <label for="comments">Comments*</label>
                <textarea class="comments" name="comments"  cols="50" rows="10"></textarea></p>
<p>                

                <input class="submit" type="submit" value="Send"><a href="sendform_email.php">Submit</a></p>
                </form>
                </div>

[tiridako]

I discovered HTML code for BB, and I am wishing that there's an edit button but as it is disabled for me...

	        <p>If you just want to get in touch with me by email or form, you can email me using the form.</p>
        <div id="contact">        <form name="contact" method="post" action="sendform_email.php">

           <p> <label for="first">First Name *</label>
             <input class="first" type="text" name="first" maxlength="50" size="30"></p>

<p>                <label for="email">Email Address*</label>
                <input  class="email" type="text" name="email" maxlength="80" size="30"></p>

 <p>               <label for="comments">Comments*</label>
                <textarea class="comments" name="comments"  cols="50" rows="10"></textarea></p>
<p>                

                <input class="submit" type="submit" value="Send"><a href="sendform_email.php">Submit</a></p>
                </form>
                </div>

Here's to easy reading!

[NogDog]

I happened to notice that you've used strlem() in a couple places where I'm sure you wanted to use strlen/color.

Also, for debugging purposes, try adding this at the start of your PHP script:

<?php
ini_set('display_errors', 1); // set to 0 to turn off error messsages
error_reporting(E_ALL);

(Do that first, and I'm guessing you'll see an undefined function error for those strlem() calls, assuming there's not something else fatal happening before them. 😉 )

[tiridako]

Thanks NogDog, it helped me discover an error in one of the code. But now it is doing again, not showing error codes when I test the form. I am wondering if I pasted the debug code in correctly.

<?php 
ini_set('display_errors', 1); // set to 0 to turn off error messsages 
error_reporting(E_ALL);
	 if (!isset($_POST['email'])) {
	$email_to="[e-mail]";
	$email_subject="Tdkohnen.com Contact Reply";
}
function died($error) {
	echo "Error(s) are found with your submission. Please check the info you typed in and send again. ";
	echo "These errors appear below.<br /><br /> ";
	echo $error."<br /><br />";
	echo "Pleae go back and fix these errors. <br /> <br />";
	die ();
}

if (!isset($_POST['first']) ||
	!isset($_POST['email']) ||
	!isset($_POST['comments'])) {
	die('Sorry, there is a problem with your submission.');
}
	$first=$_POST ['first']; //required
	$email_from=$_POST ['email']; //required
	$comments=$_POST['comments']; //required

$error_message= " ";
$email_exp= '/^[A-Za-z0-9._&#37;-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}$/';

if(!preg_match($email_exp,$email_from)) {
$error_message .='The Email Address you entered does not appear to be valid.<br />'; }
$string_exp ="/^[A-Za-z .'-]+$/";
if(!preg_match($string_exp, $first)) {
$error_message .= 'The First Name you entered does not appear to be valid. Do you not have one?<br />';

if(strlen($error_message) < 2 )  {
$error_message .= 'The comments you entered is not valid.<br />';
}
	if(strlen($error_message) >0 ){
	died($error_message);
}
	$email_message = "Form details below. \n\n";
	function clean_string ($string) {
	$bad = array ("content-type", "bcc:", "to:","cc:","href");
	return str_replace($bad, "", $string);
}
	$email_message .="First name:" .clean_string($first_name)."\n";
	$email_message .="Email:" .clean_string($email)."\n";
	$email_message .="Comments:" .clean_string($comments)."\n";

//create email headers
	$headers='From:'.$email_from. "\r\n".
'Reply-To: '.$email_from."\r\n" .
'X-Mailer: PHP/' . phpversion();
@mail($email_to, $email_subject, $email_message, $headers); ?>


Thank you for contacting me. I'll be in touch with you very soon.

<?php
}
?>

[tiridako]

A bump here. I've been trying to fix the problem, and now back to zero, showing no error code when I try to submit. The previous post is the exact same code as it is now. (Copy and pasted and all). I would appreciate some guidance into this. I know to mark this thread as resolved when it is finished.

Thanks so much.

-Tiff

[Ashley_Sheridan]

You're not seeing errors because you told the call to mail to suppress any errors!

Take out the @ sign before it and you might see what's going on.

[tiridako]

May I ask which line is "@" on? I spot a few, and I don't see any @ symbol in the first 5 lines.

Thanks!

[Ashley_Sheridan]

It's right at the bottom, where you send the email:

@mail($email_to, $email_subject, $email_message, $headers); ?>

[tiridako]

Ah-ha, thank you!