disable save calculation

fireslug

My site is active, but the coders have gone to sleep on me - again, so I thought i might try and get some help to resolve a problem.

On the site, theres:

Original price
$0
Special Price
$3.25
You Save
$-3.25

If a user doesnt have an original price, there is a very annoying "You Save" that displays a minus (-) sign.

How can i disable the "You Save" if there is no normal price?.

I would the price to display with .00cents. How can I accomplish this?

I hope someone can help.

cheers

ric chan

Ashley_Sheridan

Without seeing any of the code, there's little anyone can do to help you. Have you tried to find the files that are displaying these prices? Just search the php files for 'Original price' or 'You save'

johanafm

(s)printf('%01.2f', $float); takes care of the decimal precision issue.

fireslug

Thanks guys. I have found the pages, where the code inextricably exists. Now to find the offending items.

My site resides here:

http://weeklyspecials.co.nz. If you have a bit of time, can you have a look at a page or 2, to hopefully offer better advise on a way to present the specials prices better?.

Thanks again for your help guys.

ric

Ashley_Sheridan

Once you find the files (better to distinguish them as files rather than pages, as one php script doesn't always mean one 'page') you will need to add an if statement in to check to see if the original value == 0. Without seeing the code I can't really be any more specific than that.

fireslug

Hi Ashley,

thanks so much for taking the time to help.

I am attaching a capture of the files that contain "special", but i have no idea which one will contain the code in question.

If you can have a look at the image, and let me know which one/s you think they are, maybe i can send you the code, if you have the time to have a look at them.

Thanks heaps Ashley.

ric

Ashley_Sheridan

I can't really tell anything from seeing a list of files in a directory. Have you actually tried to do a search for text in all files in the website directory?

fireslug

Hi Ashley

What would the code contain?

As you can see in the image, there are a number of files that contain "Special". But its the one that displays the specials onscreen that i need to locate, right?

What would that file be called (at a guess).

thanks heaps Ashley.

Ashley_Sheridan

I don't know, that's why you should do a search. I don't know what OS you're running, but they all have a 'find in files' option which you can use to search for the text 'You save'

fireslug

Hi Ashley

Looks like i need to do a fair bit of searching for the offending code.

Can i send you the code when i find it?

Thanks

Ashley_Sheridan

you don't have to open each file to search, use the file finder in your OS to find files containing the text I mentioned. a search should take minutes, if that.

fireslug

Hi Ashley, I think i've found the file.

Is this code:

			<div class="oneProductPageNowPrice oneProductPageInfoRow">
				<div class="oneProductPageLabel">
					<?php if ($product['typeid'] == $this->env->special) : ?>
						Special Price
					<?php else: ?>
						List price 
					<?php endif; ?>
				</div>
				<div class="oneProductPageLabelText">
					<?php if ($product['nowprice'] != -1) : ?>
					<?php echo $this->env->dollorSign . $product['nowprice']; ?>
					<?php endif; ?>
				</div>
			</div>

			<?php if ($product['typeid'] == $this->env->special) : ?>
			<div class="oneProductPageSave oneProductPageInfoRow">
				<div class="oneProductPageLabel">You Save</div>
				<div class="oneProductPageLabelText"><?php echo $this->env->dollorSign . ($product['originalprice'] - $product['nowprice']); ?></div>
			</div>

Ashley_Sheridan

Yes, that's the one. Change the last if statement to check that the original price (I'd write an example but the variable for the original price isn't included in your code excerpt!) is greater than zero.

The variable is probably something like $product['originalprice'] I would guess.

fireslug

Thanks Ashley, i will give it a go.

I really appreciate your help.

cheers

ric

fireslug

Hi Ashley, I went further up and can see the if's. Are these the items that need changing?

		<?php if ($product['typeid'] == $this->env->special) : ?>
			<div class="oneProductPageOrgPrice oneProductPageInfoRow">
				<div class="oneProductPageLabel">
						Original price 
				</div>
				<div class="oneProductPageLabelText">
					<?php if ($product['originalprice'] != -1) : ?>
					<?php echo $this->env->dollorSign . $product['originalprice']; ?>
					<?php endif; ?>
				</div>
			</div>
			<?php endif; ?>

			<div class="oneProductPageNowPrice oneProductPageInfoRow">
				<div class="oneProductPageLabel">
					<?php if ($product['typeid'] == $this->env->special) : ?>
						Special Price
					<?php else: ?>
						List price 
					<?php endif; ?>
				</div>
				<div class="oneProductPageLabelText">
					<?php if ($product['nowprice'] != -1) : ?>
					<?php echo $this->env->dollorSign . $product['nowprice']; ?>
					<?php endif; ?>
				</div>
			</div>

			<?php if ($product['typeid'] == $this->env->special) : ?>
			<div class="oneProductPageSave oneProductPageInfoRow">
				<div class="oneProductPageLabel">You Save</div>
				<div class="oneProductPageLabelText"><?php echo $this->env->dollorSign . ($product['originalprice'] - $product['nowprice']); ?></div>
			</div>

fireslug

Hi Ashley,

I dont know how to highlite the if, and associated funtion, but i see a -1 in there.

Should this be changed to something else? eg. 00 or +1?

thanks.

ric

Ashley_Sheridan

You only need to change the if just before the 'You Save' text to:

<?php if ($product['typeid'] == $this->env->special && parseFloat($product['originalprice'])) : ?>

fireslug

Hi Ashley,

Just in from work, and saw your latest.

Thanks for that. I tried it out, inserting it 2 lines above the "you save" but it came up with the pic in the attachment.

It sort of worked, the you save price was removed.

Maybe i did it wrong.

Ashley_Sheridan

Sorry, that was my bad, I've been coding Javascript things all day, and parseFloat is a Javascript function! What you need is floatval().

fireslug

<?php if ($product['typeid'] == $this->env->special && floatval()($product['originalprice'])) : ?>