undefined variable

[hidroman]

thanks man, that really helped but i have 3 new errors.

<?php require_once('../Connections/museu.php'); ?> 
<?php 
if (!function_exists("GetSQLValueString")) { 
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{ 
  $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue; 

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue); 

  switch ($theType) { 
    case "text": 
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; 
      break;     

    case "long": 
    case "int": 
      $theValue = ($theValue != "") ? intval($theValue) : "NULL"; 
      break; 
    case "double": 
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL"; 
      break; 
    case "date": 
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; 
      break; 
    case "defined": 
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue; 
      break; 
  } 
  return $theValue; 
} 
} 

if (!eregi('^[a-zA-Z]+[a-zA-Z0-9_-]*@([a-zA-Z0-9]+){1}(\.[a-zA-Z0-9]+){1,2}', stripslashes(trim($_POST['Email'])) )) {
        $errors[] = '<font color="red">Please provide a valid email address.</font>';
    } else {
        $email = mysql_real_escape_string($_POST['Email']);
    }

if (!empty($_POST['Password'])) {
        if ($_POST['Password'] != $_POST['Confirmacao_da_password']) {
            $errors[] = '<font color="red">The 2 passwords you have entered do not match.</font>';
        } else {
            $password = $_POST['Password'];
        }
    } else {
        $errors[] = '<font color="red">Please provide a password.</font>';
    }

$editFormAction = $_SERVER['PHP_SELF']; 
if (isset($_SERVER['QUERY_STRING'])) { 
  $editFormAction .= "?" . htmlentities($_SERVER['QUERY_STRING']); 
} 

if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "form1"))  { 
  $insertSQL = sprintf("INSERT INTO login (Apelido, datadenascimento, loginpassword, confirmacaodepassword, loginemail, levellevel ) VALUES (%s, %s, %s, %s, %s, 2)", 
GetSQLValueString($_POST['nome:'], "text"),
GetSQLValueString($_POST['Apelido:'], "text"), 
GetSQLValueString($_POST['Data_de_Nascimento:'], "date"), 
GetSQLValueString($_POST['Password'], "text"), 
GetSQLValueString($_POST['Confirmacao_da_password'], "text"), 
GetSQLValueString($_POST['Email'], "text")); 
}
mysql_select_db($database_museu, $museu); 
$Result1 = mysql_query($insertSQL, $museu) or die(mysql_error()); 

  $insertGoTo = "login.php"; 
  if (isset($_SERVER['QUERY_STRING'])) { 
    $insertGoTo .= (strpos($insertGoTo, '?')) ? "&" : "?"; 
    $insertGoTo .= $_SERVER['QUERY_STRING']; 
  } 
  header(sprintf("Location: %s", $insertGoTo)); 

mysql_select_db($database_museu, $museu); 
$query_Recordset1 = "SELECT * FROM Login"; 
$Recordset1 = mysql_query($query_Recordset1, $museu) or die(mysql_error()); 
$row_Recordset1 = mysql_fetch_assoc($Recordset1); 
$totalRows_Recordset1 = mysql_num_rows($Recordset1); 
?>

[Derokorian]

You need to say what the errors are, otherwise we have no idea what to look for to help you out....

[hidroman]

sorry again, i forgot

the error is undefined variable: insertsql in c:\xampp\htdocs\site\registo2.php on line 59 query was empty

[johanafm]

What error do you expect to get from this code? (it's for this reason you get your error...)

unset($_POST['MM_insert']);
if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "form1"))
{
	$insertSQL = sprintf("");
}
$Result1 = mysql_query($insertSQL, $museu) or die(mysql_error());

[hidroman]

thanks dude but it keeps getting the same error :s

[Derokorian]

If something is true Crete the variable, you aren't doing anything when the if statement returns a false... therefore when the code continues to execute and the statements return false the variable doesn't exist.

[hidroman]

this is my whole code, i have done what you said but it keeps doing the same error.

<?php require_once('../Connections/museu.php'); ?> 
<?php 
if (!function_exists("GetSQLValueString")) { 
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{ 
  $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue; 

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) { 
    case "text": 
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; 
      break;      

    case "long": 
    case "int": 
      $theValue = ($theValue != "") ? intval($theValue) : "NULL"; 
      break; 
    case "double": 
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL"; 
      break; 
    case "date": 
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; 
      break; 
    case "defined": 
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue; 
      break; 
  } 
  return $theValue; 
} 
} 

if (!empty($_POST['Password'])) { 
        if ($_POST['Password'] != $_POST['Confirmacao_da_password']) { 
            $errors[] = '<font color="red">The 2 passwords you have entered do not match.</font>'; 
        } else { 
            $password = $_POST['Password']; 
        } 
    } else { 
        $errors[] = '<font color="red">Please provide a password.</font>'; 
    } 

$editFormAction = $_SERVER['PHP_SELF']; 
if (isset($_SERVER['QUERY_STRING'])) { 
  $editFormAction .= "?" . htmlentities($_SERVER['QUERY_STRING']); 
} 

unset($_POST['MM_insert']);
if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "form1"))  { 
  $insertSQL = sprintf("INSERT INTO login (nome, Apelido, datadenascimento, loginpassword, confirmacaodepassword, loginemail, levellevel ) VALUES (1, %s, %s, %s, %s, %s, 2)",
GetSQLValueString($_POST['nome:'], "text"), 
GetSQLValueString($_POST['Apelido:'], "text"), 
GetSQLValueString($_POST['Data_de_Nascimento:'], "date"), 
GetSQLValueString($_POST['Password'], "text"), 
GetSQLValueString($_POST['Confirmacao_da_password'], "text"), 
GetSQLValueString($_POST['Email'], "text")); 
}
mysql_select_db($database_museu, $museu); 
$Result1 = mysql_query($insertSQL, $museu) or die(mysql_error()); 

  $insertGoTo = "login.php"; 
  if (isset($_SERVER['QUERY_STRING'])) { 
    $insertGoTo .= (strpos($insertGoTo, '?')) ? "&" : "?"; 
    $insertGoTo .= $_SERVER['QUERY_STRING']; 
  } 
  header(sprintf("Location: %s", $insertGoTo)); 

mysql_select_db($database_museu, $museu); 
$query_Recordset1 = "SELECT * FROM Login"; 
$Recordset1 = mysql_query($query_Recordset1, $museu) or die(mysql_error()); 
$row_Recordset1 = mysql_fetch_assoc($Recordset1); 
$totalRows_Recordset1 = mysql_num_rows($Recordset1); 
?>

[bradgrafelman]

Posts moved into a new thread; please keep the discussion in the stickied "Parse error" thread limited to that of parse errors only (in other words, new problem == new thread).

hidroman wrote:

i have done what you said

..which is your first mistake. johanafm didn't say to do anything - he gave an example code snippet and asked you a question. Rather than answering it, however, you made the second mistake of blindly copying and pasting it into your own code.

Look at these two lines you now have:

unset($_POST['MM_insert']); 
if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "form1"))  { 

Read them and comprehend them. They shouldn't make sense to you (hint: the isset() call will never return true). Get rid of the unset() line.

Then, look at your logic for that if() statement (as has already been suggested). What happens if that if() condition evaluates to FALSE? You won't be setting $insertSQL, of course. Yet the next statement outside of that if() statement will still attempt to use that variable all the same. Notice the logic error now?

[hidroman]

sorry for all the trouble, im kind of noob at php and i have great problems understanding some parts of code.

i have a paper due in 6 hours and im kind of troubled :s

if you could explain a little better, i would appreciatted.