MySQL Insertion Problem

inulled

mysql_query("INSERT IGNORE INTO music (songname, artists, song_desc, url) 
VALUES('$song_name', '$artists','$song_desc','$url')") or die ("ERROR");

Does anybody see what's wrong with this code? I can't seem to pinpoint the problem. I'm getting the "ERROR" report.

bradgrafelman

First problem I see is that you're using an "or die()" construct (bad!) rather than gracefully handling the error. Second problem I see is that you're using a useless "or die()" construct; useless in that it doesn't tell you what the error is.

You should always be checking to see if [man]mysql_query/man returns boolean FALSE (indicating an error has occured) and, if so, displaying or logging the error (as appropriate) returned by the MySQL server (see: [man]mysql_error/man) and perhaps also including the SQL query string as it was sent to the SQL server (which is why I often construct the SQL query in a separate variable rather than inline with the mysql_query() call).

inulled

mysql_query("INSERT INTO music (songname, artists, song_desc, url)
VALUES('$song_name', '$artists','$song_desc','$url')") or die(mysql_error());

I'm guessing getting rid of IGNORE did the trick because it works now.

inulled

Thanks for your help.... btw, can you take a look at the troubled script in this link: http://www.phpbuilder.com/board/showthread.php?p=10983186#post10983186. Thanks again!