Mail() Script not working!

[jenkinzz]

I'm starting up my web design website, and I cant get the contact form to send me an email
I'm wondering if its (hopefully) some stupid syntax error. I can send emails to the account I want it to be sent to fine, and there aren't any filters on the email account.
Anyways, here's the code, or you can go to edificedg.com/contact.php to see the actual page

<?php 
						if (isset($_POST['submit'])) {	

						$first_name = $_POST['firstname'];
						$last_name = $_POST['lastname'];
						$email = $_POST['email'];
						$subject = $_POST['subject'];
						$sbjct = $subject . 'from' . $first_name . $lastname;
						$msg = $_POST['msg'];
						$output_form = false;
						$from = 'From:' . $email;

						if (empty($first_name) or empty($last_name) or empty($email) or empty($subject)) {

							echo '<p class="alert" >Why don\'t you double check the form? I think you missed something</p>';
							$output_form = true;
						}

						else {

							mail("[e-mail]",$sbjct,$msg,$from);
							echo '<p class="alert"> Thanks for your ' . $subject . ', ' . $first_name . '!<br />' . 'An email has been sent to us with your form information.</p> <br /><br /><br /><br /><br />';
							$output_form = false;
						}
					}

					else {
							$output_form = true;
					}

					if ($output_form) {
				?>		
                <form name="form" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
                <table>
                <caption>Get to know us better! Fill out this form to send an email for a quote or to ask us a question.</caption>

					<tr>
						<td class="label"><label for="firstname">Name:</label></td>
						<td class="input">
                        	<input class="short" name="lastname" id="firstname" type="text" value="<?php if (isset($_POST['submit'])) {echo $last_name;} else {echo 'Last';} ?>" size="16" maxlength="16"  style="float:right">
                        	<input class="short" name="firstname"  id="lastname" type="text" value="<?php if (isset($_POST['submit'])) {echo $first_name;} else {echo 'First';} ?>" size="16" maxlength="16" style="float:right; margin-right:10px;">
                       	</td>
					</tr>
					<tr>
						<td class="label"><label for="email">Email:</label></td>
						<td class="input">
                        	<input class="long" name="email" id="email" type="text" value="<?php echo $email; ?>" size="38" maxlength="32" style="float:right">
                        </td>
					</tr>
					<tr>
						<td class="label"><label for="subject">Subject:</label></td>
						<td class="input">
                        	<select name="subject" id="subject" style="float:right" >
								<option value="interest">I'd like a questionnaire, please</option>
                                <option value="question">I have a question for you</option>
							</select>
                       	</td>
					</tr>
					<tr>
						<td class="label"><label for="msg">Optional Message:</label></td>
						<td class="input">
                        	<textarea name="msg" id="msg" style="float:right"><?php echo $msg; ?></textarea> 
                        </td>
					</tr>
					<tr>
						<td class="label">&nbsp;</td>
						<td class="input">
                        	<input name="submit" type="submit" value="Submit" style="float:right">
                       	</td>
					</tr>


				</table>
                </form>
            	<?php } ?>

[Derokorian]

First add a test for mail function IE:

if( mail($to,$sub,$msg,$headers) ) {
   echo 'Thanks for contacting me!';
} else {
   echo 'Message didn\'t send. Please check your code.';
}

Also you may just want to include their email in a reply-to header instead of trying to spoof the from address. Alot of providers will block, or take a long time to accept when sending from a non matching address.

[jenkinzz]

I added the test, and they all have values:

....

else {

						   if (mail("[e-mail]",$sbjct,$msg,$from)) {

							mail("[e-mail]",$sbjct,$msg,$from);
							echo "$sbjct | $msg | $from";
							echo '<p class="alert"> Thanks for your ' . $subject . ', ' . $first_name . '!<br />' . 'An email has been sent to us with your form information.</p> <br /><br /><br /><br /><br />';
							$output_form = false; }

						   else { echo 'It didnt work!';}
						}
......

The test is in the live code on the site, so you can see for yourself

I got [ interestfromJohnsmith | hey there | From:[e-mail] ] when i tried it out

I haven't tried the reply-to header, I'll have to look up the syntax for it

Thanks for the suggestions

[Derokorian]

Using your variables you would do (for example)

$from = "From: [e-mail]". PHP_EOL;
$from .= "Reply-To: ". $email . PHP_EOL;

I use PHP_EOL because it tends to be more reliable for me on different systems. Also you should validate the input so your script isn't high-jacked. AKA

$email = ( ISSET($_POST['email']) && filter_var($_POST['email'],FILTER_VALIDATE_EMAIL) ) ? filter_var($email,FILTER_SANITIZE_EMAIL) : 'Invalid Email';

[jenkinzz]

Thank you so much!!! After Isolating the different elements it seems the . PHP_EOL; is what did the trick
Thanks for the tip about validating the code, I'm only just getting to security, validation, etc in my php book

thanks again