Notice: Undefined variable Error

[watson100]

Hello,
Im not amazing with php so this error is giving me some trouble.

Here are the errors -

Notice: Undefined variable: userid in process.php on line 13

Notice: Undefined variable: rowAccount in process.php on line 21

Notice: Undefined variable: submitted in process.php on line 25

Now here is my code -

<?php
require_once("db/connect.php");

session_start();

//Field Data
if (isset($_POST['userid'], $_POST['password'], $_POST['submit'])){
$userid		=	$_POST['userid'];
$password	=	$_POST['password'];
$submitted	=	$_POST['submit'];
}

if ($userid && $password){
//////////////////////////////////////////////////
$query		= sprintf("SELECT * FROM users WHERE user_name='$userid' AND user_password='$password'");
$result		= @mysql_query($query);
$rowAccount	= @mysql_fetch_array($result);
//////////////////////////////////////////////////
}

if ($rowAccount){
$_SESSION['id'] = $rowAccount['user_id'];
header("Location:user_area/");
exit;
}elseif($submitted){
echo "No user in our database!";
}
?>

I will be very grateful for any help.

[Cetera]

The reason you getting those errors is that you are calling variables that might not been set due to having another if such as:

if (isset($_POST['userid'], $_POST['password'], $_POST['submit'])){ 
$userid        =    $_POST['userid']; 
$password    =    $_POST['password']; 
$submitted    =    $_POST['submit']; 
} 

If that condition does not pass none of the variables will be set, however the script keeps running and cant find the variables and throw an error, try something like this:

<?php 
require_once("db/connect.php"); 

session_start(); 

//Field Data 
if (isset($_POST['userid'], $_POST['password'], $_POST['submit'])){ 
	$userid        =    $_POST['userid']; 
	$password    =    $_POST['password']; 

if ($userid && $password){ 
	////////////////////////////////////////////////// 
	$query        = sprintf("SELECT * FROM users WHERE user_name='$userid' AND user_password='$password'"); 
	$result        = @mysql_query($query); 
	$rowAccount    = @mysql_fetch_array($result); 
	////////////////////////////////////////////////// 
	if ($rowAccount){ 
		$_SESSION['id'] = $rowAccount['user_id']; 
		header("Location:user_area/"); 
		exit; 
	} else { 
		echo "No user in our database!"; 
	} 
} 
else
{
	// Do something if userid or password is missing
}
}
else
{
	// Do something if everything is missing
}
?>

[watson100]

Ah thankyou, its fixed. Thanks for your help.

[watson100]

Hmm unfortunately i am still having a problem. No errors but it is not doing what its supposed to do.

Here is my updated code -

<?php 
require_once("db/connect.php"); 

session_start(); 

//Field Data 
if (isset($_POST['userid'], $_POST['password'], $_POST['submit'])){ 
    $userid        =    $_POST['userid']; 
    $password    =    $_POST['password']; 
    $submitted    =    $_POST['submit']; 

if ($userid && $password){ 
    ////////////////////////////////////////////////// 
    $query        = sprintf("SELECT * FROM users WHERE user_name='$userid' AND user_password='$password'");
    $result        = @mysql_query($query); 
    $rowAccount    = @mysql_fetch_array($result); 
    ////////////////////////////////////////////////// 
    if ($rowAccount){ 
        $_SESSION['id'] = $rowAccount['user_id']; 
        header("Location:user_area/"); 
        exit; 
    } else { 
        echo "No user in our database!"; 
    } 
} 
else 
{ 
    echo "You have not filled in all the fields";
} 
} 
else 
{ 
    echo "You must fill in the everything to login";
} 
?>

But now say when i fill in one field and leave the other one blank then it gives me this echo -

echo "You must fill in the everything to login";

And when i fill in both fields and say that user isnt in the db which is what it should say (or something very close) if gives me the same message -

echo "You must fill in the everything to login";

[Cetera]

Oki as it echo's 'You must fill in the everything to login' when posting a form it means that your first IF does not meet the requirements.

Make sure you got this form fields:
userid, password, submit (Submit can also be the name of your submit button)

If one of those is missing in your form the condition will not be meet and it will there for output

You must fill in the everything to login

You can use add

echo '<pre>';
print_r($_POST);
echo '</pre>';

after your session_start() to see what you sending and make sure you are posting all the form fields needed and they got a value

[watson100]

Ok so i put that bit of code in after session_start(); and got these arrays -

Array
(
    [userid] => 
    [password] => 
    [submitted] => 
    [Submit] => Submit
)

Also here is the actual form -

<form id="form1" name="form1" method="post" action="process.php">
<div id="field"><label>Username</label><input type="text" id="userid" name="userid" size="25" /></div>
<div id="field"><label>Password</label><input type="password" id="password" name="password" size="25" /></div>
<input type="hidden" id="submitted" name="submitted" />
<input type="submit" id="Submit" name="Submit"  />
</form>

[Cetera]

Right here we go the problem 🙂

you sending your form with Submit while you checking for submit

Change:

if (isset($_POST['userid'], $_POST['password'], $_POST['submit'])){ 

to

if (isset($_POST['userid'], $_POST['password'], $_POST['Submit'])){ 

and it should do it

[watson100]

Ah thanks, it works. Thank you very much