[RESOLVED] help with unexpected T_ENCAPSED_AND_WHITESPACE

[phn_uk]

Hi friends,

could anyone help me with this code:

<?php
	mysql_connect('localhost','root','');
	mysql_select_db('movie');
	mysql_query("UPDATE film SET film_name='$_POST['name']', film_year='$_POST['year']' WHERE film_id=$_GET['id']");
?>

i'm getting the unexpected T_ENCAPSED_AND_WHITESPACE every time.
I looked at it over and over but coudn't find where the problem is.

[bradgrafelman]

Welcome to PHPBuilder! When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

As for your problem, you can't reference array items with a quoted string index/key (unless you use the 'complex syntax' - e.g. adding {} braces around the variable reference). See this manual page for more information/examples (specifically, take a look at the section following the text 'More examples to demonstrate this behaviour:').

EDIT: Also note that user-supplied data should never be placed directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize the data with a function such as [man]mysql_real_escape_string/man (for string data) or use prepared statements.

[phn_uk]

I tried what you said but still the same.

<?php
	mysql_connect('localhost','root','');
	mysql_select_db('movie');
	mysql_query("UPDATE film SET film_name='{$_POST['name']}', film_year='{$_POST['year']}' WHERE film_id=$_GET['id']");
?>

[bradgrafelman]

You still have the same problem - you only fixed 2 of the 3 occurrences of it.

[phn_uk]

thanks a lot for help, you were right, i forgot the last item. it's been solved.