script upload images and adds to db but does not work on videos

sayimcrisp

im new to this and am looking to make a fairly simple script to upload videos and thumbnails then insert video and thumbnail path, title,and date to the db, but its not working on videos.
if I use images, everything works fine, but if I use a video file, it doesnt work...

any ideas? here is the php script

<?php
//connect to database
include_once "../include/connect_to_mysql.php";
//specify redirect URL
$redirect = "success.php";
//then
$imgname = $_FILES["image"]["name"];
$vidname = $_FILES["video"]["name"];
$imgtempname = $_FILES["image"]["tmp_name"];
$vidtempname = $_FILES["video"]["tmp_name"];
//moves file into directory
move_uploaded_file($imgtempname , "../media/videothumbs/" . $imgname);
move_uploaded_file($vidtempname , "../media/videos/" . $vidname);
//then you have to add the names of these files and two other fileds to database
$runtime = $_POST['runtime'];
$title = $_POST['title'];
$description = $_POST['description'];
//ad all the details to database
$query = "INSERT INTO videos (dateAdded, title, runtime, image, description, video) VALUES (now(), '$title', '$runtime', '$imgname', '$description', '$vidname')";
$results=mysql_query($query);
//redirect user
header('Location: '.$redirect); die;
?>

also, here is the form being used:

<form method="post" action="parseVideo.php" enctype="multipart/form-data"> 
<p><strong>Title:</strong><br> 
<input type="text" name="title" id="title" size="80">
</p>
<p><strong>Description:</strong><br> 
<input type="text" name="description" id="description" size="100"> 
</p>
<p><strong>Time (format hh:mm:ss):</strong><br> 
<input name="runtime" id="runtime" type="text" size="20"> 
</p>
<p> </p>
<h2></h2> 
<p><strong>Thumbnail Image:</strong><br>
<input type="file" name="image" id="image" size="50" class="textfield2"/>
</p>
<p> </p>
<p><h2></h2> </p>
<p><br>
<strong><font color="#FF0000">Video (flv and mp4 only):</font></strong><br> 
<input type="file" name="video" id="video" size="50" class="textfield3"> 
</p>
<p><input type="submit" name="submit" value="Submit" class="medium awesome">
</form>

NogDog

Any error messages? If not, have you turned on all error reporting?

bradgrafelman

When posting PHP or HTML code, please use the board's [noparse]

..

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

Just to add on to what NogDog said (and add a bit more):

Diagnostically speaking, "it doesnt[sic] work" tells us nothing we don't already know (we already know it doesn't work - if it did you wouldn't be here asking for help 😉). How doesn't it work? What happens? Does anything get added to the database? Were either or both files uploaded? Did you receive any PHP error messages? If not, have you verified that either log_errors or display_errors is set to On and error_reporting is set to E_ALL?
Normally, I like to process file uploads like this:
```
if($_FILES['file']['error'] == UPLOAD_ERR_OK) {
    // process file upload
} else {
    // output/log helpful message(s) indicating what type of error has occured
}
```
For more information about the values the 'error' index can take on, see the manual page: [man]features.file-upload.errors[/man].
Similarly, you should also be checking whether [man]move_uploaded_file/man succeeded, e.g.:
```
if(!move_uploaded_file(...)) {
    // error while moving file
}
```
However, this is more or less just a benefit for your users; if move_uploaded_file() fails, PHP will generate an error message (which you should be logging in your production environment for later review) that explains what went wrong.
Similarly yet again, you should be checking to see if [man]mysql_query/man failed; if it returns boolean FALSE, you should be logging (or displaying, if in the development environment) the error message returned by the MySQL server (see: [man]mysql_error/man) and perhaps the entire SQL query as well (it often helps to see the query that was sent when trying to understand the error message it produced).
User-supplied data should never be placed directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize it with a function such as [man]mysql_real_escape_string/man (for string data) or use prepared statements.

sayimcrisp

bradgrafelman,

I just added the error reporting you suggested but there just isn't any errors showing...if I just try to upload an image, it works just fine, but if I try with a video, it doesn't not work. well it does insert the current date and increments the id up by one but no title, video, image.

if you were writing a file upload script similar to this, how would you write it?