[RESOLVED] help using $get

imad_imike

Hi, I'm having a bit of trouble using the $get method. I can get the first part to work fine like so:

$id = isset($_GET['id']) ? (int) $_GET['id'] : 0;
	$SQL ="SELECT * FROM Entry WHERE EntryID= '$id'";
    $result = mysql_query($SQL) or die(mysql_error());

But i need to collect all data associated with the EntryID from the database.

I've tried setting up variables like so:

while ($row = mysql_fetch_assoc($result))
{
    $entryName = $row['EntryName'];
    $entryDate = $row['EntryDate'];
    $entryValue = $row['EntryValue'];
    $entrySelect = $row['EntrySelect'];
    $entryBalanceSheet = $row['EntryBalanceSheet'];
    $entryID = $row['EntryID'];

but as soon as I put this while script in, I get a blank screen.

Any ideas or help is appreciated.

bradgrafelman

Show us more of the code when you attempted to use the while loop.

Also, the "blank screen" is likely do to a parse error. Turn display_errors On and set error_reporting to E_ALL while developing so that you can see these errors.

imad_imike

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
<?php
	require_once('#######.php');
	DBConnect();
	session_start();
	ob_start();
	$today  = getCurrentDate();

	$id = isset($_GET['id']) ? (int) $_GET['id'] : 0;
$SQL ="SELECT * FROM Entry WHERE EntryID= '$id'";
$result = mysql_query($SQL) or die(mysql_error()); 

  while ($row = mysql_fetch_assoc($result))
{
    $entryName = $row['EntryName'];
    $entryDate = $row['EntryDate'];
    $entryValue = $row['EntryValue'];
    $entrySelect = $row['EntrySelect'];
    $entryBalanceSheet = $row['EntryBalanceSheet'];
    $entryID = $row['EntryID'];

?>


</head>

The blank screen only happens when I add the 'while' statement.

Ill start from the beggining, on the main page, theres a table with a list of entrys, next to each one theres a view button.
I've set it up so that when each seperate entry is clicked it displays the EntryID for that specific entry in the address ie

"www.######.co.uk/FixedAssetView.php?id=54&action=view"
So thats the address which comes up when i clicked the entry with EntryID 54.

Now im struggling with getting the rest of that entrys details which are stored in the database.

I just presumed it was that while statement because thats what causes the blank screen.

bradgrafelman

First problem I see is that you never close the '{' opening brace of the while loop. Second problem I see is that you never actually use any of the variables in the while loop.

Third (unrelated) problem I see is that you're calling [man]session_start/man after data is being outputted. You shouldn't do this, since the only way that won't cause an error is if output buffering is enabled (meaning the server has to waste memory for every request just to hold some/all of your script's output in memory just because of sloppy coding). Fourth problem would be the presence of ob_start() - why is that even there?

imad_imike

bradgrafelman;10984984 wrote:
First problem I see is that you never close the '{' opening brace of the while loop. Second problem I see is that you never actually use any of the variables in the while loop.

Third (unrelated) problem I see is that you're calling [man]session_start/man after data is being outputted. You shouldn't do this, since the only way that won't cause an error is if output buffering is enabled (meaning the server has to waste memory for every request just to hold some/all of your script's output in memory just because of sloppy coding). Fourth problem would be the presence of ob_start() - why is that even there?

Wow, i feel like im back at school getting shouted at by my teacher lol.

Thanks for your help mate and i sorted the problem.
It was me not closing the while loop with '}'.