[RESOLVED] Checkboxes and Database

[jhlew]

Hi all,

I have a row of checkboxes that I would like to save into my database. I want to submit 5 checkboxes that will save a "1" into the database when checked with one form submit button. I have read all about this but I still cannot seem to figure it out. what would the code look like for this?

[leatherback]

What have you tried, and what errors are you getting

[sorry, this is a forum aimed at getting you to learn yourself. Only from your mistakes will you really learn how to get there. Us just posting the script.. Well, let's say the forum doesn't pay us enough for that)

[jhlew]

<?php
if (isset($_POST["r1a"])) {
$r1a=1;
} else {
$r1a=0;
}

if (isset($_POST["r1b"])) {
$r1b=1;
} else {
$r1b=0;
}

$sqlupdate = mysql_query("update finances set (r1a,r1b) Values ('$r1a','r1b') where mem_id='$id'");
?>

.....

<form action="Finances.php" enctype="multipart/form-data" method="post" name="r1a" id="r1a">
<input type="checkbox" name="r1a" value="1"/>
</form>

.....

<form action="Finances.php" enctype="multipart/form-data" method="post" name="r1b" id="r1b">
<input type="checkbox" name="r1b" value="1"/>
</form>

.....

<form action="Finances.php" enctype="multipart/form-data" method="post" name="r1a" id="r1a">

<input name="parse_var" type="hidden" value="r1a","r1b" />
<input type="submit" name="r1a","r1b" id="button1" value="Submit" />

</form>

<form action="Finances.php" enctype="multipart/form-data" method="post" name="r1b" id="r1b">

<input name="parse_var" type="hidden" value="r1b" />
<input type="submit" name="r1b" id="button1" value="Submit" />
</form>

r1a and r1b are the checkboxes that have a corresponding row in the database. That table is also linked to the page with the members id which is $id. mem_id is in the table with the checkboxes. I want to put a 1 next to the checked checkbox in the database.

thanks for the help.

[jhlew]

I forgot to tell you that I want to combine the buttons into one button that sends both checkboxes information to the databse.

[leatherback]

I think you were 90% there..

// note: You never set $id

$r1a = $r1b = 0;

if (isset($_POST["r1a"])) {
$r1a=1;
}
if (isset($_POST["r1b"])) {
$r1b=1;
}

$sqlupdate = mysql_query("update finances set (r1a,r1b) values (".$r1a.",".$r1b.") where mem_id='$id'");
?>

<form action="Finances.php" method="post" name="checkform" id="checkform">
<input type="checkbox" name="r1a" value="1"/>
<input type="checkbox" name="r1b" value="1"/>
<input type="submit" name="button1" id="button1" value="Submit" />
</form>

[jhlew]

okay, thats better.

I am not going to be able to have the button next to the checkbox because there will be several other forms mixed in that perform different tasks.

is there a way to have the button in a separate form that still performs the same task?

[leatherback]

Nope. Begs the question though.. WHY do you have several forms on one page, and you cannot put things together.

Naturally.. Using CSS you can place anything enywhere on the page, even though the code will put all together...

[leatherback]

Not true.. What I said before.. You could use javascript, with an onclick: form.FORMNAME.submit. Still.. Better would be to organize things in a way that your structure fits the function.

[bradgrafelman]

Also note that this:

$r1a = $r1b = 0; 

if (isset($_POST["r1a"])) { 
$r1a=1; 
} 
if (isset($_POST["r1b"])) { 
$r1b=1; 
} 

could be reduced down to this:

$r1a = isset($_POST['r1a']) ? 1 : 0;
$r2a = isset($_POST['r2a']) ? 1 : 0;

[jhlew]

I appreciate the corrections. I am restructuring my forms into one form. I will see if I can do it then click resolved or I will repost. Thanks for the help.

[jhlew]

okay this is what I am trying to apply this too and its not submit correctly to database. I want the checkboxes to change the value in the database to 1 and the description to input the text into the database. All in one form and one submit button.

<?
$sql_finances = mysql_query("SELECT * FROM finances WHERE mem_id='$id'");

while($row = mysql_fetch_array($sql_finances)){ 

$description = $row["description"];
$r1a = $row["r1a"];
$r1b = $row["r1b"];	
$r1c = $row["r1c"];	
$r1d = $row["r1d"];	
$r1e = $row["r1e"];	
$r1f = $row["r1f"];	
$r1g = $row["r1g"];	
$r1h = $row["r1h"];	
$r1i = $row["r1i"];	
$r1j = $row["r1j"];		
}

if ($_POST['description'] == "description"){

    $description = $_POST['description'];
	$description = eregi_replace("'", "'", $description);
	$description = eregi_replace("`", "'", $description);
    $description = mysql_real_escape_string($description);
    $description = nl2br(htmlspecialchars($_POST['description']));
}


$r1a = isset($_POST['r1a']) ? 1 : 0;
$r1b = isset($_POST['r1b']) ? 1 : 0;
$r1c = isset($_POST['r1c']) ? 1 : 0;
$r1d = isset($_POST['r1d']) ? 1 : 0;
$r1e = isset($_POST['r1e']) ? 1 : 0;
$r1f = isset($_POST['r1f']) ? 1 : 0;
$r1g = isset($_POST['r1g']) ? 1 : 0;
$r1h = isset($_POST['r1h']) ? 1 : 0;
$r1i = isset($_POST['r1i']) ? 1 : 0;
$r1j = isset($_POST['r1j']) ? 1 : 0;


$sqlupdate = mysql_query("UPDATE finances (description, r1a, r1b, r1c, r1d, r1e, r1f, r1g, r1h, r1i, r1j) 
     VALUES('$description',".$r1a.", ".$r1b.", ".$r1c.", ".$r1d.", ".$r1e.", ".$r1f.", ".$r1g.", ".$r1h.", ".$r1i.", ".$r1j.") WHERE mem_id='$id'");

?>

<form action="Finances.php" enctype="multipart/form-data" method="post" name="checkform" id="checkform">
  <tr>
    <td><input name="description" type="text" class="formFields" id="description" value="<?php print "$description"; ?>" size="20" maxlength="20" /></td>
    <td><input type="checkbox" name="r1a" value="1"/></td>
    <td><input type="checkbox" name="r1b" value="1"/></td>
    <td><input type="checkbox" name="r1c" value="1"/></td>
    <td><input type="checkbox" name="r1d" value="1"/></td>
    <td><input type="checkbox" name="r1e" value="1"/></td>
    <td><input type="checkbox" name="r1f" value="1"/></td>
    <td><input type="checkbox" name="r1g" value="1"/></td>
    <td><input type="checkbox" name="r1h" value="1"/></td>
    <td><input type="checkbox" name="r1i" value="1"/></td>
    <td><input type="checkbox" name="r1j" value="1"/></td>
    <td><input type="submit" name="button1" id="button1" value="Submit" /></form></td>
  </tr>

[bradgrafelman]

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

Also... I'm confused; is all of that code on the same page? Which file are we looking at?

Assuming it's all from the same file (and assuming that you've shown us all of that file...), here are some problems I see or code I don't understand:

1. $sql_finances = mysql_query("SELECT * FROM finances WHERE mem_id='$id'"); 

   Where is the variable $id ever defined?

   Also, don't do 'SELECT ' - instead, only SELECT the columns from which you actually need data.
   

2. while($row = mysql_fetch_array($sql_finances)){ 
   
   $description = $row["description"]; 
   $r1a = $row["r1a"]; 
   $r1b = $row["r1b"];     
   
   $r1c = $row["r1c"];     
   
   $r1d = $row["r1d"];     
   
   $r1e = $row["r1e"];     
   
   $r1f = $row["r1f"];     
   
   $r1g = $row["r1g"];     
   
   $r1h = $row["r1h"];     
   
   $r1i = $row["r1i"];     
   
   $r1j = $row["r1j"];         
   
   } 

   Based on the fact that the loop above would be overwriting the values in the variables without ever having used them, I'm assuming that you expect the query to return at most one row? If so, you should add a 'LIMIT 1' to the query and get rid of the while() loop (a loop that you only want to execute one time isn't a "loop" at all, really).

3. This code:

   if ($_POST['description'] == "description"){ 
   
       $description = $_POST['description']; 
       $description = eregi_replace("'", "'", $description); 
       $description = eregi_replace("`", "'", $description); 
       $description = mysql_real_escape_string($description); 
       $description = nl2br(htmlspecialchars($_POST['description'])); 
   }

   doesn't make any sense. That if() block is only going to get executed if $_POST['description'] is equal to the word "description". Thus, none of those lines are going to do anything, since the word "description" doesn't contain any quotes or backticks, characters that [man]mysql_real_escape_string/man would escape, HTML 'special characters', or line breaks. You might as well just say:

   $description = 'description';

   inside the if() statement.

   In addition, why are you replacing a single quote with a single quote? Seems a bit silly. Likewise, why replace a backtick with a single quote?

   Finally, note that the call to nl2br() will never do anything since you already ran the data through [man]mysql_real_escape_string/man first (which replaces line breaks with a SQL-safe equivalent '\n' or '\r\n'). Also note that you'll usually want to call functions like [man]mysql_real_escape_string/man last (e.g. just before you actually put the data into a SQL query string).

4. This block of code:

   $r1a = isset($_POST['r1a']) ? 1 : 0; 
   $r1b = isset($_POST['r1b']) ? 1 : 0; 
   $r1c = isset($_POST['r1c']) ? 1 : 0; 
   $r1d = isset($_POST['r1d']) ? 1 : 0; 
   $r1e = isset($_POST['r1e']) ? 1 : 0; 
   $r1f = isset($_POST['r1f']) ? 1 : 0; 
   $r1g = isset($_POST['r1g']) ? 1 : 0; 
   $r1h = isset($_POST['r1h']) ? 1 : 0; 
   $r1i = isset($_POST['r1i']) ? 1 : 0; 
   $r1j = isset($_POST['r1j']) ? 1 : 0; 

   is going to overwrite the values retrieved from the DB in the while() loop mentioned above. So.. what's the point of querying the DB at all if you're just going to overwrite the values later on without ever using the values you retrieved?

[jhlew]

okay youre right. A few of thoughs functions do sound silly now that they are more clearly explained.

I have changed the description part to this

if ($_POST['parse_var'] == "description"){

    $description = $_POST['description'];
	$description = eregi_replace("'", "'", $description);
	$description = eregi_replace("`", "'", $description);
    $description = mysql_real_escape_string($description);
    $description = nl2br(htmlspecialchars($_POST['description']));
	$sqlUpdate = mysql_query("UPDATE finances SET description='$description' WHERE mem_id='$id'");
}

and I have changed the html to this

<form action="Finances.php" enctype="multipart/form-data" method="post" name="checkform" id="checkform">
  <tr>
    <td><input name="description" type="text" class="formFields" id="description" value="<?php print "$description"; ?>" size="20" maxlength="20" /><input name="parse_var" type="hidden" value="description" /></td>
    <td><input type="checkbox" name="r1a" value="1"/></td>
    <td><input type="checkbox" name="r1b" value="1"/></td>
    <td><input type="checkbox" name="r1c" value="1"/></td>
    <td><input type="checkbox" name="r1d" value="1"/></td>
    <td><input type="checkbox" name="r1e" value="1"/></td>
    <td><input type="checkbox" name="r1f" value="1"/></td>
    <td><input type="checkbox" name="r1g" value="1"/></td>
    <td><input type="checkbox" name="r1h" value="1"/></td>
    <td><input type="checkbox" name="r1i" value="1"/></td>
    <td><input type="checkbox" name="r1j" value="1"/></td>
    <td><input type="submit" name="button1" id="button1" value="Submit" /></form></td>
  </tr>

This works correctly for the description input and displays the input in the database in the blank and allows the user to change it.

Now I still need to get the checkboxes to work. I am still confused about how to get the checkboxes to input a 1 into the database when they are checked and the form is submitted.

And as far as $id goes ... I have not showed the entire page where I established $id as the session id.

All of the code I have showed you in on the same page called Finances.php.

thank you so much for your input, as I realize this may be very clear to someone more experienced, I am still learner. Thanks again.

[bradgrafelman]

jhlew wrote:

I am still confused about how to get the checkboxes to input a 1 into the database when they are checked and the form is submitted.

Does the last UPDATE query from your previous code not do that? Seems like it should.

If not, try echo'ing out the SQL query (it's helpful to build the query in a separate variable so you can do things like this easily) - what does it look like?

Also try doing a [man]print_r/man on the $_POST array so you can see all of the data that was POST'ed to the script.

[jhlew]

okay thanks everyone for the help. I got it all straightened out.