Problem using multiple If/ElseIf statements

[dial8]

Hey guys,

I'm hoping this is an easy solution to the following IF statements I have listed in my code below.

The validations work to an extent, however I'm running into contradictions between verify blank fields, as well verifying non unique values within the first field ($p_name).

Scenario 1 -> Entered/Submitted with blank values in all fields (Success - validation returned)
Scenario 2 -> Entered/Submitted unique values into all 4 fields (Success - data inserted)
Scenario 3 -> Entered/Submitted non unique value in the first field (Success - validation returned)

Scenario 4 -> Entered/Submitted with blank value in the first field, and the remaining 3 fields contain values (Failure - validation returned, however the data is still inserted from the 3 populated fields).

I'm basically seeing what I can do to resolve Scenario 4. Huge thanks in advance.

<?php
//including the database connection file
include_once("config.php");

if(isset($_POST['Submit']))
{

$p_name=$_POST['pie_name'];
$u_profile=$_POST['user_profile'];
$env=$_POST['environment'];
$instance=$_POST['instance_number'];

// checking empty fields

if(empty($p_name) || empty($u_profile) || empty($env) || empty($instance))
{
	//if PIE Name field is empty
	if(empty($p_name))
	{
		echo "<font color='red'>Pie Name field is empty.</font><br/>";
	}
	//if User Profile field is empty
	if(empty($u_profile))
	{
		echo "<font color='red'>User Profile field is empty.</font><br/>";
	}
	//if Environment field is empty
	if(empty($env))
	{
		echo "<font color='red'>Environment field is empty.</font><br/>";
	}
	//if Instance Number field is empty
	if(empty($instance))
	{
		echo "<font color='red'>Instance field is empty.</font><br/>";
	}
	//link to the previous page
	{
	// echo "<br/><a href='javascript:self.history.back();'>Go Back</a>";
	echo "<br/>Check 1!!!!!</a>";
	}
}
if(!empty($p_name) || !empty($u_profile))
{
	//if PIE Name field already exists
	if(mysql_num_rows(mysql_query("SELECT pie_name FROM pies WHERE pie_name = '$p_name'")))
	{
	echo "<font color='red'>Pie Name is not unique.</font><br/>";
	echo "<br/>Check 2!!!!!</a>";
	}
else
	{
	// considering System Profile ID as auto increment - primary key
	$add_to_system_profile = "insert into system_profile (environment,user_profile,instance_number) values ('$env','$u_profile','$instance')";
	mysql_query($add_to_system_profile);
	$last_inserted_mysql_id = mysql_insert_id();
	$add_to_pies_query = "insert into pies (pie_name, s_id) values ('$p_name','$last_inserted_mysql_id')";
	mysql_query($add_to_pies_query);

	// display success message
	echo "<font color='green'>Data added successfully.";
	echo "<br/><a href='index.php'>View Result</a>";
	}
}
}
?>

[leatherback]

The best way to organize that is to yourself load the form, and add an error message. Using javascript go back functionality is less reliable. So.. Create the form as a separate file which you can include at the end of the script. Create an array for the errors (With an entry for each field, just set to '') and when you load the form, you spit out the errors based on the messages araay. In the 'value' section of your text boxes you may echo out the originally filled out values.

<input type=\"text\" value=\"".$FilledOutValue."\">

[dial8]

Thanks for the prompt reply on my question. I'm not sure I completely understood what you stated in the last line of your response though?

Were you saying I should be setting the input variable for each value from the form_add.html page? Because I was able to set the input variables at the top of the add.php page.

I was able to get it working by using the following code below. Let me know if this matches up to what you mentioned. Perhaps there's a more efficient way with slimming down the code length, and still capturing the same logic. Thanks again!

<?php //Adding PIE and System Profile Data

$page_title = 'Add';
//including the database connection file
include_once("config.php");

// Check if the form has been submitted.
if (isset($_POST['submitted'])) {

$errors = array(); // Initialize error array.

$pn=$_POST['pie_name'];
$up=$_POST['user_profile'];
$env=$_POST['environment'];
$inst=$_POST['instance_number'];

// Check that the PIE Name has been entered, and doesn't already exist.
if (!empty($_POST['pie_name'])) {
	if (mysql_num_rows(mysql_query("SELECT pie_name FROM pies WHERE pie_name = '$pn'")))  {
		$errors[] = "<font color='red'>The Pie Name you've entered already exists.</font>";
	} else {
		$pn = trim($_POST['pie_name']);
	}
} else {
	$errors[] = "<font color='red'>You forgot to enter the Pie Name.</font>";
}


// Check for the User Profile.
if (!empty($_POST['user_profile'])) {
	if (mysql_num_rows(mysql_query("SELECT user_profile FROM system_profile WHERE user_profile = '$up'")))  {
		$errors[] = "<font color='red'>The User Profile you've entered already exists.</font>";
	} else {
		$up = trim($_POST['user_profile']);
	}
} else {
	$errors[] = "<font color='red'>You forgot to enter the Pie Name.</font>";
}

// Check for an environment.
if (empty($_POST['environment'])) {
	$errors[] = "<font color='red'>You forgot to enter the environment name.</font>";
} else {
	$env = trim($_POST['environment']);
}

// Check for an instance number.
if (empty($_POST['instance_number'])) {
	$errors[] = "<font color='red'>You forgot to enter the instance number.</font>";
} else {
	$inst = trim($_POST['environment']);
}

if (empty($errors)) {
	// considering System Profile ID as auto increment - primary key
	$add_to_system_profile = "insert into system_profile (environment,user_profile,instance_number) values ('$env','$up','$inst')";
	mysql_query($add_to_system_profile);
	$last_inserted_mysql_id = mysql_insert_id();
	$add_to_pies_query = "insert into pies (pie_name, s_id) values ('$pn','$last_inserted_mysql_id')";
	mysql_query($add_to_pies_query);

	// display success message
	echo "<font color='green'>Data added successfully.";
	echo "<br/><a href='index.php'>View Result</a>";
} else { // Report the errors.

	echo '<h1 id="mainhead">Error!</h1>
	<p class="error">The following error(s) occurred:<br />';
	foreach ($errors as $msg) { // Print each error.
		echo " - $msg<br />\n";
	}
	echo '</p><p>Please correct the errors and try again.</p><p><br /></p>';

} // End of if (empty($errors)) IF.

}
?>