[RESOLVED] whats wrong with this SIMPLE code SELECT * FROM

[lands]

<?php 
$userid=$_SESSION['userid'];
$con = mysql_connect("");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }
mysql_select_db('', $con);
$result = mysql_query('SELECT * FROM members WHERE userid=$userid'); 
while($row = mysql_fetch_array($result))
  {
  echo  

   "<img src='/image_files/". $row['userimage'] . "'>"; 


  }

mysql_close($con);



?>

EVERYTHING IS CONNECTED AND THE IMAGES ARE UPLOADING AND GOING INTO DATABASE BUT HAVING PROBLEMS SHOWING THEM, IVE BEEN ABLE TO DO IT ON OTHERPAGES BUT THIS ONE JUST NOT WORKING????

[lands]

THIS IS MY ERROR: Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in LINK on line 25

[leatherback]

You need to specify the database to which you would like to connect here:

mysql_select_db('', $con);

Personally, I like to use a special database connection include, separately, so you have it sorted for all your scripts:

function db_connect()
  {
  global $db_host, $db_user, $db_password, $db_name;

  $db_link = mysql_connect($db_host, $db_user, $db_password)
       or handle_errors("GEN", 1, 1, -1);
       mysql_select_db($db_name);
  return $db_link;
  }

function db_disconnect($db_link)
  {
  mysql_close($db_link);
  }  

[lands]

sorry im aware of that ive deleted out the conning pard i.e password and db name in my actuall code its all there ive deleted it once i posted it on here thanks

[leatherback]

then your query is not executing. See my footer.

Also: Best to place the query first in a variable so you can echo it out If it works you can still put all into the query directly.

[bradgrafelman]

Minor semantic issue:

leatherback;10985269 wrote:

then your query is not executing.

Technically, it is executing - it's just failing due to an error with the syntax.

@: Take a look at the PHP error message you showed us. It's telling you that you didn't give [man]mysql_fetch_array/man a valid MySQL result resource in the function's parameter list. In other words, $result does not contain a valid MySQL result resource.

Since $result contains the value returned from [man]mysql_query/man, you should visit the manual page for that function and see what types of values that function will return. You'll then see that a boolean FALSE return value indicates an error with your query.

Whenever there is an error with your query, you should be examining the error message returned by MySQL (see [man]mysql_error/man) as well as perhaps echo'ing out the SQL query itself (as leatherback is suggesting) so that you can visually inspect it to make sure it looks like what you expected it to.

By the way, you should also ensure that display_errors is set to On and error_reporting is set to E_ALL, because then you would have been alerted to the fact that $_SESSION['userid'] doesn't exist. It doesn't exist because you never called [man]session_start/man to start the session.

[cretaceous]

change this:
$result = mysql_query('SELECT FROM members WHERE userid=$userid');
to:
$result = mysql_query("SELECT FROM members WHERE userid=$userid");

[lands]

cretaceous;10985293 wrote:

change this:
$result = mysql_query('SELECT FROM members WHERE userid=$userid');
to:
$result = mysql_query("SELECT FROM members WHERE userid=$userid");

THANKS THIS IS THE ONE THAT WORKED TOP CODER

[Derokorian]

Please mark thread resolved if it indeed is, also caps lock should be turned off in the future. X-D

[mkartik17]

Make this as resolved...