User form processing

robin01

Hello,

User form processing.

objective:
1. save data
2 clear the user input fields & redisplay a clean form.

Problem area , i think(rest of the code below):

if(!empty($errors)) //works
{ // loop through error
foreach ($errors as $error) //works
echo '<strong>'. $error . '</strong><br />';
}
else // problem area, its not reaching the else statement
{ echo 'data saved';
$firstname ='';
$incident = '';
//not reaching the else statement
}

What am I doing wrong?


<?PHP
include("/include/Class.FieldCheck.php");
if (isset($_POST['submit']))
{	if(!isset($_POST['firstname'], $_POST['incident']))
	  	{  	$errors = array();
			 $firstname = $_POST['firstname'];
			 $incident = $_POST['incidnet'];	

		if(empty($firstname) || empty($incident))
		{	$errors[] = 'All fields are required'; 	}
		else
		{   $classOne = new FieldCheck;
			$errors[] = $classOne->CheckFirstname($firstname);
			$errors[] = $classOne->CheckIncidentNumber($incident);	  	
		} //end of else
 	} // Check form fields are empty - if statement	 

if(!empty($errors))
{ // loop through error
	foreach ($errors as $error)
	echo '<strong>'. $error . '</strong><br />';		
}
else // problem area, its not reaching the else statement
{	echo 'data saved';	
            $firstname ='';
             $incident = '';
	//not reaching the else statement 			
} 	
} 
// button check 
?>
<html>
<head>
<title> Add records to table </title>
<link rel="stylesheet" type="text/css" href="css/statusdisplay.css" />
<script type="text/javascript" src="fieldchecker.js"></script>
</head>
<body>
<h1> Add record </h1>
<form name="addform" action="<?PHP echo $_SERVER['PHP_SELF']; ?>" method="POST">
Firstname: <input type="text" value="<?PHP echo $firstname; ?>" name="firstname" /> <br /> 
Incident <input type="text"   value="<?PHP echo $incident; ?>"name="incidnet" /> <br />
<input type="submit" value="Submit button!" name="submit" />
</form>
</body>
</html>

bradgrafelman

Isn't it obvious why the 'else' statement is never being reached? $errors can never be empty, since you always insert at least one element into it.

robin01

Hey bradgrafelman,

Thanks for the replay. I figured I wasn't doing something right in that area..how do i fix the problem??

any help you can provide would be greatly appreciated.

thanks

bradgrafelman

That would depend on what the functions of this 'FieldCheck' class return. If you want to keep the same processing code down below (that simply checks if $errors is empty), then you need to add some if() statements to only store the return values from those functions into the $errors array if the return values indicate that an error has actually occurred. Otherwise, if the functions are returning whatever value indicates that no error has been found, don't store anything in the $errors array so that it remains empty.