[RESOLVED] Problem with foreach loop

[imad_imike]

Hi, I've created a fireach loop but its only showing one entry from the database when I know theres at least 6 entrys there.

heres my code

$rows = array();

$SQL1 = "SELECT * FROM Entry WHERE UserID = '$userID' AND EntryAdjustment IS NULL AND (EntrySelect=4 AND (EntryBalanceSheet=1))";
$result1 = mysql_query($SQL1) or die(mysql_error());
$num_rows = mysql_num_rows($result1);

if ($num_rows > 0 )
  {
  $NoOfEntries=true;
  while($row = mysql_fetch_array($result1))
  {

$EntryRW = $row['EntryRW'];
$EntryValue = $row['EntryValue'];
$EntryID = $row['EntryID'];
$EntryDate = $row['EntryDate'];
$EntryName = $row['EntryName'];
  }
    {
     $rows[] = $row; 
    }

if ($EntryRW==1)
				{
					$EntryValue = "-". $EntryValue;
				}
  if (EntrySelect==4 && EntryBalanceSheet==1);
  {
  	$Intangible= $Intangible + $EntryValue;
  }

  }

and heres my table with the foreach loop

if ($NoOfEntries == true)
  {
  foreach($rows as $row)
    {
    $sheetinfo = $row['EntryBalanceSheet'] =="1" ? "Intangible" : "Tangible";

  echo"
      <tbody>

	<tr>
	<td>".$EntryID."</td>
	<td>".$EntryDate."</td>     
	<td>".$EntryName."</td>
	<td>".$sheetinfo."</td>
	<td>".'&pound;'."".number_format(($EntryValue),2,".",",")."</td>
	<td></td>
	"?> 
	<td><?php printf('<a href="FixedAssetAddRate.php?id=%d&amp;action=Add"><img title="Add Depreciation Rate" src="css/button/plus.png"/></a>', $row['EntryID']);?>
	<?php echo"
	<td>
	<td>".'&pound;'."".number_format(($EntryValue),2,".",",")."</td>
	"?>  
	<td><?php printf('<a href="FixedAssetView.php?id=%d&amp;action=view"><img title="View This Fixed Asset" src="css/button/view.png"/></a>', $row['EntryID']);?>
	<td><?php printf('<a href="AccountEntry.php?ID=%d"><img title="Edit This Fixed Asset" src="css/button/edit.png"/></a>', $row['EntryID']);?>

	</tr>
		</tbody>
		<?php
			}

		}

else
	{
	echo "No entries";
	}
	 	 

The problem is that its not showing all the entrys, if I move the

{
     $rows[] = $row; 
    }

to here

$rows = array();

$SQL1 = "SELECT * FROM Entry WHERE UserID = '$userID' AND EntryAdjustment IS NULL AND (EntrySelect=4 AND (EntryBalanceSheet=1))";
$result1 = mysql_query($SQL1) or die(mysql_error());
$num_rows = mysql_num_rows($result1);

if ($num_rows > 0 )
  {
  $NoOfEntries=true;
  while($row = mysql_fetch_array($result1))
  {

 {
     $rows[] = $row; 
    }

$EntryRW = $row['EntryRW'];
$EntryValue = $row['EntryValue'];
$EntryID = $row['EntryID'];
$EntryDate = $row['EntryDate'];
$EntryName = $row['EntryName'];
  }


if ($EntryRW==1)
				{
					$EntryValue = "-". $EntryValue;
				}
  if (EntrySelect==4 && EntryBalanceSheet==1);
  {
  	$Intangible= $Intangible + $EntryValue;
  }

  }

It just repeats the same entry 6 times, which is how many entrys are in the query.

I hope this makes sense and someone can help

thanks in advance

if someone thinks it would be better to loop this in a different way, im open to any help or suggestions.

[Bonesnap]

You're only adding one entry to $row.

Write it like this:

while($row = mysql_fetch_array($result1))
{
    $EntryRW = $row['EntryRW'];
    $EntryValue = $row['EntryValue'];
    $EntryID = $row['EntryID'];
    $EntryDate = $row['EntryDate'];
    $EntryName = $row['EntryName'];
    $rows[] = $row;
}

Now the $rows array is inside the while loop and every time it iterates it adds one to the array.

Also, please indent/format your code a little neater so it's easier to follow through and debug. 🙂

[leatherback]

You really need to read the posts here. I gave you an example code for this, but you keep moving things around & removing brackets. If a code gives you an error message, it is not a matter of just removing things untill it works..

Anyway, here it is:

$NoOfEntries=false;

$SQL = "SELECT * FROM Entry WHERE UserID = '$userID' AND (EntrySelect=4 AND (EntryBalanceSheet=1) OR (EntryBalanceSheet=2))";

$result = mysql_query($SQL) or die(mysql_error());

$num_rows = mysql_num_rows($result);

if ($num_rows > 0 )
  {
  $NoOfEntries=true;
  while($row = mysql_fetch_array($resultspointer))
    {
    $rows[] = $row;
    }
  }

// then producing output somewhere else


if ($NoOfEntries === true)
  {
  // initiate table
  echo "<tbody>";

  foreach($rows as $row)
    {
    $sheetinfo = $row['entryBalanceSheet'] =="1" ? "Intangible" : "Tangible";

echo"
  <tr>
  <td>".$row['entryID']."</td>
  <td>".$row['entryDate']."</td>     <!-- Add imputs from database -->
  <td>".row['entryName']."</td>
  <td>".$sheetinfo."</td>
  </tr>";
}  // end foreach loop

echo  "</tbody>";

  }  // end: Results found
else
  {
   echo "No entries";
  } 

[imad_imike]

leatherback;10986286 wrote:

You really need to read the posts here. I gave you an example code for this, but you keep moving things around & removing brackets. If a code gives you an error message, it is not a matter of just removing things untill it works..

Anyway, here it is:

$NoOfEntries=false;

$SQL = "SELECT * FROM Entry WHERE UserID = '$userID' AND (EntrySelect=4 AND (EntryBalanceSheet=1) OR (EntryBalanceSheet=2))";

$result = mysql_query($SQL) or die(mysql_error());

$num_rows = mysql_num_rows($result);

if ($num_rows > 0 )
  {
  $NoOfEntries=true;
  while($row = mysql_fetch_array($resultspointer))
    {
    $rows[] = $row;
    }
  }

// then producing output somewhere else


if ($NoOfEntries === true)
  {
  // initiate table
  echo "<tbody>";

  foreach($rows as $row)
    {
    $sheetinfo = $row['entryBalanceSheet'] =="1" ? "Intangible" : "Tangible";

echo"
  <tr>
  <td>".$row['entryID']."</td>
  <td>".$row['entryDate']."</td>     <!-- Add imputs from database -->
  <td>".row['entryName']."</td>
  <td>".$sheetinfo."</td>
  </tr>";
}  // end foreach loop

echo  "</tbody>";

  }  // end: Results found
else
  {
   echo "No entries";
  } 

Hi, I found it easier putting the entrys into variables because I hit a couple of bumps in the road doing it the way you suggested and I couldnt figure them out.

The first problem was, getting the total figure for $row[EntryValue].
The only way I could get this to work was by putting it into variables like so

 
  if (EntrySelect==4 && EntryBalanceSheet==1);
  {
      $Intangible= $Intangible + $EntryValue;
  }

Ontop of this I had to Make some of the fugure show in negative, like so

 if ($EntryRW==1)
  {
      $EntryValue = "-". $EntryValue;
  }

Thats all regarding the totals. The next hurdle I hit was the view/edit buttons,
previously I had

<?php printf('<a href="FixedAssetAddRate.php?id=%d&amp;action=Add"><img title="Add Depreciation Rate" src="css/button/plus.png"/></a>', $row['EntryID']);?>

Which worked great, it goes to the correct url and carries over the $entryID to the next page, allowing me to use the $get method to display the information for the given ID. doing it in the echo statement which you showed yesterday, it wasnt carrying over the Entry ID to the next page.

Anyway, I'm entirely open to suggestions, If you think its easier writing it up without the variables, then that would be great. Or if you think it would be easier just keeping the variables and creating a different sort of loop.

Anyway, please help, I'm in a rutt,

Regards

Michael

[leatherback]

All these issues are easily fixed; I can not do this exactly from here, as I have no clue what you are trying to do:

In principle; During the data loop:

if ($num_rows > 0 )
  {
  $NoOfEntries=true;
  while($row = mysql_fetch_array($resultspointer))
    { 
    if($row['EntrySelect'] == 4 && $rwo['EntryBalanceSheet'] == 1)
      {
      // What is this intangible for/ You need it later? Make it an array
      $Intangible= $Intangible + $EntryValue;
      }

 if ($row['EntryRW'] ==1)
  {
   $row['EntryValue'] = "-". $EntryValue;
  }

$rows[] = $row; 



// When creating the links:
Echo "<a href=\"FixedAssetAddRate.php?id=".$row['EntryID']."&amp;action=Add\"><img title=\"Add Depreciation Rate\" src=\"css/button/plus.png\"/></a>";