[RESOLVED] Help creating a simple loop

imad_imike

Hi, Ive created my query and put value into variables but I'm struggling creating a loop so it displays all the entrys in a table and not just one.

heres my query and variables

$NoOfEntries=false;

$SQL1 = "SELECT * FROM Entry WHERE UserID = '$userID' AND EntryAdjustment IS NULL AND (EntrySelect=4 AND (EntryBalanceSheet=1))";
$result1 = mysql_query($SQL1) or die(mysql_error());
$num_rows = mysql_num_rows($result1);

if ($num_rows > 0 )
{
  $NoOfEntries=true;
  while($row = mysql_fetch_array($result1))
  {
  	 if (EntrySelect==4 && EntryBalanceSheet==1);
  	 { 
    	$IEntryRW = $row['EntryRW'];
    	$IEntryValue = $row['EntryValue'];
   		$IEntryID = $row['EntryID'];
   		$IEntryDate = $row['EntryDate'];
   		$IEntryName = $row['EntryName'];
   		$Isheetinfo = $row['EntryBalanceSheet'] =="1" ? "Intangible" : "Tangible";
   		$ITotal= $ITotal + $IEntryValue;
  	 if ($IEntryRW==0)
  	 {
        $IEntryValue = "-". $IEntryValue;
  	 }
  	 }
  }
}

And heres my table

 <tbody>

	<tr>
	<td><?php echo $IEntryID   ?></td>
	<td><?php echo $IEntryDate ?></td>     
	<td><?php echo $IEntryName ?></td>
	<td><?php echo $Isheetinfo ?></td>
	<td><?php echo '&pound'. number_format(($IEntryValue),2,".",",")?></td>
	<td></td>

	<td><?php printf('<a href="FixedAssetAddRate.php?id=%d&amp;action=Add"><img title="Add Depreciation Rate" src="css/button/plus.png"/></a>', $IEntryID);?>

	<td>
	<td><?php '&pound'. number_format(($IEntryValue),2,".",",")?> </td>

	<td><?php printf('<a href="FixedAssetView.php?id=%d&amp;action=view"><img title="View This Fixed Asset" src="css/button/view.png"/></a>', $IEntryID);?>
	<td><?php printf('<a href="AccountEntry.php?ID=%d"><img title="Edit This Fixed Asset" src="css/button/edit.png"/></a>', $IEntryID);?>

	</tr>

		</tbody>

I just need to loop the whole of the <tbody> to display a;; the entrys in the database and not just one.

Any help is appreciated

Thanks in advance

leatherback

Just to be sure: The table is in a completely different location than the position i nthe script where you are pulling this info right? Otherwise there is absolutely no need to make it with these cvariables storing info.

imad_imike

leatherback;10986296 wrote:
Just to be sure: The table is in a completely different location than the position i nthe script where you are pulling this info right? Otherwise there is absolutely no need to make it with these cvariables storing info.

yes there in different locations, the only reason I'm putting them in variables is because at a later date, it's going to get more complicated. I'll need to add a lot more variables and indroduce tabs to show each accounting year and then split it between accounting periods etc.

leatherback

I personally still think that just using the $row as a whole will make life easier, as you get all the data from one variable.

First of all: You need to make each variable an array first:

$IEntryRW = array();
etc

then in the data retrieval loop you can add to the array:
$IEntryRW[] = $row['EntryRW'];

In order to use it in the table you need to do something like:

foreach($IEntryRW as $id => $$IEntryRW_val)
  {
  <tbody>

    <tr>
    <td><?php echo $IEntryID_val   ?></td>
    <td><?php echo $IEntryDate[$id} ?></td>     
    <td><?php echo $IEntryName[$id} ?></td>
    <td><?php echo $Isheetinfo[$id} ?></td>
    <td><?php echo '&pound'. number_format(($IEntryValue[$id}),2,".",",")?></td>
    <td></td>

    <td><?php printf('<a href="FixedAssetAddRate.php?id=%d&amp;action=Add"><img title="Add Depreciation Rate" src="css/button/plus.png"/></a>', $IEntryID);?>

    <td>
    <td><?php '&pound'. number_format(($IEntryValue[$id}),2,".",",")?> </td>

    <td><?php printf('<a href="FixedAssetView.php?id=%d&amp;action=view"><img title="View This Fixed Asset" src="css/button/view.png"/></a>', $IEntryID[$id});?>
    <td><?php printf('<a href="AccountEntry.php?ID=%d"><img title="Edit This Fixed Asset" src="css/button/edit.png"/></a>', $IEntryID[$id});?>

    </tr>
<?php } ?>
        </tbody>

  }

imad_imike

wow, that was confusing. I'm usless at making loops.

I tried but failed, I done everything you said but missed out the [$id] and the _val in the table by accident and it gave me a list of entrys for the table just showing array() for them all.

Then I noticed I missed out the [$id] and _val, so I added them in and just got a white screen. 🙁

Ill get there eventually.

heres what I put

$IEntryRW = array();
$IEntryValue = array();
$IEntryID = array();
$IEntryDate = array();
$IEntryName = array();
$TEntryRW = array();
$TEntryValue = array();
$TEntryID = array();
$TEntryDate = array();
$TEntryName = array();
$NoOfEntries=false;

$SQL1 = "SELECT * FROM Entry WHERE UserID = '$userID' AND EntryAdjustment IS NULL AND (EntrySelect=4 AND (EntryBalanceSheet=1))";
$result1 = mysql_query($SQL1) or die(mysql_error());
$num_rows = mysql_num_rows($result1);

if ($num_rows > 0 )
{
  $NoOfEntries=true;
  while($row = mysql_fetch_array($result1))
  {
  	 if (EntrySelect==4 && EntryBalanceSheet==1);
  	 { 
    	$IEntryRW[] = $row['EntryRW'];
    	$IEntryValue[] = $row['EntryValue'];
   		$IEntryID[] = $row['EntryID'];
   		$IEntryDate[] = $row['EntryDate'];
   		$IEntryName[] = $row['EntryName'];
   		$Isheetinfo = $row['EntryBalanceSheet'] =="1" ? "Intangible" : "Tangible";
   		$ITotal= $ITotal + $IEntryValue;
  	 if ($IEntryRW==0)
  	 {
        $IEntryValue = "-". $IEntryValue;
  	 }
  	 }
  }
}

<?php 
         foreach($IEntryRW as $id => $$IEntryID_val)
         { 
    ?>
      <tbody>

	<tr>
	<td><?php echo $IEntryID_val ?></td>
	<td><?php echo $IEntryDate[$id] ?></td>     
	<td><?php echo $IEntryName[$id] ?></td>
	<td><?php echo $Isheetinfo[$id] ?></td>
	<td><?php echo '&pound'. number_format(($IEntryValue[$id]),2,".",",")?></td>
	<td></td>

	<td><?php printf('<a href="FixedAssetAddRate.php?id=%d&amp;action=Add"><img title="Add Depreciation Rate" src="css/button/plus.png"/></a>', $IEntryID[$id]);?>

	<td>
	<td><?php '&pound'. number_format(($IEntryValue[$id]),2,".",",")?> </td>

	<td><?php printf('<a href="FixedAssetView.php?id=%d&amp;action=view"><img title="View This Fixed Asset" src="css/button/view.png"/></a>', $IEntryID[$id]);?>
	<td><?php printf('<a href="AccountEntry.php?ID=%d"><img title="Edit This Fixed Asset" src="css/button/edit.png"/></a>', $IEntryID[$id]);?>

	</tr>
    <?php }?>
		</tbody>

regards

Michael

leatherback

My bad: $$IEntryID_val should have just one $: $IEntryID_val (sticky fingers)

Also, for the table, I think you need to move the (tbody) out of the foreach loop (No server here, so I cannot test scripts before posting)

imad_imike

Hi, I was still getting a blank screen after amending these 2 errors, so I Started from the beggining, done a bit of trial and error and the blank acreen only appears when I add the [] when collecting the variables. do I need to also add the [] to the arrays??

leatherback

Yes you do.

What I alway do: I add an echo whenever there is a problem somewhere. And I start off with a simple one-element test, and built te interface when data retreival is done. Meetings rest of the day.. away from machine for a while.

johanafm

If you get a blank screen, then you (most likely) have a parse error and error reporting turned off. A parse error prevents your php code from even starting to execute, since the entire script has to be parsed before execution.

Have a look at list of ini directives and look up display_errors, log_errors and error_reporting.