Parse error, Unexpected "{"

[Asbuster]

Right so im building a login system. However at the moment im having the problem as stated on the title of this topic. The file its in is a file that holds the functions such as registration, activation, password retrieval, etc.

The error is this: Parse error: syntax error, unexpected '{' in /.../loginsystem/user.functions.inc.php on line 121

The section the error is in is in the attachment. Its not the full file but im sure the error is in there somewhere. If not i can post the entire file if needed.

Hope someone can help me with this.

[Derokorian]

118        if (sendActivationEmail ($username, $password, $id, $email, $code)
119        && (sendAdministratorMail($username, $email, $id, $code))
120        

121    {

You are short one closing parenthesis on line 119

[Asbuster]

Thank you! This solved that problem. However now i have another problem in another section of the file. This time its in the changepassword function.

This error is what i get: Notice: Undefined variable: username in /.../loginsystem/user.functions.inc.php on line 18 Notice: Undefined variable: seed in /.../loginsystem/user.functions.inc.php on line 24 Notice: Undefined variable: currentpassword in /.../loginsystem/user.functions.inc.php on line 24

File is yet again uploaded in this reply 🙂

[Derokorian]

Line 14 there is an extra closing brace, which closes the function definition.

[Derokorian]

Check out this function definition with the consistent formatting:

function changePassword($username,$currentpassword,$newpassword,$newpassword2)
{
	global $seed;	
	if (!valid_username($username) || !user_exists($username))
	{
		return false;
	}
	if (! valid_password($newpassword) || ($newpassword != $newpassword2))
	{ 
		return false;
	}
//} Extra brace 
	// we get the current password from the database
	$query = sprintf("SELECT ... FROM ... WHERE username= '%s' LIMIT 1",
	mysql_escape_string($username));
	$result = mysql_query($query);
	$row= mysql_fetch_row($result);

// compare it with the password the user entered, if they don't match, we return false, he needs to enter the correct password.
if ($row[0] != sha1($currentpassword.$seed))
{
	return false;	
}

// now we update the password in the database
$query = sprintf("update ... set ... = '%s' where ... = '%s'",
	mysql_escape_string(sha1($newpassword.$seed)), mysql_escape_string($username));

if (mysql_query($query))
{
	return true;
}
else
{
	return false;
}
return false;
}

See how much easier it is to tell where the closing braces are for each associated opening? This makes it much easier to tell when you miss one (or in this case add an extra). Also note that an update query returns true or false, so you could change the end of the function to be:

function changePassword($username,$currentpassword,$newpassword,$newpassword2)
{
	global $seed;	
	if (!valid_username($username) || !user_exists($username))
	{
		return false;
	}
	if (! valid_password($newpassword) || ($newpassword != $newpassword2))
	{ 
		return false;
	}
//} Extra brace 
	// we get the current password from the database
	$query = sprintf("SELECT ... FROM ... WHERE username= '%s' LIMIT 1",
	mysql_escape_string($username));
	$result = mysql_query($query);
	$row= mysql_fetch_row($result);

// compare it with the password the user entered, if they don't match, we return false, he needs to enter the correct password.
if ($row[0] != sha1($currentpassword.$seed))
{
	return false;	
}

// now we update the password in the database
$query = sprintf("update ... set ... = '%s' where ... = '%s'",
	mysql_escape_string(sha1($newpassword.$seed)), mysql_escape_string($username));

return mysql_query($query);
}

[Asbuster]

Thanks alot again.

Ive managed to get rid of that error. I did get a $end error because i removed that brace, but i figured i forgot a brace to close the function. Everything seems to be fine so ill start testing it now.