another mysql_fetch warning! PLEASE HELP!

tobymac

I don't know what the problem is or how to fix it, please explain in amaturish detail!

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in ... on line 39

<?php
// Connect to database
include_once "connect_to_mysql.php";
// DEAFAULT QUERY STRING
$queryString = "WHERE email_activated='1' ORDER BY id ASC";
// DEFAULT MESSAGE ON TOP OF RESULT DISPLAY
$queryMsg = "Showing Oldest to Newest members by Default";

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////// SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
if (($_POST['listByq'] == "newest_members")) {

$queryString = "WHERE email_activated='1' ORDER BY id DESC";
$queryMsg = "Showing Newest to Oldest Members";



} else if ($_POST['listByq'] == "by_firstname") {


$fname = $_POST['fname'];
$fname = stripslashes($fname); 
$fname = strip_tags($fname);
$fname = eregi_replace("`", "", $fname);
$fname = mysql_real_escape_string($fname);
$queryString = "WHERE firstname LIKE '%$fname%' AND email_activated='1'";
$queryMsg = "Showing Members with the name you searched for";

} 	
/////////////// END SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

//////////////  QUERY THE MEMBER DATA USING THE $queryString variable's value
$sql = mysql_query("SELECT id, firstname, lastname, country, website FROM myMembers $queryString"); 
//////////////////////////////////// Pagination Setup ////////////////////////////////////

// Build the Output Section Here
$outputList = '';
while($row = mysql_fetch_array($sql)){ 

$id = $row["id"];
$firstname = $row["firstname"];
$lastname = $row["lastname"];
$country = $row["country"];


///////  Mechanism to Display Pic. See if they have uploaded a pic or not  //////////////////////////
$check_pic = "../memberFiles/$id/pic01.jpg";
$default_pic = "../memberFiles/0/pic01.jpg";
if (file_exists($check_pic)) {
$user_pic = "<img src=\"$check_pic\" width=\"120px\" border=\"0\" />"; // forces picture to be 120px wide and no more
} else {
$user_pic = "<img src=\"$default_pic\" width=\"120px\"  border=\"0\" />"; // forces default picture to be 120px wide and no more
}
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

$outputList .= '
<table width="100%">
                  <tr>
                    <td width="23%" rowspan="3"><div style=" height:120px; overflow:hidden;"><a href="http://www.hcrindienetwork.com/free/member_profile.php?id=' . $id . '" target="_blank">' . $user_pic . '</a></div></td>
                    <td width="14%" class="style7"><div align="right">Name:</div></td>
                    <td width="63%"><a href="http://www.hcrindienetwork.com/free/member_profile.php?id=' . $id . '" target="_blank">' . $firstname . ' ' . $lastname . '</a> </td>
                  </tr>

              <tr>
                <td class="style7"><div align="right">Country:</div></td>
                <td>' . $country . ' </td>
              </tr>
              <tr>

              </table>
			  <hr />
';


} // close while //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////// END QUERY THE MEMBER DATA & Build the Output Section ////////////////////////////

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<meta name="Description" content="Member Browsing" />
<meta name="Keywords" content="" />
<meta name="rating" content="General" />
<meta name="ROBOTS" content="All" />
<title>Browse Members</title>
</head>

<body>
<table width="950" align="center">
  <tr>
    <td width="758" valign="top"><br />
      <table width="94%" align="center" cellpadding="6">
      <tr>
        <td bgcolor="#E9E9E9"><form id="form1" name="form1" method="post" action="member_search.php">
          Browse Newest Members 

        <input name="button" type="submit" id="button" value="Go" />
        <input type="hidden" name="listByq" value="newest_members" />


    <td bgcolor="#E9E9E9"><form id="form3" name="form3" method="post" action="member_search.php">
      Search By Name
            <input type="text" name="fname" id="fname" />

          <input name="button3" type="submit" id="button3" value="Go" />
      <input type="hidden" name="listByq" value="by_firstname" />
    </form></td>
  </tr>
</table>
  <br />

  <table width="70%" align="center" cellpadding="6">
    <tr>
      <td><?php print "$queryMsg"; ?><br /><br />
<?php print "$outputList"; ?></td>
        </tr>
      </table>
    <br />
    <br /></td>
  </tr>
</table>
</body>
</html>

johanafm

tobymac;10986577 wrote:
Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in ... on line 39

As documented by [man]mysql_fetch_array[/man], the first argument to this function has to be a result set resource, and as documented by [man]mysql_query[/man] this function returns a result set resource on success and false on failure. You obviously can't pass false to mysql_fetch_array which means that you first have to check if the query was successful or not.

tobymac;10986577 wrote:

else if ($_POST['listByq'] == "by_firstname")
{
	# why?
	$fname = stripslashes($fname); 
	# why?
    $fname = strip_tags($fname);
	# why?
	/* Also, all ereg functions are deprecated and should not be used.
	 * If you need regexp, you should use the preg family functions:
	 * http://www.php.net/manual/en/function.preg-replace.php
	 * But since you are replacing a fixed string you don't need regexp,
	 * and when regexp isn't needed you should always use an ordinary
	 * string function instead. In this case: str_replace()
	 * Also, you don't have to worry about case insensitivity since `
	 * can't be considered to be either upper or lower case.
	 */
	$fname = eregi_replace("`", "", $fname);

The reason I'm asking "why", is that it's not a good idea to accept input while silently modifying it to become something else.
What you should do is check if the input contains characters that aren't accepted and inform the user of this so that they may correct their input. They may not have simply inserted an extra character, but missed hitting the correct key so that the intended character was replaced by something else. Assuming you only allow characters a-z, then

$errors = array();

$pattern = '#[^a-zA-Z]#';
if (preg_match($pattern, $fname)
{
	$errors[] = 'First name can only contain letters a-z in upper or lower case';
}


# When all input validation has been done
if (count($errors) == 0)
{
	# all storage handling goes here...
}
else
{
	# display the form again, but first inform the user of all encountered errors
	foreach($errors as $e)
		echo '<div class="error">'.$e.'</div>';
}

tobymac;10986577 wrote:

$query = "SELECT id, firstname, lastname, country, website FROM myMembers $queryString";
$sql = mysql_query($query);

# At this point, $sql is either false or a result set resource
if (!$sql)
{
	# log the error so that you can check what went wrong
	error_log(mysql_error() . ' ('.mysql_errno().'): ' . $query);

# inform the user that there was a problem without giving them the specifics
$errors[] = 'Unable to retrieve information. Please try again later.';
}
else
{
	# in this block, $sql is certain to be a result set resource
	while($row = mysql_fetch_array($sql)){

anoopmail

do a

echo "SELECT id, firstname, lastname, country, website FROM myMembers $queryString" ;

and see what it comes. if u feel it is correct, try executing it on database using phpmyadmin and see what it says.

tobymac

Something isn't right, could you change the code i posted above and edit it for me to past into my file to try. Thanks!

anoopmail

take a backup of ur file then paste this piece.

// Connect to database
include_once "connect_to_mysql.php";
// DEAFAULT QUERY STRING
$queryString = "WHERE email_activated='1' ORDER BY id ASC";
// DEFAULT MESSAGE ON TOP OF RESULT DISPLAY
$queryMsg = "Showing Oldest to Newest members by Default";

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////// SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
if (($_POST['listByq'] == "newest_members")) {

$queryString = "WHERE email_activated='1' ORDER BY id DESC";
$queryMsg = "Showing Newest to Oldest Members";



} else if ($_POST['listByq'] == "by_firstname") {


$fname = $_POST['fname'];
$fname = stripslashes($fname);
$fname = strip_tags($fname);
$fname = eregi_replace("`", "", $fname);
$fname = mysql_real_escape_string($fname);
$queryString = "WHERE firstname LIKE '&#37;$fname%' AND email_activated='1'";
$queryMsg = "Showing Members with the name you searched for";

}     

/////////////// END SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

//////////////  QUERY THE MEMBER DATA USING THE $queryString variable's value
$sql = "SELECT id, firstname, lastname, country, website FROM myMembers $queryString" ;
echo $sql ;
$result = mysql_query($sql);
//////////////////////////////////// Pagination Setup ////////////////////////////////////

tobymac

Alright thanks, check this out, this is what it looks like. i forgot to close something, where and how do i fix this http://harborcityrecords.com/hcrindienetwork/free/member_search.php

anoopmail

Oops you miss the <?php ?> tags. Use this

<?php
// Connect to database
include_once "connect_to_mysql.php";
// DEAFAULT QUERY STRING
$queryString = "WHERE email_activated='1' ORDER BY id ASC";
// DEFAULT MESSAGE ON TOP OF RESULT DISPLAY
$queryMsg = "Showing Oldest to Newest members by Default";

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////// SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
if (($_POST['listByq'] == "newest_members")) {

$queryString = "WHERE email_activated='1' ORDER BY id DESC";
$queryMsg = "Showing Newest to Oldest Members";



} else if ($_POST['listByq'] == "by_firstname") {


$fname = $_POST['fname'];
$fname = stripslashes($fname);
$fname = strip_tags($fname);
$fname = eregi_replace("`", "", $fname);
$fname = mysql_real_escape_string($fname);
$queryString = "WHERE firstname LIKE '%$fname%' AND email_activated='1'";
$queryMsg = "Showing Members with the name you searched for";

}     

/////////////// END SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

//////////////  QUERY THE MEMBER DATA USING THE $queryString variable's value
$sql = "SELECT id, firstname, lastname, country, website FROM myMembers $queryString" ;
echo $sql ;
$result = mysql_query($sql);
//////////////////////////////////// Pagination Setup //////////////////////////////////// 
?>

tobymac

Check it out now http://harborcityrecords.com/hcrindienetwork/free/member_search.php this is messed up, i coppied the code you game me too!

tobymac

Here is the entire revised code

<php><?php
// Connect to database
include_once "connect_to_mysql.php";
// DEAFAULT QUERY STRING
$queryString = "WHERE email_activated='1' ORDER BY id ASC";
// DEFAULT MESSAGE ON TOP OF RESULT DISPLAY
$queryMsg = "Showing Oldest to Newest members by Default";

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////// SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
if (($_POST['listByq'] == "newest_members")) {

$queryString = "WHERE email_activated='1' ORDER BY id DESC";
$queryMsg = "Showing Newest to Oldest Members";

} else if ($_POST['listByq'] == "by_firstname") {

$fname = $_POST['fname'];
$fname = stripslashes($fname);
$fname = strip_tags($fname);
$fname = eregi_replace("`", "", $fname);
$fname = mysql_real_escape_string($fname);
$queryString = "WHERE firstname LIKE '&#37;$fname%' AND email_activated='1'";
$queryMsg = "Showing Members with the name you searched for";

}

/////////////// END SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

////////////// QUERY THE MEMBER DATA USING THE $queryString variable's value
$sql = "SELECT id, firstname, lastname, country, website FROM myMembers $queryString" ;
echo $sql ;
$result = mysql_query($sql);
//////////////////////////////////// Pagination Setup ////////////////////////////////////
?>

// Build the Output Section Here
$outputList = '';
while($row = mysql_fetch_array($sql)){

$id = $row["id"];
$firstname = $row["firstname"];
$lastname = $row["lastname"];
$country = $row["country"];


///////  Mechanism to Display Pic. See if they have uploaded a pic or not  //////////////////////////
$check_pic = "../memberFiles/$id/pic1.jpg";
$default_pic = "../memberFiles/0/pic1.jpg";
if (file_exists($check_pic)) {
$user_pic = "<img src=\"$check_pic\" width=\"120px\" border=\"0\" />"; // forces picture to be 120px wide and no more
} else {
$user_pic = "<img src=\"$default_pic\" width=\"120px\"  border=\"0\" />"; // forces default picture to be 120px wide and no more
}
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

$outputList .= '
<table width="100%">
<tr>
<td width="23%" rowspan="3"><div style=" height:120px; overflow:hidden;"><a href="http://www.hcrindienetwork.com/free/member_profile.php?id=' . $id . '" target="blank">' . $user_pic . '</a></div></td>
<td width="14%" class="style7"><div align="right">Name:</div></td>
<td width="63%"><a href="http://www.hcrindienetwork.com/free/member_profile.php?id=' . $id . '" target="blank">' . $firstname . ' ' . $lastname . '</a> </td>
</tr>

              <tr>
                <td class="style7"><div align="right">Country:</div></td>
                <td>' . $country . ' </td>
              </tr>
              <tr>

              </table>
			  <hr />

} // close while //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////// END QUERY THE MEMBER DATA & Build the Output Section ////////////////////////////

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<meta name="Description" content="Member Browsing" />
<meta name="Keywords" content="" />
<meta name="rating" content="General" />
<meta name="ROBOTS" content="All" />
<title>Browse Members</title>
</head>

<body>
<table width="950" align="center">
<tr>
<td width="758" valign="top"><br />
<table width="94%" align="center" cellpadding="6">
<tr>
<td bgcolor="#E9E9E9"><form id="form1" name="form1" method="post" action="member_search.php">
Browse Newest Members

        <input name="button" type="submit" id="button" value="Go" />
        <input type="hidden" name="listByq" value="newest_members" />


    <td bgcolor="#E9E9E9"><form id="form3" name="form3" method="post" action="member_search.php">
      Search By Name
            <input type="text" name="fname" id="fname" />

          <input name="button3" type="submit" id="button3" value="Go" />
      <input type="hidden" name="listByq" value="by_firstname" />
    </form></td>
  </tr>
</table>
  <br />

  <table width="70%" align="center" cellpadding="6">
    <tr>
      <td><?php print "$queryMsg"; ?><br /><br />

<?php print "$outputList"; ?></td>
</tr>
</table>
<br />
<br /></td>
</tr>
</table>
</body>
</html>
</php>

anoopmail

//////////////////////////////////// Pagination Setup ////////////////////////////////////
?>

remove the ?>

2) enclose any posting codes with php in square brackets

tobymac

okay, looking better. now check this out http://harborcityrecords.com/hcrindienetwork/free/member_search.php

anoopmail

SELECT id, username, country, WHERE email_activated='1' ORDER BY id ASC

additional comma after 'country' or u miss the 'website' column

tobymac

I got rid of all the "website" sources. i didn't need them. here is my revised code. i don't know what the issue is.

<?php
// Connect to database
include_once "connect_to_mysql.php";
// DEAFAULT QUERY STRING
$queryString = "WHERE email_activated='1' ORDER BY id ASC";
// DEFAULT MESSAGE ON TOP OF RESULT DISPLAY
$queryMsg = "Showing Oldest to Newest members by Default";

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////// SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
if (($_POST['listByq'] == "newest_members")) {

$queryString = "WHERE email_activated='1' ORDER BY id DESC";
$queryMsg = "Showing Newest to Oldest Members";



} else if ($_POST['listByq'] == "by_username") {


$fname = $_POST['fname'];
$fname = stripslashes($fname);
$fname = strip_tags($fname);
$fname = eregi_replace("`", "", $fname);
$fname = mysql_real_escape_string($fname);
$queryString = "WHERE username LIKE '&#37;$fname%' AND email_activated='1'";
$queryMsg = "Showing Members with the name you searched for";

}     

/////////////// END SET UP FOR SEARCH CRITERIA QUERY SWITCH MECHANISMS
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

//////////////  QUERY THE MEMBER DATA USING THE $queryString variable's value
$sql = "SELECT id, username, country, $queryString" ;
echo $sql ;
$result = mysql_query($sql);
//////////////////////////////////// Pagination Setup ////////////////////////////////////


// Build the Output Section Here
$outputList = '';
while($row = mysql_fetch_array($sql)){ 

$id = $row["id"];
$username = $row["username"];
$country = $row["country"];


///////  Mechanism to Display Pic. See if they have uploaded a pic or not  //////////////////////////
$check_pic = "../memberFiles/$id/pic1.jpg";
$default_pic = "../memberFiles/0/pic1.jpg";
if (file_exists($check_pic)) {
$user_pic = "<img src=\"$check_pic\" width=\"120px\" border=\"0\" />"; // forces picture to be 120px wide and no more
} else {
$user_pic = "<img src=\"$default_pic\" width=\"120px\"  border=\"0\" />"; // forces default picture to be 120px wide and no more
}
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

$outputList .= '
<table width="100%">
                  <tr>
                    <td width="23%" rowspan="3"><div style=" height:120px; overflow:hidden;"><a href="http://www.hcrindienetwork.com/free/member_profile.php?id=' . $id . '" target="_blank">' . $user_pic . '</a></div></td>
                    <td width="14%" class="style7"><div align="right">Name:</div></td>
                    <td width="63%"><a href="http://www.hcrindienetwork.com/free/member_profile.php?id=' . $id . '" target="_blank">' . $username . ' ' .  '</a> </td>
                  </tr>

              <tr>
                <td class="style7"><div align="right">Country:</div></td>
                <td>' . $country . ' </td>
              </tr>
              <tr>

              </table>
			  <hr />
';


} // close while //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////// END QUERY THE MEMBER DATA & Build the Output Section ////////////////////////////

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<meta name="Description" content="Member Browsing" />
<meta name="Keywords" content="" />
<meta name="rating" content="General" />
<meta name="ROBOTS" content="All" />
<title>Browse Bands</title>
</head>

<body>
<table width="950" align="center">
  <tr>
    <td width="758" valign="top"><br />
      <table width="94%" align="center" cellpadding="6">
      <tr>
        <td bgcolor="#E9E9E9"><form id="form1" name="form1" method="post" action="member_search.php">
          Browse Newest Members 

        <input name="button" type="submit" id="button" value="Go" />
        <input type="hidden" name="listByq" value="newest_members" />


    <td bgcolor="#E9E9E9"><form id="form3" name="form3" method="post" action="member_search.php">
      Search By Band Name
            <input type="text" name="fname" id="fname" />

          <input name="button3" type="submit" id="button3" value="Go" />
      <input type="hidden" name="listByq" value="by_username" />
    </form></td>
  </tr>
</table>
  <br />

  <table width="70%" align="center" cellpadding="6">
    <tr>
      <td><?php print "$queryMsg"; ?><br /><br />
<?php print "$outputList"; ?></td>
        </tr>
      </table>
    <br />
    <br /></td>
  </tr>
</table>
</body>
</html>
[code=php]

anoopmail

2) enclose any posting codes with php in square brackets

$sql = "SELECT id, username, country, $queryString" ;
echo $sql ;

$sql = "SELECT id, username, country $queryString" ;
echo $sql ;

tobymac

okay, i'm starting to see it more clearly now. i got rid of the extra "," now it is calling out the
$queryString = "WHERE email_activated='1' ORDER BY id DESC";

check it out on the live server.

http://www.hcrindienetwork.com/free/member_search.php

anoopmail

you miss ' FROM <tablename> '

tobymac

i did a search for "FROM" and nothing came up, where do i put the tablename?

anoopmail

your old code has correct query

$sql = "SELECT id, firstname, lastname, country, website FROM myMembers $queryString" ;

but new code has

$sql = "SELECT id, username, country, $queryString" ;

tobymac

ohhhh okay, so i fixed it so now it says

SELECT id, firstname, lastname, country FROM members WHERE email_activated='1' ORDER BY id ASC

still having issues though

anoopmail

now execute the printed query directly on db