Custom Theme System Problem

inulled

function theme_creation($stylesheet_uri) {
	$exc = array('stylesheet1.css', 'stlyesheet2.css');
	foreach($exc as $true) {
		if ($true == $exc) {
			include_once($stylesheet_uri);
		} elseif ($true != $exc) {
			echo "Failure";
		}
	}
}

theme_creation("stylesheet1.css");

What am I doing wrong here? It keeps outputting 'Failure'.

bradgrafelman

Your logic doesn't make any sense... you're comparing $true to $exc, but $true is defined in the foreach() structure as the variable used to contain each item in the array in the loop.

In other words, if $exec was the tuple (1,2,3), you're checking if 1 is equal to (1, 2, 3), and if 2 is equal to (1, 2, 3), and if 3 is equal to (1, 2, 3).

inulled

So what would be the solution?

bradgrafelman

I don't know. Your logic doesn't make sense, so I have no idea what you're actually trying to do, thus I have no idea how it should actually be written in code.

inulled

What it should do is when I call the inclusion method, it should loop through the array and check to see if what is being included matches what's in the array. If it doesn't match it will output 'Failure', if it does, it will proceed with the inclusion.

bradgrafelman

I still don't understand... as you loop through each entry in the array, you want to make sure that entry belongs in the array?

inulled

Yes sir. That is correct. And if the entry exists in the array execute: include_once($stylesheet_uri);

if it doesn't: display 'Failure'

It's a security precaution, as I'm developing a dynamic theming system, I don't want the third-party developer being able to access files within the core of my platform that they have no business accessing. This way it'll simply be limited to stylesheet1.css and stylesheet2.css. And then of course if they don't have those files created in there theme folder it will output error upon inclusion.

bradgrafelman

But that doesn't make any sense; the values you're getting are coming from the array.

Why not include a bunch of if() statements that check if 1+1 is 2 and 2+1 is 3 and 3+1 is...

inulled

Yeah that's a little simpler. Lol it didn't think about that.

inulled

function theme_creation($stylesheet_uri) {
		if ($stylesheet_uri == "stylesheet1.php") {
			include_once($stylesheet_uri);
		} elseif ($stylesheet_uri != "stylesheet1.php") {
			echo "Failure";
		}
	}
theme_creation("stylesheet1.php");

And it works, thanks man!

bradgrafelman

Now that I see what you're doing, also note that you could instead keep the array of known-good values and use something like [man]in_array/man to check if a value is contained inside that array.