Displaying User Account details

lordjordysmith

Hi all im new to here and was wondering if you could lend me a hand

i want to be able to display the details in the database for the user thats logged in unfortunately though its showing the whole table to everyone
heres my code

<?php
require('authenticate.php');
?>
<!-- Start get page name -->
<?
$currentFile = $_SERVER["PHP_SELF"];
$parts = Explode('/', $currentFile);
?>
<!-- End get page name -->
<!DOCTYPE HTML>
<html>
<head>
<title>My Account</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style type="text/css">
@import url("style.css");
</style>
</head>
<body class="about">
<!-- Start NavBar -->
<?php
require('topnavbar.php');
?>
<!-- End NavBar -->
<div id="page-container"> 

<div id="header"> 
</div> 

<div id="sidebar-a"></div> 

<div id="content"> 
<div class="padding">
<div id="user-details">
<?php 
 // Connects to your Database 
 mysql_connect("xxxx", "isn_1", "xxxx") or die(mysql_error()); 
 mysql_select_db("isn_1") or die(mysql_error()); 
 $data = mysql_query("SELECT * FROM authentication") 
 or die(mysql_error()); 
 Print "<table border cellpadding=3>"; 
 while($info = mysql_fetch_array( $data )) 
 { 
 Print "<tr>"; 
 Print "<th>Name:</th> <td>".$info['fname']['lname'] . "</td> "; 
 Print "<th>Username:</th> <td>".$info['username'] . " </td>";
 Print "<th>Year Group:</th> <td>".$info['yeargroup'] . "</td> "; 
 Print "<th>School:</th> <td>".$info['school'] . " </td></tr>"; 

 } 
 Print "</table>"; 
 ?> 
    </div>
      <p>&nbsp;</p>
	  <p>&nbsp;</p>
	</div> 
	</div> 

<div id="footer"> 
<div id="altnav"> 
	<a href="index.php">Home</a> - 
	<a href="login.php">Login</a> - 
	<a href="register.php">Register</a> - 
	<a href="about.php">About</a> -
    <a href="terms.php">Terms & Conditions</a>
</div> 
<div id="copyright">&copy; 2011 InterSchoolsNetwork, All Rights Reserved - A <a href="http://jordansmithsolutions.co.uk">Jordan Smith Solutions</a> &amp; <a href="http://www.joecocorp.webs.com/">JoeCo Corp Production</a><br /> 
</div> 
	</div> 
</div> 
</body>
</html>

the table name is authenticate

hope you guys can help

johanafm

SELECT * FROM authentication means everything in that table. WHERE somestuff = somevalue would limit it.

lordjordysmith

would that make the user whos logged in only be able to see there details?

johanafm

That would depend on what you put i the WHERE clause.

This would not

SELECT * FROM authentication WHERE signupdate < '2010'
[/cod]
would show, to all users regardless of who they are, the data for all users who signed up before 2010 (assuming there is a column called signupdate).

What you need to do depends on how you handle things. Assuming you store the user's id in a session variable
[code=php]
$query = 'SELECT stuff FROM authentication WHERE id='.$_SESSION['userid'];

lordjordysmith

right ok then so is the bit that says stuff the column name in the table for example fname?

and yes we do use a session id

i will try this in a bit and get back to you

thanks

lordjordysmith

right then i have tried that but now i get this on the page

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

here is the code now

<?php
require('authenticate.php');
?>
<!-- Start get page name -->
<?
$currentFile = $_SERVER["PHP_SELF"];
$parts = Explode('/', $currentFile);
?>
<!-- End get page name -->
<!DOCTYPE HTML>
<html>
<head>
<title>My Account</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style type="text/css">
@import url("style.css");
</style>
</head>
<body class="about">
<!-- Start NavBar -->
<?php
require('topnavbar.php');
?>
<!-- End NavBar -->
<div id="page-container"> 

<div id="header"> 
</div> 

<div id="sidebar-a"></div> 

<div id="content"> 
<div class="padding">
<div id="user-details">
<?php 
 // Connects to your Database 
 mysql_connect("interschoolsnetworkc.ipagemysql.com", "isn_1", "460980_jordy") or die(mysql_error()); 
 mysql_select_db("isn_1") or die(mysql_error()); 
 $data = mysql_query('SELECT * FROM authentication WHERE id='.$_SESSION['username'])
 or die(mysql_error()); 
 Print "<table border cellpadding=3>"; 
 while($info = mysql_fetch_array( $data )) 
 { 
 Print "<tr>"; 
 Print "<th>First Name:</th> <td>".$info['fname'] . "</td> "; 
 Print "<th>Last Name:</th> <td>".$info['lname'] . "</td> ";
 Print "<th>Username:</th> <td>".$info['username'] . " </td>";
 Print "<th>Year Group:</th> <td>".$info['yeargroup'] . "</td> "; 
 Print "<th>School:</th> <td>".$info['school'] . " </td></tr>"; 

 } 
 Print "</table>"; 
 ?> 
    </div>
      <p>&nbsp;</p>
	  <p>&nbsp;</p>
	</div> 
	</div> 

<div id="footer"> 
<div id="altnav"> 
	<a href="index.php">Home</a> - 
	<a href="login.php">Login</a> - 
	<a href="register.php">Register</a> - 
	<a href="about.php">About</a> -
    <a href="terms.php">Terms & Conditions</a>
</div> 
<div id="copyright">&copy; 2011 InterSchoolsNetwork, All Rights Reserved - A <a href="http://jordansmithsolutions.co.uk">Jordan Smith Solutions</a> &amp; <a href="http://www.joecocorp.webs.com/">JoeCo Corp Production</a><br /> 
</div> 
	</div> 
</div> 
</body>
</html>

johanafm

Well, you're supplying a string literal, the username, yet the string is not delimited by quotes.

Also, should you really be comparing id = username?

lordjordysmith

does that mean i need to make id username since the username is what is used to login

if so how do i go about this because i tried changing id to username and i just got a blank page

if you need some more information i will be more than happy to provide it

thanks

johanafm

lordjordysmith;10987102 wrote:
does that mean i need to make id username since the username is what is used to login

What's "used" to login doesn't matter. It's your system. You can pull anything you want from the db. You can store anything you like in $_SESSION (well, except for stuff that can't be stored there, such as resources but that's besides the point here).

lordjordysmith;10987102 wrote:
if so how do i go about this because i tried changing id to username and i just got a blank page

Well, you just can't change willy nilly between identifiers.

page 1

session_start();
$_SESSION['username'] = 'joe';

page 2

echo $_SESSION['userid'];

Without actually storing userid in $_SESSION, what would you expect happens in the second script?

lordjordysmith;10987102 wrote:
i just got a blank page

Change php.ini. error_reporting = -1 or E_ALL. display_errors = stdout in dev enrivonment. log_errors = /path/logfile in both prod, dev and test environments.

If you don't enable error reporting, you will get blank pages as soon as you have a parse error, not to mention missing lots of other things you really should be aware of.

Other than that, I never see you use session_start() or store anything in $SESSION. While some other script, that I don't see, may have stored things in $SESSION, you never use start_session() in this script.

forde52

johanafm;10987109 wrote:
Other than that, I never see you use session_start()

The session_start() is in the authenticate.php file that is required at the start of the page so the session is allways started due to that file.