[RESOLVED] Add a child to an imported nodelist

[scrupul0us]

Currently I'm taking the results of a xpath query and transferring the nodelist to a new xmldocument for output:

			$doc = new DOMDocument();
			$doc->loadxml($results);
			$xpath = new DOMXpath($doc);
			$xpathResults = $xpath->query("/results/result[contains(status,'$status')]");
			$nodes = $xpathResults->length;
			if($nodes > 0)
			{
				$newDom = new DOMDocument('1.0','UTF-8');
				$root = $newDom->createElement('results');
				$root = $newDom->appendChild($root);

			foreach ($xpathResults as $domElement)
			{
				$domNode = $newDom->importNode($domElement, true);
				$root->appendChild($domNode);
				$newResults = $newDom->saveXML();					
			}			
			header("Content-type: application/xml");
			echo $newResults;							
		}

I'm beating my head against the wall trying how to insert a single child after the root called count

<results>
<count>$nodes</count>
//imported node list here
<result>...</result>
//
</results>

no matter what I've toyed with I cannot get it to insert properly without destroying the element ordering and causing errors

[johanafm]

$doc = new DOMDocument();
$doc->loadxml($results);
$xpath = new DOMXpath($doc);
$xpathResults = $xpath->query("/results/result[contains(status,'$status')]");
$nodes = $xpathResults->length;
if($nodes > 0)
{
	$newDom = new DOMDocument('1.0','UTF-8');
	$root = $newDom->createElement('results');
	# assignment unnecessary. $root is allready <results>
	$newDom->appendChild($root);

# create count node, set nodeValue, root->appendChild.


foreach ($xpathResults as $domElement)
{
	$domNode = $newDom->importNode($domElement, true);
	$root->appendChild($domNode);
	# unnecessary to save everything on each iteration

}			
$newResults = $newDom->saveXML();
header("Content-type: application/xml");
echo $newResults;							
}

[scrupul0us]

see i tried that:

			$doc = new DOMDocument();
			$doc->loadxml($results);
			$xpath = new DOMXpath($doc);
			$xpathResults = $xpath->query("/results/result[contains(status,'$status')]");
			$nodes = $xpathResults->length;

		if($nodes > 0)
		{
			$newDom = new DOMDocument('1.0','UTF-8');
			$root = $newDom->createElement('results');
			$root = $newDom->appendChild($root); //IF THIS IS GONE I GET BLANK DOCUMENT
			$count = $newDom->createElement('count', $nodes);
			$root = $newDom->appendChild($count);
			foreach ($xpathResults as $domElement)
			{
				$domNode = $newDom->importNode($domElement, true);
				$root->appendChild($domNode);

			}
			$newResults = $newDom->saveXML();				
			header("Content-type: application/xml");
			echo $newResults;							
		}

that puts the count element OUTSIDE as the very root element... maybe i'm just scoping the place to inject it wrong?

[scrupul0us]

actually i got it:

changed this:

$root = $newDom->appendChild($count);

to:

$root->appendChild($count);

thanks for jogging my brain!

[johanafm]

johanafm;10987107 wrote:

	# assignment unnecessary. $root is allready <results>
	$newDom->appendChild($root);

Which is why I put that comment above $root = ...; You never need to reassign when modifying the tree. It obviously does no harm when it's the same node your modifying, but it's also completely unnecessary.

If you have a node and place it somewhere, whatever is needed for that node will be updated, such as parentnode, childnodes, siblings...

[scrupul0us]

I see what you mean now... Thank you again =)