User form failing miserably...Involves Basic Math

pseudocool

Basically this is a pretty straight forward application. The values are all best on a set of conditional statements held in a function and when the user presses submit, it SHOULD calculate the form....However, this is not the case, for some reason it keeps returning 0. I have tried and tried and tried....to no avail. I have attached the files so you can sort through a little easier as there are a good amount of lines.

Thanks!

EDIT: Here is the code.

index.php - HTML for the user form (not styled, just the framework)

<? require('functions.php'); ?>
<!DOCTYPE HTML>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>Untitled Document</title>
</head>

<body>
<form action="<?php $_SERVER['PHP_SELF']; ?>" method="post" name="ezShipForm">
  <!-- Begin Business & Contact Info --->
  <input name="company" type="text" placeholder="Company"><br>
  <input name="address" type="text" placeholder="Address"><br>
  <input name="city" type="text" placeholder="City"><br>
  <select name="state">
    <option value="0">State</option>
    <?php echo generateStateOptions($stateList); ?>
  </select><br>
  <input name="zipcode" type="text" placeholder="Zip Code"><br>
  <input name="contactPhone" type="text" placeholder="Contact Phone"><br>
  <input name="contactFax" type="text" placeholder="Contact Fax"><br>
  <input name="contactName" type="text" placeholder="Contact Name"><br>
  <input name="contactEmail" type="text" placeholder="Contact E-mail"><br>
  <!-- End Business & Contact Info ---> 
  <!-- Begin Calculations --->
  <input name="fuelPrice" type="text" placeholder="Today's Fuel Rate">
  http://www.eia.gov/oog/info/wohdp/diesel.asp<br>
  <select name="trailerType">
    <option value="Flat Bed">Flatbed</option>
    <option value="Step Deck">Step Deck</option>
	<option value="Van">Van</option>
    <option value="Refer">Refer</option>
    <option value="RGN/Lo-Boy">RGN/Lo-Boy</option>
  </select>  <br>
  <input name="pickUpDate" type="text" placeholder="MM/DD/YYYY"><br>
  <input name="startingCity" type="text" placeholder="Starting City"><br>
  <select name="startingState">
    <option value="0">State</option>
    <?php echo generateStateOptions($stateList); ?>
  </select><br>
  <input name="destinationCity" type="text" placeholder="Destination City"><br>
  <select name="destinationState">
    <option value="0">State</option>
    <?php echo generateStateOptions($stateList); ?>
  </select><br>
  <input name="loadedMiles" type="text" placeholder="Loaded Miles">http://www.truckmiles.com/<br>
  <select name="loadType">
    <option value="Full">Full</option>
    <option value="Partial">Partial</option>
  </select><br>
  <select name="loadSize">
    <option value="Yes">Oversized</option>
    <option value="No">Not Oversized</option>
  </select><br>
  <input name="loadLength" type="text" placeholder="Load Length">Ex: 120in = 10ft<br>
  <input name="loadWeight" type="text" placeholder="Weight">Ex: 10500lbs = 10.5<br>
  <input name="loadWidth" type="text" placeholder="Load Width">in inches<br>
  <input name="loadHeight" type="text" placeholder="Load Height">in inches<br>
  <select name="tarped">
    <option value="Yes">Yes</option>
    <option value="No">No</option>
  </select><br>
  <select name="twicCardReq">
    <option value="Yes">Yes</option>
    <option value="No">No</option>
  </select><br>
  <input name="permits" type="text" value="0">If yes, How many states?<br>
  <input name="pilotCars" type="text" value="0">If yes, How many?<br>
  <input name="loadDescription" type="text" placeholder="Brief Load or Product Description"><br>
  <input name="comments" type="text" placeholder="Other Comments"><br>
  <input name="total" type="text"><br>
  <input name="submit" type="submit" value="Submit"> 
  <input name="overWidth102" type="hidden">
  <input name="overWidth120" type="hidden">
  <input name="overWidth144" type="hidden">
  <input name="overWidth168" type="hidden">
  <input name="overLength52" type="hidden">
  <input name="overLength56" type="hidden">
  <input name="overLength58" type="hidden">
  <input name="overLength60" type="hidden">
  <input name="overLength62" type="hidden">

</form>
<?php 
	if (isset($_POST['submit']))
	{
		//Call the 'performCalculation' Function To Get Total Coat
		performCalculation();
	}
?>
</body>
</html>

functions.php

<?php
function performCalculation()
{
//Declare User Form Variables
	$company = $_POST['company']; 
	$address = $_POST['address']; 
	$city = $_POST['city']; 
	$state = $_POST['state']; 
	$zipcode = $_POST['zipcode']; 
	$contactPhone = $_POST['contactPhone']; 
	$contactFax = $_POST['contactFax']; 
	$contactName = $_POST['contactName']; 
	$contactEmail = $_POST['contactEmail']; 
	$fuelPrice = $_POST['fuelPrice']; 
	$trailerType = $_POST['trailerType']; 
	$pickUpDate = $_POST['pickUpDate']; 
	$startingCity = $_POST['startingCity']; 
	$startingState = $_POST['startingState']; 
	$destinationCity = $_POST['destinationCity']; 
	$destinationState = $_POST['destinationState']; 
	$loadedMiles = $_POST['loadedMiles']; 
	$loadType = $_POST['loadType']; 
	$loadSize = $_POST['loadSize']; 
	$loadLength = $_POST['loadLength']; 
	$loadWeight = $_POST['loadWeight']; 
	$loadWidth = $_POST['loadWidth']; 
	$loadHeight = $_POST['loadHeight']; 
	$tarped = $_POST['tarped']; 
	$twicCardReq = $_POST['twicCardReq']; 
	$permits = $_POST['permits']; 
	$pilotCars = $_POST['pilotCars']; 
	$loadDescription = $_POST['loadDescription']; 
	$comments = $_POST['comments']; 
	$overWidth102 = $_POST['overWidth102']; 
	$overWidth120 = $_POST['overWidth120']; 
	$overWidth144 = $_POST['overWidth144']; 
	$overWidth168 = $_POST['overWidth168']; 
	$overLength52 = $_POST['overLength52']; 
	$overLength56 = $_POST['overLength56']; 
	$overLength58 = $_POST['overLength58']; 
	$overLength60 = $_POST['overLength60']; 
	$overLength62 = $_POST['overLength62']; 
	$total = $_POST['total'];

//Declare Calculation Variables
	$mainRate = ($fuelPrice * 0.166 + 1.06) * 1.25;
	$mileRate = $loadedMiles * $mainRate;
	$permitRate = $permits * 50;
	$pilotCarRate = ($pilotCars * 1.25 * $loadedMiles);
	$flatBedRate = $subTotal;
	$overSizeRate = $overWidth102 + $overWidth120 + $overWidth144 + 
					$overWidth168 + $overLength52 + $overLength56 + 
					$overLength58 + $overLength60 + $overLength62;


//Surcharge Calculation
	if ($loadedMiles < 500) { 
		$surcharge = (500 - $loadedMiles) * .25 * $mainRate;
	}

//Load Rate Calculation
	if ($loadLength > $loadWeight) {	
		$loadRate = $loadLength * $loadedMiles * ($mainRate / 34);
	} else {
		$loadRate = $loadWeight * $loadedMiles * ($mainRate / 34);
	}

//Tarped Rate Calculation
	if ($tarped == "Yes") {
		$tarpRate = 100;
	} else {
		$tarpRate = 0;
	}

//Sub Total Calculation
	if ($loadSize == "Full") {
		$subTotal = $loadedmiles + $surcharge + $tarpRate + $permitRate + $pilotCarRate; 
	} else {
		$subTotal = $surcharge + $loadRate + $tarpRate + $permitRate;
	}

//Step Deck Rate Calculation
	if ($trailerType == "Step Deck") {
		$trailerRate = $subTotal * .02;	
	} 

//Van Rate Calculation
	if ($trailerType == "Van") {
		$trailerRate = $subTotal * .02;	
	}

//Refer Rate Calculation
	if ($trailerType == "Refer") {
		$trailerRate = $subTotal * .04;	
	}

//RGN/Lo-Boy Rate Calculation
	if ($trailerType == "RGN/Lo-Boy") {
		$trailerRate = $subTotal * .10;	
	}

//Over Width Rate Calculations
	if ($loadWidth > 102) {
		$overWidthRate = $loadedMiles * .2;
	}
	if ($loadWidth > 120) {
		$overWidthRate = $loadedMiles * .1;
	}
	if ($loadWidth > 144) {
		$overWidthRate = $loadedMiles * .1;
	}
	if ($loadWidth > 168) {
		$overWidthRate = $loadedMiles * .1;
	}

//Over Length Rate Calculations
	if ($loadLength > 52) {
		$overWidthRate = $loadedMiles * .14;
	}
	if ($loadLength > 56) {
		$overWidthRate = $loadedMiles * .07;
	}
	if ($loadLength > 58) {
		$overWidthRate = $loadedMiles * .07;
	}
	if ($loadLength > 60) {
		$overWidthRate = $loadedMiles * .07;
	}
	if ($loadLength > 62) {
		$overWidthRate = $loadedMiles * .07;
	}

//	Total Rate Calculation
	if ($loadedMiles !== 0) {
		$total = $trailerRate + $overSizeRate;
		echo $total;
	} else {
		$total = 0;
	}


}



//Generate List of States 
	$stateList = array ('alabama'=>"AL",
	'Alaska'=>"AK",
	'Arizona'=>"AZ",
	'Arkansas'=>"AR",
	'California'=>"CA",
	'Colorado'=>"CO",
	'Connecticut'=>"CT",
	'Delaware'=>"DE",
	'District Of Columbia'=>"DC",
	'Florida'=>"FL",
	'Georgia'=>"GA",
	'Hawaii'=>"HI",
	'Idaho'=>"ID",
	'Illinois'=>"IL",
	'Indiana'=>"IN",
	'Iowa'=>"IA",
	'Kansas'=>"KS",
	'Kentucky'=>"KY",
	'Louisiana'=>"LA",
	'Maine'=>"ME",
	'Maryland'=>"MD",
	'Massachusetts'=>"MA",
	'Michigan'=>"MI",
	'Minnesota'=>"MN",
	'Mississippi'=>"MS",
	'Missouri'=>"MO",
	'Montana'=>"MT",
	'Nebraska'=>"NE",
	'Nevada'=>"NV",
	'New Hampshire'=>"NH",
	'New Jersey'=>"NJ",
	'New Mexico'=>"NM",
	'New York'=>"NY",
	'North Carolina'=>"NC",
	'North Dakota'=>"ND",
	'Ohio'=>"OH",
	'Oklahoma'=>"OK",
	'Oregon'=>"OR",
	'Pennsylvania'=>"PA",
	'Rhode Island'=>"RI",
	'South Carolina'=>"SC",
	'South Dakota'=>"SD",
	'Tennessee'=>"TN",
	'Texas'=>"TX",
	'Utah'=>"UT",
	'Vermont'=>"VT",
	'Virginia'=>"VA",
	'Washington'=>"WA",
	'West Virginia'=>"WV",
	'Wisconsin'=>"WI",
	'Wyoming'=>"WY");

//Generate State Options for User Forms
	function generateStateOptions($array)
	{
		$string = '';
		foreach($array as $k => $v)
	{
		$string .= '<option value="'.$k.'"'.$s.'>'.$v.'</option>'."\n";
	}
		return $string;
	}


//End of file
?>

traq

you mean [font="monospace"]$total[/font] is coming out to zero?

is the [font="monospace"]if()[/font] or the [font="monospace"]else[/font] causing this?

do some testing, print out the values as you compute them, and find out where things go wrong.

pseudocool

Well i figured out through some asking around and reading that 'function()' has a specific scope, and unless you pass variables to return the values, you are computing nothing.

Example:

$var_one = 10;
$var_two = 20;

// wrong way
function MULTIPLY() {
	$result = ($var_one * $var_two );
	return $result;
}
echo MULTIPLY();  // Produces 'Undefined Variable' notices. Variable values are not available within the function.

// right way
function MULTIPLY_PROPERLY( $first_argument, $second_argument ) {
	$result = ( $first_argument * $second_argument );
	return $result;
}

The only problem is, I don't know enough to put this into practice in regards to my form. I need help getting the if statements to produce values to use within the function and then return the $total to the user form, via an echo statement or what have you.

johanafm

# (most likely) global scope.
$var_one = 10;
$var_two = 20;

# The "inside" of a function has its own scope. That is, anything NOT defined inside
# that function, or passed in as function arguments, is outside of its scope and not
# reachable.
function MULTIPLY()
{
	$result = ($var_one * $var_two );
	return $result;
}
echo MULTIPLY();  // Produces 'Undefined Variable' notices.
# Variable values are indeed avilable within the function, as long as they are within
# scope, which the two used here are not.

# Function arguments are within the function's scope, so these can be used
function MULTIPLY_PROPERLY( $first_argument, $second_argument ) {
	$result = ( $first_argument * $second_argument );
	return $result;
}

pseudocool;10987442 wrote:
The only problem is, I don't know enough to put this into practice in regards to my form.

The way you'd use the second function is...

$product = MULTIPLY_PROPERLY($var_one, $var_two);

Since you are then using $var_one and $var_two, in the same scope they were defined, as arguments in the call to multiply_properly, inside which their values are now available in the funcion local variables $first_argument and $second_argument.

pseudocool

Okay. I understand how that works, but, can you look at the original post where my code is...All of the variables are in the function, then I have a series of if statements to calculate the data, but non of it is returning a value.

Would you mind looking at the original code for me and telling me what i should do to make it work?

bradgrafelman

traq already offered the most basic (and yet often most helpful) debugging technique:

traq;10987281 wrote:
do some testing, print out the values as you compute them, and find out where things go wrong.

pseudocool

bradgrafelman;10987486 wrote:
traq already offered the most basic (and yet often most helpful) debugging technique:

yes...i dont know how to....my knowledge on php is extremely basic...i am just learning on my own...

i will try to read debugging 101 in your signature

bradgrafelman

Simply [man]echo[/man] (or for more verbose output, use [man]var_dump/man) at various places inside the function to check values as you compute them (or in the case of if() statements, output the variables used in the condition so that you can see why the if() condition was or was not taken).

pseudocool

Okay, so i debugged a little and I think it has to do with the fact that $total relies on vars from the if statements...maybe i am wrong but does the scope of the IF potentially have something to do with it? The if statements return values properly, the $total is just not handling the values properly.

Also, I removed the function portion and put the code into the "isset submit" portion to make debugging easier...

if ($trailerType == "Refer") {
	$trailerRate = $subTotal * .04;	
}

$total = ceil($trailerRate + $overSizeRate); // $trailerRate is from an IF however $overSizeRate I believe is of the "global" scope...
print_r ($total); // Returns 0

bradgrafelman

pseudocool;10987497 wrote:
does the scope of the IF potentially have something to do with it?

No, since if() statements have no scope themselves.

pseudocool;10987497 wrote:
The if statements return values properly

Impossible, considering if() statements don't return anything at all.

pseudocool;10987497 wrote:
the $total is just not handling the values properly.

What do you mean "handling the values properly" ? It's going to "handle" whatever values you give it. If you give it meaningless or nonexistant values, then you can expect a meaningless or nonexistant result.

Hence why it's been suggested a couple times now that you start looking at the values of all of the intermediate variables before you ever get to $total.

pseudocool;10987497 wrote:
I removed the function portion and put the code into the "isset submit" portion to make debugging easier...

Er, okay... but how does changing the entire structure of the same code make that code any easier to debug? (Hint: It doesn't. 😉)

pseudocool

You misunderstood what i was trying to say...probably because I don;t have as many years of experience as you do.

I used "print_r" on every intermediate variable. I got a proper response from each, only the value of $total is null...which is why i brought it back around to $total.

I am confused as F***...

bradgrafelman

What does your code look like now?

pseudocool

Don't be too harsh...I may have done something wrong i have no idea...

Do i need to use "return" so i can use the values to calculate the total?

<?php 
	if (isset($_POST['submit']))
	{
	//Declare User Form Variables
	$fuelPrice = $_POST['fuelPrice']; 
	$trailerType = $_POST['trailerType']; 
	$pickUpDate = $_POST['pickUpDate']; 
	$startingCity = $_POST['startingCity']; 
	$startingState = $_POST['startingState']; 
	$destinationCity = $_POST['destinationCity']; 
	$destinationState = $_POST['destinationState']; 
	$loadedMiles = $_POST['loadedMiles']; 
	$loadType = $_POST['loadType']; 
	$loadSize = $_POST['loadSize']; 
	$loadLength = $_POST['loadLength']; 
	$loadWeight = $_POST['loadWeight']; 
	$loadWidth = $_POST['loadWidth']; 
	$loadHeight = $_POST['loadHeight']; 
	$tarped = $_POST['tarped']; 
	$twicCardReq = $_POST['twicCardReq']; 
	$permits = $_POST['permits']; 
	$pilotCars = $_POST['pilotCars']; 
	$overWidth102 = $_POST['overWidth102']; 
	$overWidth120 = $_POST['overWidth120']; 
	$overWidth144 = $_POST['overWidth144']; 
	$overWidth168 = $_POST['overWidth168']; 
	$overLength52 = $_POST['overLength52']; 
	$overLength56 = $_POST['overLength56']; 
	$overLength58 = $_POST['overLength58']; 
	$overLength60 = $_POST['overLength60']; 
	$overLength62 = $_POST['overLength62']; 

//Declare Calculation Variables
	$mainRate = ($fuelPrice * 0.166 + 1.06) * 1.25; 
	$mileRate = $loadedMiles * $mainRate;
	$permitRate = $permits * 50;
	$pilotCarRate = ($pilotCars * 1.25 * $loadedMiles);
	$flatBedRate = $subTotal;
	$overSizeRate = $overWidth102 + $overWidth120 + $overWidth144 + 
					$overWidth168 + $overLength52 + $overLength56 + 
					$overLength58 + $overLength60 + $overLength62;


//Surcharge Calculation
	if ($loadedMiles < 500) { 
		$surcharge = (500 - $loadedMiles) * .25 * $mainRate;
		print_r ($surcharge);
		echo "<br>";
	}

//Load Rate Calculation
	if ($loadLength > $loadWeight) {	
		$loadRate = $loadLength * $loadedMiles * ($mainRate / 34);
		print_r ($loadRate);
		echo "<br>";
	} else {
		$loadRate = $loadWeight * $loadedMiles * ($mainRate / 34);
		print_r ($loadRate);
		echo "<br>";
	}

//Tarped Rate Calculation
	if ($tarped == "Yes") {
		$tarpRate = 100;
		print_r ($tarpRate);
		echo "<br>";
	} else {
		$tarpRate = 0;
	}

//Sub Total Calculation
	if ($loadSize == "Full") {
		$subTotal = $loadedMiles + $surcharge + $tarpRate + $permitRate + $pilotCarRate; 
		print_r ($subTotal);
		echo "<br>";
	} else {
		$subTotal = $surcharge + $loadRate + $tarpRate + $permitRate;
		print_r ($subTotal);
		echo "<br>";
	}

//Step Deck Rate Calculation
	if ($trailerType == "Step Deck") {
		$trailerRate = $subTotal * .02;	
		print_r ($trailerRate);
		echo "<br>";
	} 

//Van Rate Calculation
	if ($trailerType == "Van") {
		$trailerRate = $subTotal * .02;
		print_r ($trailerRate);
		echo "<br>";
	}

//Refer Rate Calculation
	if ($trailerType == "Refer") {
		$trailerRate = $subTotal * .04;	
		print_r ($trailerRate);
		echo "<br>";
	}

//RGN/Lo-Boy Rate Calculation
	if ($trailerType == "RGN/Lo-Boy") {
		$trailerRate = $subTotal * .10;	
		print_r ($trailerRate);
		echo "<br>";
	}

//Over Width Rate Calculations
	if ($loadWidth > 102) {
		$overWidthRate = $loadedMiles * .2;
		print_r ($overWidthRate);
		echo "<br>";
	}
	if ($loadWidth > 120) {
		$overWidthRate = $loadedMiles * .1;
		print_r ($overWidthRate);
		echo "<br>";
	}
	if ($loadWidth > 144) {
		$overWidthRate = $loadedMiles * .1;
		print_r ($overWidthRate);
		echo "<br>";
	}
	if ($loadWidth > 168) {
		$overWidthRate = $loadedMiles * .1;
		print_r ($overWidthRate);
		echo "<br>";
	}

//Over Length Rate Calculations
	if ($loadLength > 52) {
		$overLengthRate = $loadedMiles * .14;
		print_r ($overLengthRate);
		echo "<br>";
	}
	if ($loadLength > 56) {
		$overLengthRate = $loadedMiles * .07;
		print_r ($overLengthRate);
		echo "<br>";
	}
	if ($loadLength > 58) {
		$overLengthRate = $loadedMiles * .07;
		print_r ($overLengthRate);
		echo "<br>";
	}
	if ($loadLength > 60) {
		$overLengthRate = $loadedMiles * .07;
		print_r ($overLengthRate);
		echo "<br>";
	}
	if ($loadLength > 62) {
		$overLengthRate = $loadedMiles * .07;
		print_r ($overLengthRate);
		echo "<br>";
	}

//	Total Rate Calculation
		$total = ceil($trailerRate + $overSizeRate);
		print_r ($total);

}
?>

bradgrafelman

I try never to be harsh, but "bluntly and thoroughly obvious" might seep through now and again. 😉

For one, change print_r() to [man]var_dump/man (which gives a bit more verbose output). Second, just before you calculate $total at the end, do a var_dump() on both $trailerRate and $overSizeRate - can you show us the output?

Also, do you have display_errors set to On and error_reporting set to E_ALL? (Do a quick [man]phpinfo/man if you aren't sure.)

pseudocool

Well I think we found a problem...but now i am not sure why.

var_dump ($trailerRate);        //  Returns    NULL 
var_dump ($overSizeRate);       //  Returns    int(0)

bradgrafelman;10987508 wrote:
Also, do you have display_errors set to On and error_reporting set to E_ALL?

I checked and yes, both are set correctly.

traq

can you show us the output of all your [font="monospace"]var_dump()[/font] calls?

what are the initial $POST values for these? Apparently, they're all empty (0), since you don't do anything but add them together to get your $overSizeRate.

$overWidth102 = $_POST['overWidth102']; 
    $overWidth120 = $_POST['overWidth120']; 
    $overWidth144 = $_POST['overWidth144']; 
    $overWidth168 = $_POST['overWidth168']; 
    $overLength52 = $_POST['overLength52']; 
    $overLength56 = $_POST['overLength56']; 
    $overLength58 = $_POST['overLength58']; 
    $overLength60 = $_POST['overLength60']; 
    $overLength62 = $_POST['overLength62'];

pseudocool

Well, I added a value to $overSizeRate just for temp purposes just above the $total calculation...

so the last few lines look like:

if ($loadedMiles !== "" || $loadedMiles !== 0) {
		$overSizeRate = 20;
		$total = $trailerRate + $overSizeRate;
		echo $total;
	} else {
		$total = 0;
	}

traq

that just "hotwires" it, it doesn't actually fix or troubleshoot anything. Are you sure your form is submitting the values properly? For testing, you could give each item a set value - then you would know if your math and php logic is sound, and you could compare your result with a known expected result.

going back to your first post, most (maybe all, not sure) of those "overWidth" and "overLength" fields are hidden inputs with names, but no values. If that's the case, they may as well not exist. You should check your other inputs for similar problems.

try adding / comments / after each variable to remind yourself what sort a value you expect from each input. you could also add a check to make sure each field (if required) has a value - you might be multiplying by zero at some point, which would make you end up with nothing.