[RESOLVED] Help with onClick function[SQL query]

soder0

Hello, I recently started to learn PHP and databases and are working on a school project.

Everything is working great so far, except the part of code where I click the link, the "clicks"(click counter) in database doesnt update the "clicks" part of the table bookmarks with +1 number.
(Everytime I click the link the "133 clicks" should be +1(134 clicks))

And yes, I know it's a messy code 😛

while($row = mysql_fetch_array($result)){
  echo "<center><table width=\"300\" height=\"30\" border =\"1\"><tr>";
  echo "<td width=\"300\">";
  echo "<a href=\"http://$row[link]\" onClick=\"mysql_query(\"UPDATE bookmarks SET clicks = clicks+1 where id = '$row[id]'\");\" target=\"_blank\">$row[name]</a>$row[clicks]<td><a href=\"delete_link.php?name=$row[name]\" alt=\"Delete\" onclick=\"return confirm('Are you sure want to remove $row[name] from your list?');\"><img name =\"Delete\" src=\"/pictures/delete.gif\"></a></td></tr><br /></table></center>";
  }

onClick=\"mysql_query(\"UPDATE bookmarks SET clicks = clicks+1 where id = '$row[id]'\");\"

Thanks in advance,
Regards,
Soder.

soder0

I could not edit my post, so if I was abit unclear it should be like the "views" counter on a forum post.

Regards,
Soder.

Derokorian

You are trying to run a php function client side. This is not possible. Instead of trying to use onclick in this fashion you could instead update the views/clicks on the page the link leads to itself. The fact of the matter is onClick is going to try to execute as a client side function, however mysql_query is NOT a recognized client side command.

soder0

Oh, now I understand why I never manage to make it work, so basically what I need to do is create a new page to add +1 to the click counter and then redirect(spelling) away to the page they are suppose to land on?

Regards,
Soder.

Derokorian

if its an outside page I guess yes you would have to do that. However you could simply add the +1 on the page itself. Here is a function that's called on every page I have, hope it helps:

function counter($db) {
    $page = $db->real_escape_string($_SERVER['REQUEST_URI']);
    $sql = sprintf("SELECT `views` FROM `pageviews` WHERE `uri`='%s'",$page);
    if( !($result = $db->query($sql)) ) trigger_error('Invalid query',E_USER_ERROR);
    if( !$result->num_rows > 0 ) {
        $sql = sprintf("INSERT INTO `pageviews` SET `uri`='%s', `views`='1'",$page);
    } else {
        $row = $result->fetch_assoc();
        $views = $row['views'];
        $sql = sprintf("UPDATE `pageviews` SET `views`=%d WHERE `uri`='%s'",$views,$page);
    }
    if( !$db->query($sql) ) trigger_error('Failed to update page view',E_USER_NOTICE);
}

soder0

Thank you alot, got it working!

Regards,
Soder.