[RESOLVED] substr problem

Square1

Hi all:

I have a public form where people can enter an address. I am able to properly Upper Case and Lower Case the form as needed with the following exception if the street address ends in se, sw, ne, or nw ("123 main st se" for example). By uppercasing first letters of the other words I got it to Se, Sw, Ne, Nw. Here is my code that isn't working:

		switch (substr($Mc_Adjust, -3, 3)){
			case " Nw":
				str_replace(" Nw", " NW", $Mc_Adjust);
				break;
			case " Sw":
				str_replace(" Sw", " SW", $Mc_Adjust);
				break;				
			case " Ne":
				str_replace(" Ne", " NE", $Mc_Adjust);
				break;				
			case " Se":
				str_replace(" Se", " SE", $Mc_Adjust);
				break;				
				}

Any help is appreciated!

bradgrafelman

Your code isn't working because it doesn't try to do anything, really. [man]str_replace/man returns the resulting string, yet you never store that new value anywhere (e.g. by overwriting the previous value with it).

Square1

Here is more of the code:

$pLocationAddress 	= mcAdjust($_POST["locationAddress"]);

bradgrafelman

That has nothing to do with the error I noted above.

This:

        switch (substr($Mc_Adjust, -3, 3)){ 
            case " Nw": 
                str_replace(" Nw", " NW", $Mc_Adjust); 
                break; 
            case " Sw": 
                str_replace(" Sw", " SW", $Mc_Adjust); 
                break;                 

            case " Ne": 
                str_replace(" Ne", " NE", $Mc_Adjust); 
                break;                 

            case " Se": 
                str_replace(" Se", " SE", $Mc_Adjust); 
                break;                 

                }

might as well be this:

        switch (substr($Mc_Adjust, -3, 3)){ 
            case " Nw": 
                break; 
            case " Sw": 
                break;                 

            case " Ne": 
                break;                 

            case " Se": 
                break;                 

                }

since statements like this:

str_replace(" Nw", " NW", $Mc_Adjust);

don't actually do anything (well, it does something, but the returned value isn't captured and thus the net result is nothing will change).

Derokorian

What he's saying is, this:

                str_replace(" Nw", " NW", $Mc_Adjust);

Needs to change to this:

                $Mc_adjust = str_replace(" Nw", " NW", $Mc_Adjust);

Square1

Derokorian;10987478 wrote:

What he's saying is, this:

                str_replace(" Nw", " NW", $Mc_Adjust);

Needs to change to this:

                $Mc_adjust = str_replace(" Nw", " NW", $Mc_Adjust);

LOL! Thank you!