[RESOLVED] Not sure why DB won't update...

herb191

Why does the seconded query not update the DB?

$dbc = mysqli_connect('localhost', 'user_name', 'pass', 'urls')
	or die('error conecting to MySQL server.');

$my_ip  = $_SERVER['REMOTE_ADDR']; 

if ( $my_ip == "127.0.0.1" ) { 

$query = "SELECT * FROM `address` WHERE `used`='n' LIMIT 1";

  $result = mysqli_query($dbc, $query)
    or die('Error querying database.');

  while ($row = mysqli_fetch_array($result)){
    $urls = $row['url_address'];
echo '<a href="'.$urls .'">the_link.</a><br />';
  } 

$query =  "UPDATE `urls`.`address` SET `used` = 'y' WHERE `address`.`url_address` ='.$urls.'";
//echo $query;
 mysqli_query($dbc, $query)
    or die('Error querying database.');

} 
mysqli_close($dbc)

bradgrafelman

You've got periods on either side of the URL, so it's unlikely that WHERE condition will match any rows.

Also, if you're only expecting one result, why use a while() loop at all? Doesn't make much sense to loop exactly 0 or 1 times (since that's not really much of a "loop").

gawdsed

try this

$query = "UPDATE urls.address SET used = 'y' WHERE address.url_address ='{.$urls.}'";

also database field names usually don't need single quotes around them, only string(varchar) values if I remember correctly.

$query = "UPDATE urls.address SET used = 'y' WHERE address.url_address ='{.$urls.}'";

if that still doesn't work, you can try some debug measures and print out the query, example

echo $query;

or if you are wanting to echo in HTML

<?=$query;?>

Good luck 🙂

gawdsed

forgot to mention, after you echo the query, try to execute the query with either phpmyadmin or navicat

bradgrafelman

gawdsed;10987503 wrote:
try this

$query = "UPDATE urls.address SET used = 'y' WHERE address.url_address ='{.$urls.}'";

Now there are braces and periods on either side of the value of $urls in the SQL query.

gawdsed;10987503 wrote:
also database field names usually don't need single quotes around them, only string(varchar) values if I remember correctly.

While VARCHAR is only one of many column types that take on string values, you're correct in that single quotes should only be used to delimit strings.

However, the OP didn't use single quotes around DB field names/identifiers, so I'm not entirely sure how any of this is relevant?

herb191

Thanks guys i got it working. 🙂