if statement

[thewomb]

hi there.

can someone explain why this does not work?

$Q10= 'g', $Q11= 'a' echos '2' works!
$Q10= 'g', $Q11= 'b' echoes '1' not working! should also echo '2'

perhaps my code is not well written?

<?
// Q10 

  if ($Q10 == 'a' && $Q11 == 'a' || $Q11 == 'b') {
echo '1';	
} elseif ($Q10 == 'a' && $Q11 == 'c' || $Q11 == 'd') {
	echo '1b';	
} elseif ($Q10 == 'e' || $Q10 == 'f' || $Q10 == 'g' && $Q11 == 'a' || $Q11 == 'b') {
	echo '2';	
} elseif ($Q10 == 'e' || $Q10 == 'f' || $Q10 == 'g' && $Q11 == 'c' || $Q11 == 'd') {
		echo '2b';	
} elseif ($Q10 == 'b' || $Q10 == 'c' || $Q10 == 'd' && $Q11 == 'a' || $Q11 == 'b') {
		echo '3a';	
} else {	
	echo '3b';	
}

?>

[traq]

your very first condition instructs the script to echo "1" if $Q11 holds the value "b". Your script is working perfectly.

[thewomb]

ah ok! I think i may be missing some kind of parenthesis in my statements

that not what I'm trying to do. ;-(

what im trying to do is this.

<?
if ($Q10 == 'a' && $Q11 == 'a') { // both have to be true
    echo '1';    

}
elseif ($Q10 == 'a' && $Q11 == 'b') { // both have to be true
    echo '1';    

}
elseif ($Q10 == 'a' && $Q11 == 'c'){ // both have to be true
    echo '1b';     

}
elseif ($Q10 == 'a' && $Q11 == 'd') { // both have to be true
    echo '1b';     

}
elseif ($Q10 == 'e' & $Q11 == 'a') { // both have to be true
    echo '2'; 
}
elseif ($Q10 == 'f' && $Q11 == 'a') { // both have to be true
    echo '2';     

}
elseif ($Q10 == 'g' && $Q11 == 'a') { // both have to be true
    echo '2';     

} etc....

// BUT using the code below to make it less code.

<? 
      if ($Q10 == 'a' && $Q11 == 'a' || $Q11 == 'b') { 
    echo '1';    

} elseif ($Q10 == 'a' && $Q11 == 'c' || $Q11 == 'd') { 
    echo '1b';     

} elseif ($Q10 == 'e' || $Q10 == 'f' || $Q10 == 'g' && $Q11 == 'a' || $Q11 == 'b') { 
    echo '2';     

} elseif ($Q10 == 'e' || $Q10 == 'f' || $Q10 == 'g' && $Q11 == 'c' || $Q11 == 'd') { 
        echo '2b';     

} elseif ($Q10 == 'b' || $Q10 == 'c' || $Q10 == 'd' && $Q11 == 'a' || $Q11 == 'b') { 
        echo '3a';     

} else {     

    echo '3b';     

} 

?>

[bradgrafelman]

Your problem has to do with operator precedence (see: [man]operators.precedence[/man]).

These two statements:

a && b || c

vs.

a && (b || c)

are not identical. The first will evaluate to true if (a is true and b is true), or if c is true. However, the second is true if a is true and (b or c is true).

Use parenthesis to group the logical statements. This avoids problems with operator precedence.

[thewomb]

gort it working.. i think.

<?

// My child has never had alcohol to my knowledge
if (($Q10 == 'a' && $Q11 == 'a') || ($Q10 == 'a' && $Q11 == 'b')) {
	echo '1 You said that your child has never consumed alcohol, <b>but you are not sure of this</b>. This is the safest option for your child. Continue to encourage your child not to drink, until they are at least 18 years old.';	
} 
elseif (($Q10 == 'a' && $Q11 == 'c') || ($Q10 == 'a' && $Q11 == 'd')) {
	echo '1b You said that your child has never consumed alcohol. This is the safest option for your child. Continue to encourage your child not to drink, until they are at least 18 years old.';
} 
elseif (($Q10 == 'e' && $Q11 == 'a') || ($Q10 == 'e' && $Q11 == 'b') || ($Q10 == 'f' && $Q11 == 'a') || ($Q10 == 'f' && $Q11 == 'b') || ($Q10 == 'g' && $Q11 == 'a') || ($Q10 == 'g' && $Q11 == 'b')) {		
//} elseif ($Q10 == 'e' || $Q10 == 'f' || $Q10 == 'g' && $Q11 == 'a' || $Q11 == 'b') {
	echo '2 You said your child started drinking alcohol when they were '.$Q11.' <b>but you are not sure of this</b>. Research shows that children who begin drinking alcohol at this age are at higher risk of developing alcohol problems later in life. Later on we will suggest some things you can do to reduce your child’s risk of developing alcohol problems. ';	
} 
elseif (($Q10 == 'e' && $Q11 == 'c') || ($Q10 == 'e' && $Q11 == 'd') || ($Q10 == 'f' && $Q11 == 'c') || ($Q10 == 'f' && $Q11 == 'd') || ($Q10 == 'g' && $Q11 == 'c') || ($Q10 == 'g' && $Q11 == 'd')) {		
//elseif ($Q10 == 'e' || $Q10 == 'f' || $Q10 == 'g' && $Q11 == 'c' || $Q11 == 'd') {
		echo '2b You said your child started drinking alcohol when they were '.$Q11.' Research shows that children who begin drinking alcohol at this age are at higher risk of developing alcohol problems later in life. Later on we will suggest some things you can do to reduce your child’s risk of developing alcohol problems.';	
} 
elseif (($Q10 == 'b' && $Q11 == 'a') || ($Q10 == 'b' && $Q11 == 'b') || ($Q10 == 'c' && $Q11 == 'a') || ($Q10 == 'c' && $Q11 == 'b') || ($Q10 == 'e' && $Q11 == 'a') || ($Q10 == 'e' && $Q11 == 'b')) {		
//elseif ($Q10 == 'b' || $Q10 == 'c' || $Q10 == 'd' && $Q11 == 'a' || $Q11 == 'b') {
		echo '3 You said that your child started drinking alcohol when they were '.$Q11.' <b>but you are not sure of this</b>. Research shows that children who begin drinking alcohol at this age are at a much higher risk of developing alcohol problems later in life. Later on we will suggest some things you can do to reduce your child’s risk of developing alcohol problems. ';	
} 
else {	
	echo '3b You said that your child started drinking alcohol when they were '.$Q11.' Research shows that children who begin drinking alcohol at this age are at a much higher risk of developing alcohol problems later in life. Later on we will suggest some things you can do to reduce your child’s risk of developing alcohol problems.';	
}
?>