variable variables in a loop

elemelas

hi guys, could anyone tell me how can I make that code neater and shorter - in the loop:

$tier1 = $_POST['tier1'];
$tier2 = $_POST['tier2'];
$tier3 = $_POST['tier3'];
$tier4 = $_POST['tier4'];

echo("
<li>Tier 1: $tier1</li>
<li>Tier 2: $tier2</li>
<li>Tier 3: $tier3</li>
<li>Tier 4: $tier4</li>
");

I tried this way:

$tiers = 4;
$tier1 = $_POST['tier1'];
$tier2 = $_POST['tier2'];
$tier3 = $_POST['tier3'];
$tier4 = $_POST['tier4'];

for($id = 1; $id <= $tiers; $id++) {

echo("<li>Tier $id: "); echo "{$tier[$id]}" ; echo("</li>");

}

but it doesn't work, it gives me:

Tier 1:
Notice: Undefined variable: tier in C:\Localhost\(...)
Tier 2:
Notice: Undefined variable: tier in C:\Localhost\(...)
Tier 3:
Notice: Undefined variable: tier in C:\Localhost\(...)
Tier 4:
Notice: Undefined variable: tier in C:\Localhost\(...)

Any suggestions will be greatly appreciated

awbrowni30

Try this...

<?PHP

$tier = array();
$tier[] = $_POST['tier1'];
$tier[] = $_POST['tier2'];
$tier[] = $_POST['tier3'];
$tier[] = $_POST['tier4'];

echo '<ul>';

$i = 1;
foreach($tier as $key=>$val){

echo '<li>Tier $i: $val</li>';

$i++;

}

echo '</ul>';

?>

elemelas

thx, I had to do a small change to your code:

echo '<li>Tier $i: $val</li>';

to that:

echo ("<li>Tier $i: $val</li>");

and it works. however, that code is even longer than mine, so it's not really beneficial ...

awbrowni30

Back to the drawing board for shorter code... try this...

$tiers = 4;
@$tier1 = $_POST['tier1'];
@$tier2 = $_POST['tier2'];
@$tier3 = $_POST['tier3'];
@$tier4 = $_POST['tier4'];

for($id = 1; $id <= $tiers; $id++) {

echo("<li>Tier $id: "); echo "{$tier[$id]}" ; echo("</li>");

}

jeepin81

this will also work:

echo "<ul>";
for($i=1;$i<5;$i++){
	echo "<li>Tier".$i." ".$_POST['tier'.$i]."</li>";	
}
echo "</ul>";

bradgrafelman

An even better solution, IMHO, would be to get rid of the numbered variables altogether. If you use field names such as "tier[]" rather than numbers, PHP will automatically combine them into an array - $_POST['tier'].

That way, you'd simply do a [man]foreach[/man] loop over the $_POST['tier'] array to process each item that was submitted.