[RESOLVED] Deleting a record

cybastud

Hi, Im having trouble deleting a record from my database, below is my code...any assistance will be much appreciated...

<html>
<head>

<title>Welcom to Carsales Warehouse</title>
</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">Delete Vehicle</h2>

<p align="center">Are you sure you want to delete this vehicle?</p>



<form Method="POST" ACTION="delete.php">

<div align="center">
<input type="submit" value="Yes" name="delete">
<input type="submit" value="No" name="no">
</div>

</form>

<?php
include ('connect.php');//Includes database connection details
error_reporting(0);
$_SESSION['username'] = "$username";

$Delete = $_POST['delete'];
$car_id= $_GET['car_id'];

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'";
$result = mysql_query($query);

while($row = mysql_fetch_array($result)){
	$manufacturer = $row['manufacturer'];
	$make = $row['make'];
    $year = $row['year'];
    $price = $row['price'];

}

if (isset($_POST['delete'])) {
		$car_id = $_POST["car_id"];

	$sql = "DELETE FROM cars WHERE car_id = '$car_id'";
	$result = mysql_query($sql);

		if($result){
		echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>";
		}
	}

if (isset($_POST['no'])) {
	header("location: list.php");
	}
?>


</body>
</html>

awbrowni30

Try this...


<html> 
<head> 

<title>Welcom to Carsales Warehouse</title> 
</head> 

<body  bgcolor="black"    style="color:white;"> 

<h2 align="center">Delete Vehicle</h2> 

<p align="center">Are you sure you want to delete this vehicle?</p> 



<form Method="POST" ACTION="delete.php"> 

<div align="center"> 
<input type="submit" value="Yes" name="delete"> 
<input type="submit" value="No" name="no" onClick="parent.location='list.php'"> 

</div> 

</form> 

<?php 
include ('connect.php');//Includes database connection details 
error_reporting(0); 
$_SESSION['username'] = "$username"; 

$delete = $_POST['delete']; 
$car_id= $_GET['car_id']; 

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'"; 
$result = mysql_query($query) or die(mysql_error()); 

while($row = mysql_fetch_array($result)){ 
    $manufacturer = $row['manufacturer']; 
    $make = $row['make']; 
    $year = $row['year']; 
    $price = $row['price']; 

} 

if (isset($_POST['delete']) == "Yes") { 
        //$car_id = $_POST["car_id"]; 

    $sql = "DELETE FROM cars WHERE car_id = '$car_id'"; 
    $result = mysql_query($sql) or die(mysql_error()); 

        if($result){ 
        echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>"; 
        } 
    } 

?> 


</body> 
</html>

cybastud

I tried the above code but does not seem to work. It does now however print out the echo but also does not print the variable, its just prints "The vehicle , , , with a price of R has been deleted!". Its still does not delete the record...any suggestions?

awbrowni30

Try this... forget to replace $GET['car_id'] with $POST['car_id'];


<html>
<head>

<title>Welcom to Carsales Warehouse</title>
</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">Delete Vehicle</h2>

<p align="center">Are you sure you want to delete this vehicle?</p>



<form Method="POST" ACTION="delete.php">

<div align="center">
<input type="submit" value="Yes" name="delete">
<input type="submit" value="No" name="no" onClick="parent.location='list.php'">

</div>

</form>

<?php
include ('connect.php');//Includes database connection details
error_reporting(0);
$_SESSION['username'] = "$username";

$delete = $_POST['delete'];
$car_id= $_POST['car_id'];

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'";
$result = mysql_query($query) or die(mysql_error());

while($row = mysql_fetch_array($result)){
    $manufacturer = $row['manufacturer'];
    $make = $row['make'];
    $year = $row['year'];
    $price = $row['price'];

}

if (isset($_POST['delete']) == "Yes") {
        //$car_id = $_POST["car_id"];


if(!empty($car_id)){  

        $sql = "DELETE FROM cars WHERE car_id = '$car_id'";
        $result = mysql_query($sql) or die(mysql_error());

        if($result){
        echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>";
        }
} else {

echo '<p align="center">Your car id variable was not posted.</p>';
}
        }

?>


</body>
</html>

cybastud

now its just printing "Your car id variable was not posted." ??

awbrowni30

I added the logic in to show you that you are not passing the car_id variable on your form. So to remedy this, you need to add a hidden field with the name car_id and the car_id value....

<html>
<head>

<title>Welcom to Carsales Warehouse</title>
</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">Delete Vehicle</h2>

<p align="center">Are you sure you want to delete this vehicle?</p>

 <? 

// replace with the real car id value
$id = 'car_id_value';

?>
<form Method="POST" ACTION="delete.php">

<div align="center">
<input type="hidden" value="<? echo $id; ?>" name="car_id">
    <input type="submit" value="Yes" name="delete">
    <input type="submit" value="No" name="no" onClick="parent.location='list.php'">

</div>

</form>

<?php
include ('connect.php');//Includes database connection details
error_reporting(0);
$_SESSION['username'] = "$username";

$delete = $_POST['delete'];
$car_id= $_POST['car_id'];

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'";
$result = mysql_query($query) or die(mysql_error());

while($row = mysql_fetch_array($result)){
    $manufacturer = $row['manufacturer'];
    $make = $row['make'];
    $year = $row['year'];
    $price = $row['price'];

}

if (isset($_POST['delete']) == "Yes") {
        //$car_id = $_POST["car_id"];


if(!empty($car_id)){  

        $sql = "DELETE FROM cars WHERE car_id = '$car_id'";
        $result = mysql_query($sql) or die(mysql_error());

        if($result){
        echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>";
        } else {
echo '<p align="center">Your car id variable posted: '.$car_id.', but was not deleted.</p>';

}

} else {

echo '<p align="center">Your car id variable was not posted.</p>';
}
        }

?>


</body>
</html>

cybastud

Have a look at my list page..

<html>
<head>
<title>Welcom to Carsales Warehouse</title>

</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">List</h2>


<form Method="POST" ACTION="edit.php?car_id=$car_id">

<?php
include ('connect.php');//Includes database connection details
error_reporting(0);

session_start();
$_SESSION['username'] = "$username";

echo "<table border='1' align='center'>
	<tr bgcolor='#cccccc'>
	<td>Manufacturer</td>
	<td>Make</td>
	<td>Year</td>
	<td>Price</td>
	<td colspan='2'>Action</td>
	</tr>";

$SQL = "Select * FROM cars";
$result = mysql_query($SQL);

while($row = mysql_fetch_array($result)){ 
	$car_id=$row['car_id']; 
	echo "<tr><td>"; 
	echo $row['manufacturer']; 
	echo "</td><td>"; 
	echo $row['make']; 
	echo "</td><td>"; 
	echo $row['year']; 
	echo "</td><td>"; 
	echo $row['price']; 
	echo "</td><td>";
	echo "<a href=edit.php?car_id=$car_id&update=yes>Edit</a>"; 
	echo "</td><td>";

echo "<a href=delete.php?car_id=$car_id&delete=yes>Delete</a>";
echo "</tr>";
}

echo "</table>"; //end the table outside the loop

?>
</form>
</body>
</html>

So shouldn't I catch the car_id with $car_id= $_GET['car_id']; before I run the query?

awbrowni30


<html> 
<head> 
<title>Welcom to Carsales Warehouse</title> 

</head> 

<body  bgcolor="black"    style="color:white;"> 

<h2 align="center">List</h2> 

<? $car_id= $_REQUEST['car_id']; ?>
    <form Method="POST" ACTION="edit.php?car_id=$car_id"> 

<?php 
include ('connect.php');//Includes database connection details 
error_reporting(0); 

session_start(); 
$_SESSION['username'] = "$username"; 

echo "<table border='1' align='center'> 
    <tr bgcolor='#cccccc'> 
    <td>Manufacturer</td> 
    <td>Make</td> 
    <td>Year</td> 
    <td>Price</td> 
    <td colspan='2'>Action</td> 
    </tr>"; 

$SQL = "Select * FROM cars"; 
$result = mysql_query($SQL); 

while($row = mysql_fetch_array($result)){ 
    $car_id=$row['car_id']; 
    echo "<tr><td>"; 
    echo $row['manufacturer']; 
    echo "</td><td>"; 
    echo $row['make']; 
    echo "</td><td>"; 
    echo $row['year']; 
    echo "</td><td>"; 
    echo $row['price']; 
    echo "</td><td>"; 
    echo "<a href=edit.php?car_id=$car_id&update=yes>Edit</a>"; 
    echo "</td><td>"; 

echo "<a href=delete.php?car_id=$car_id&delete=yes>Delete</a>"; 
echo "</tr>"; 
} 

echo "</table>"; //end the table outside the loop 

?> 
</form> 
</body> 
</html>

cybastud

ok so here is my list page now...

<html>
<head>
<title>Welcom to Carsales Warehouse</title>

</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">List</h2>

<? $car_id= $_REQUEST['car_id']; ?>
    <form Method="POST" ACTION="edit.php?car_id=$car_id">

<?php
include ('connect.php');//Includes database connection details
error_reporting(0);

session_start();
$_SESSION['username'] = "$username";

echo "<table border='1' align='center'>
	<tr bgcolor='#cccccc'>
	<td>Manufacturer</td>
	<td>Make</td>
	<td>Year</td>
	<td>Price</td>
	<td colspan='2'>Action</td>
	</tr>";

$SQL = "Select * FROM cars";
$result = mysql_query($SQL);

while($row = mysql_fetch_array($result)){ 
	$car_id=$row['car_id']; 
	echo "<tr><td>"; 
	echo $row['manufacturer']; 
	echo "</td><td>"; 
	echo $row['make']; 
	echo "</td><td>"; 
	echo $row['year']; 
	echo "</td><td>"; 
	echo $row['price']; 
	echo "</td><td>";
	echo "<a href=edit.php?car_id=$car_id&update=yes>Edit</a>"; 
	echo "</td><td>";

echo "<a href=delete.php?car_id=$car_id&delete=yes>Delete</a>";
echo "</tr>";
}

echo "</table>"; //end the table outside the loop

?>
</form>
</body>
</html>

and then my delete page

<html>
<head>

<title>Welcom to Carsales Warehouse</title>
</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">Delete Vehicle</h2>

<p align="center">Are you sure you want to delete this vehicle?</p>

 <?

// replace with the real car id value
$id = 'car_id_value';

?>
<form Method="POST" ACTION="delete.php">

<div align="center">
<input type="hidden" value="<? echo $id; ?>" name="car_id">
    <input type="submit" value="Yes" name="delete">
    <input type="submit" value="No" name="no" onClick="parent.location='list.php'">

</div>

</form>

<?php
include ('connect.php');//Includes database connection details
error_reporting(0);
$_SESSION['username'] = "$username";

$delete = $_POST['delete'];
$car_id= $_POST['car_id'];

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'";
$result = mysql_query($query) or die(mysql_error());

while($row = mysql_fetch_array($result)){
    $manufacturer = $row['manufacturer'];
    $make = $row['make'];
    $year = $row['year'];
    $price = $row['price'];

}

if (isset($_POST['delete']) == "Yes") {
        //$car_id = $_POST["car_id"];


if(!empty($car_id)){  

        $sql = "DELETE FROM cars WHERE car_id = '$car_id'";
        $result = mysql_query($sql) or die(mysql_error());

        if($result){
        echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>";
        } else {
echo '<p align="center">Your car id variable posted: '.$car_id.', but was not deleted.</p>';

}

} else {

echo '<p align="center">Your car id variable was not posted.</p>';
}
        }

?>


</body>
</html>

At the moment if I run it like this, it prints "The vehicle , , , with a price of R has been deleted!" but does not actually delete the record. Also why does it not print the variables, like manufacturer, make, year and price?

cybastud

Also when I click the "no" button, it does not take me to the list.php page, its just does nothing

awbrowni30

This should be your delete page.


<html> 
<head> 

<title>Welcom to Carsales Warehouse</title> 
</head> 

<body  bgcolor="black"    style="color:white;"> 

<h2 align="center">Delete Vehicle</h2> 

<p align="center">Are you sure you want to delete this vehicle?</p> 

 <? 

// $_GET['car_id'] or $_REQUEST['car_id']
$id = $_REQUEST['car_id']; 

?> 
<form Method="POST" ACTION="delete.php"> 

<div align="center"> 
<input type="hidden" value="<? echo $id; ?>" name="car_id"> 
    <input type="submit" value="Yes" name="delete"> 
    <input type="submit" value="No" name="no" onClick="parent.location='list.php'"> 

</div> 

</form> 

<?php 
include ('connect.php');//Includes database connection details 
error_reporting(0); 
$_SESSION['username'] = "$username"; 

$delete = $_POST['delete']; 
$car_id= $_POST['car_id']; 

echo '<pre>'; 
echo print_r($_POST); 
echo '</pre>'; 


$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'"; 
$result = mysql_query($query) or die(mysql_error()); 

while($row = mysql_fetch_array($result)){ 
    $manufacturer = $row['manufacturer']; 
    $make = $row['make']; 
    $year = $row['year']; 
    $price = $row['price']; 

} 

if (isset($_POST['delete']) == "Yes") { 
        //$car_id = $_POST["car_id"]; 


if(!empty($car_id)){   

        $sql = "DELETE FROM cars WHERE car_id = '$car_id'"; 
        $result = mysql_query($sql) or die(mysql_error()); 

        if($result){ 
        echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>"; 
        } else { 
echo '<p align="center">Your car id variable posted: '.$car_id.', but was not deleted.</p>'; 

} 

} else { 

echo '<p align="center">Your car id variable was not posted.</p>'; 
} 
        } 

?> 


</body> 
</html>

awbrowni30

Also, it is a good idea to use print_r or var_dump when trying to see whether or not your variables are being captured upon submitting.

Example:

<?

// print_r($_POST), print_r($_REQUEST) or print_r($_GET);
// when you click the delete key, and echo print_r($_POST) and this will show you what variables are being passed

echo '<pre>';
echo print_r($_POST);
echo '</pre>';

?>

cybastud

ok this is my delete page now and its working!

<html>
<head>

<title>Welcom to Carsales Warehouse</title>
</head>

<body  bgcolor="black"    style="color:white;">

<h2 align="center">Delete Vehicle</h2>

<p align="center">Are you sure you want to delete this vehicle?</p>
<?php
include ('connect.php');//Includes database connection details
error_reporting(0);
$_SESSION['username'] = "$username";

$delete = $_POST['delete'];
$car_id= $_GET['car_id'];

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'";
$result = mysql_query($query) or die(mysql_error());

while($row = mysql_fetch_array($result)){
    $manufacturer = $row['manufacturer'];
    $make = $row['make'];
    $year = $row['year'];
    $price = $row['price'];

}
?>

<form Method="POST" ACTION="delete.php">

<div align="center">
<input type="hidden" name="car_id" value="<?php echo "$car_id"; ?>">
<input type="submit" value="Yes" name="delete">
<input type="submit" value="No" name="no" onClick="parent.location='list.php'">

</div>

</form>

<?php


if (isset($_POST['delete']) == "Yes") {
        $car_id = $_POST["car_id"];

    $sql = "DELETE FROM cars WHERE car_id = '$car_id'";
    $result = mysql_query($sql) or die(mysql_error());

        if($result){
        echo "<p align = 'center'>The vehicle $manufacturer, $make, $year, with a price of R$price has been deleted!</p>";
        } 

}

?>


</body>
</html>

The only problem Im having now is, when a record is deleted its just prints "The vehicle , , , with a price of R has been deleted!". How do I get it to print those variables?

awbrowni30


<html> 
<head> 

<title>Welcom to Carsales Warehouse</title> 
</head> 

<body  bgcolor="black"    style="color:white;"> 

<h2 align="center">Delete Vehicle</h2> 

<p align="center">Are you sure you want to delete this vehicle?</p> 
<?php 
include ('connect.php');//Includes database connection details 
error_reporting(0); 
$_SESSION['username'] = "$username"; 

$delete = $_POST['delete']; 
$car_id= $_GET['car_id']; 

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'"; 
$result = mysql_query($query) or die(mysql_error()); 

/*               

    while($row = mysql_fetch_array($result)){ 
        $manufacturer = $row['manufacturer']; 
        $make = $row['make']; 
        $year = $row['year']; 
        $price = $row['price']; 

} 

*/

$row = mysql_fetch_array($result);

// are you car attribute variables printing????
echo '<pre>'; 
echo print_r($row); 
echo '</pre>'; 



?> 

<form Method="POST" ACTION="delete.php"> 

<div align="center"> 
<input type="hidden" name="car_id" value="<?php echo "$car_id"; ?>"> 
<input type="submit" value="Yes" name="delete"> 
<input type="submit" value="No" name="no" onClick="parent.location='list.php'"> 

</div> 

</form> 

<?php 


if (isset($_POST['delete']) == "Yes") { 
        $car_id = $_POST["car_id"]; 

    $sql = "DELETE FROM cars WHERE car_id = '$car_id'"; 
    $result = mysql_query($sql) or die(mysql_error()); 

        if($result){ 
        echo "<p align = 'center'>The vehicle $row[0], $row[1], $row[2], with a price of R$row[3] has been deleted!</p>"; 
        } 

} 

?> 


</body> 
</html>

cybastud

Yes the car attribute variables are printing but if I use your code it still prints "The vehicle , , , with a price of R has been deleted!". But this time it does not delete the record

awbrowni30


<html> 
<head> 

<title>Welcom to Carsales Warehouse</title> 
</head> 

<body  bgcolor="black"    style="color:white;"> 

<h2 align="center">Delete Vehicle</h2> 

<p align="center">Are you sure you want to delete this vehicle?</p> 
<?php 
include ('connect.php');//Includes database connection details 
error_reporting(0); 
$_SESSION['username'] = "$username"; 

$delete = $_POST['delete']; 
$car_id= $_GET['car_id']; 

?> 

<form Method="POST" ACTION="delete.php"> 

<div align="center"> 
<input type="hidden" name="car_id" value="<?php echo "$car_id"; ?>"> 
<input type="submit" value="Yes" name="delete"> 
<input type="submit" value="No" name="no" onClick="parent.location='list.php'"> 

</div> 

</form> 

<?php 


if (isset($_POST['delete']) == "Yes") { 
        $car_id = $_POST["car_id"]; 

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'"; 
$resultZ = mysql_query($query) or die(mysql_error()); 
    $row = mysql_fetch_array($resultZ); 

/*

// are you car attribute variables printing???? 
echo '<pre>'; 
echo print_r($row); 
echo '</pre>'; 

*/ 

    $sql = "DELETE FROM cars WHERE car_id = '$car_id'"; 
    $result = mysql_query($sql) or die(mysql_error()); 

        if($result){ 
        echo "<p align = 'center'>The vehicle $row[0], $row[1], $row[2], with a price of R$row[3] has been deleted!</p>";
        } 

} 

?> 


</body> 
</html>

cybastud

It works, thanks so much for all the help

awbrowni30

No worries... I actually could have answered in less posts; however, I think it was beneficial for you to correct each issue along the way. You could also try this...


<?php echo "<?xml version=\"1.0\" encoding=\"iso-8859-1\"?".">"; ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>

<body>


<html> 
<head> 
<title>Welcome to Carsales Warehouse</title> 

</head> 

<body  bgcolor="black"    style="color:white;"> 

<h2 align="center">List</h2> 

<? 

include ('connect.php');//Includes database connection details 
error_reporting(0); 

session_start(); 
$_SESSION['username'] = "$username"; 

$car_id= $_REQUEST['car_id']; 

$getaction = $_REQUEST['action']; 

switch($getaction){

case 'update':

echo 'add edit code here';

break;

case 'delete':

$query = "SELECT manufacturer, make, year, price FROM cars WHERE car_id = '$car_id'"; 
$resultZ = mysql_query($query) or die(mysql_error()); 
    $row = mysql_fetch_array($resultZ); 

/* 

// are you car attribute variables printing???? 
echo '<pre>'; 
echo print_r($row); 
echo '</pre>'; 

*/            

        $sql = "DELETE FROM cars WHERE car_id = '$car_id'"; 
        $result = mysql_query($sql) or die(mysql_error()); 

        if($result){ 
        echo "<p align = 'center'>The vehicle $row[0], $row[1], $row[2], with a price of R$row[3] has been deleted!</p><input type='button' value='Go Back To List' name='no' onClick=\"parent.location='list.php'\">"; 
        } 


break

default:

?> 
    <form Method="POST" ACTION=""> 

<?php 

echo "<table border='1' align='center'> 
    <tr bgcolor='#cccccc'> 
    <td>Manufacturer</td> 
    <td>Make</td> 
    <td>Year</td> 
    <td>Price</td> 
    <td colspan='2'>Action</td> 
    </tr>"; 

$SQL = "Select * FROM cars"; 
$result = mysql_query($SQL); 

while($row = mysql_fetch_array($result)){ 
    $car_id=$row['car_id']; 
    echo "<tr><td>"; 
    echo $row['manufacturer']; 
    echo "</td><td>"; 
    echo $row['make']; 
    echo "</td><td>"; 
    echo $row['year']; 
    echo "</td><td>"; 
    echo $row['price']; 
    echo "</td><td>"; 
    echo "<input type='button' name='edit' value='Edit' onClick=\"parent.location='edit.php?car_id=$car_id&action=update'\">"; 
    echo "</td><td>"; 

echo "<a href='edit.php?car_id=$car_id&action=delete'><input type='button' name='delete' value='Delete' onclick=\"return confirm('Are you sure you want to remove the following car id: $car_id?');\"></a>"; 
echo "</tr>"; 
} 

echo "</table>"; //end the table outside the loop 

?> 
</form> 
<? 
break;

} ?>
</body>
</html>

cybastud

yes thank you for that. Check my other thread

http://www.phpbuilder.com/board/showthread.php?t=10381414