Undefined index: title in

fatoosh

Notice: Undefined index: title in L:\CGI PHP\project\postarticle.php on line 38

Notice: Undefined index: body in L:\CGI PHP\project\postarticle.php on line 39
this error appears when I try to post as article , and still insert empty record t DB ...

<?php
session_start();
if (!($_SESSION['name']))
{
header("Location:plogin.php");
}?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN"
 "http://www.w3.org/TR/REC-html40/strict.dtd">

<html>

<head>
<title>Post Article</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"/>
<meta name="author" content="faten al saraj, Nicole Khoury" />
<meta name="keyword" content="yoga"/>
<meta name="description" content="yoga web site"/>
<link href="style.css" rel="stylesheet" type="text/css"/>
<link href="pstyle.css" type="text/css" rel="stylesheet">
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.2.6/jquery.js" type="text/javascript"></script>
<script type="text/javascript" src="button.js"></script>

</head>
<body>
<div id="logo">
		 <img src="image/banner2.jpg" alt="banner" />
</div>
<div id="homepage">
		 <a href="index.php" target="_blank" >Home</a>
</div>

<?php 
require_once('lib/config.php');
$blog = new Blog();
if (!empty($_GET['submit']))
	{
		$title= $_POST['title'];
		$body= $_POST['body'];
 		$blog->insertArticle($title,$body);
	}

?>
<div id="aroundform">
<?php print "Welcome ".ucfirst($_SESSION['name']).", You are logged in.";?>
<form>

<label for='title'>Title:</label>
<input type="text" size="90" name="title" id="title" /><br/><br/>
<label for="body">Article</label><br/>
<textarea rows="20" col="100" name="body" >Enter your text</textarea>
<input type="submit" name="submit" value="Post" />
</form>
</div><!-- close aroundform-->

</body>
</html>

function that insert to DB is :

function insertArticle ($title,$body)
  		{
			 $title=addslashes($title);
			 $body=addslashes($body);
			 $sql= "insert into article (title,body) values ('".$title."','".$body."')";
			 $result = mysql_query($sql) or die ("Error in sql query".$sql." : ".mysql_error());
  		 //print "title is ".$title." body is ".$body."\n";

		}

bradgrafelman

Your <form> element is missing the 'method' attribute.

Also, [man]addslashes/man is not appropriate for preparing data for a SQL query. Instead, you should be using a DBMS-specific escaping function such as [man]mysql_real_escape_string/man for string data.

johanafm

bradgrafelman;10988293 wrote:
Your <form> element is missing the 'method' attribute.

Which makes the form default to a GET request, as can be seen in the DTD for 4.01 or the current draft for the html 5 spec

4.01 DTD
<!ATTLIST FORM
method (GET|POST) GET -- HTTP method used to submit the form--

5 draft
The missing value default for these attributes is the GET state.

Which is why...

fatoosh;10988287 wrote:

<form>
	<input type="submit" name="submit" value="Post" />

fatoosh;10988287 wrote:

if (!empty($_GET['submit']))
	{
		$title= $_POST['title'];
		$body= $_POST['body'];

$_GET['submit'] is not empty now, while $POST's title and body are. Once you change to method="post", $GET[™submit'] will instead be empty (but since you use empty() to check, there will be no error message.

fatoosh

I added the method , now no errors just it doesn't post anything into my DB ,,
before it added empty record now nothing , I even tried to print just text for debugging , didn't work ...

<?php
session_start();
if (!($_SESSION['name']))
{
header("Location:plogin.php");
}?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN"
 "http://www.w3.org/TR/REC-html40/strict.dtd">

<html>

<head>
<title>Post Article</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"/>
<meta name="author" content="faten al saraj, Nicole Khoury" />
<meta name="keyword" content="yoga"/>
<meta name="description" content="yoga web site"/>
<link href="style.css" rel="stylesheet" type="text/css"/>
<link href="pstyle.css" type="text/css" rel="stylesheet">
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.2.6/jquery.js" type="text/javascript"></script>
<script type="text/javascript" src="button.js"></script>

</head>
<body>
<div id="logo">
		 <img src="image/banner2.jpg" alt="banner" />
</div>
<div id="homepage">
		 <a href="index.php" target="_blank" >Home</a>
</div>

<?php 
require_once('lib/config.php');
$blog = new Blog();
if (!empty($_GET['submit']))
	{ print 'test'.$_GET['submit'];
		$title= $_POST['title'];
		$body= $_POST['body'];
    print $title;
    print $body;
 		$blog->insertArticle($title,$body);
	}

?>
<div id="aroundform">
<?php print "Welcome ".ucfirst($_SESSION['name']).", You are logged in.";?>
<form method="post">

<label for='title'>Title:</label>
<input type="text" size="90" name="title" id="title" /><br/><br/>
<label for="body">Article</label><br/>
<textarea rows="20" col="100" name="body" >Enter your text</textarea>
<input type="submit" name="submit" value="Post" />
</form>
</div><!-- close aroundform-->

</body>
</html>

this is my postarticle.php form

function insertArticle ($title,$body)
  		{
			 $title=addslashes($title);
			 $body=addslashes($body);       

			 $sql= "insert into article (title,body) values ('".$title."','".$body."')";
			 $result = mysql_query($sql) or die ("Error in sql query".$sql." : ".mysql_error());
  		 //print "title is ".$title." body is ".$body."\n";

		}

and this is the function for sql statement to insert it ,
I tried many things , no change

johanafm

I allready explained why you'd get no errors and no updates. Read my entire post this time. Well, I didn't explicitly say that you'd get no update, but the information is there.

fatoosh

I read it but still don't what's wrong , I always used to check input from forms and
it worked .... still don't know why my title and body are empty ....

bradgrafelman

This if() statement:

if (!empty($_GET['submit'])) 
    { print 'test'.$_GET['submit']; 
        $title= $_POST['title']; 
        $body= $_POST['body']; 
    print $title; 
    print $body; 
        $blog->insertArticle($title,$body); 
    }

well never execute given your current form. Why? $_GET['submit'] won't be defined, because there is no 'submit' in the query string.

fatoosh

thanks every one , I changed the $_GET['submit'] into POST and it worked fine