While loop problem

[inulled]

<?php
include("global-settings.php");
session_start();
mysql_connect($dbhost, $dbuser, $dbpass)or die("Could Not Connect: " . mysql_error());
mysql_select_db($dbname) or die(mysql_error());
$email	   = mysql_real_escape_string(strip_tags($_POST['email'])); 
$password  = mysql_real_escape_string(strip_tags(sha1($_POST['password'])));

$result  = mysql_query("SELECT * FROM users WHERE username='$email' AND password='$password'");

while($row = mysql_fetch_array($result)) {
	if ($email == $row['username'] && $password == $row['password']) {
		$_SESSION['user_pid']	= $row['user_pid'];
		$_SESSION['firstname'] 	= $row['first_name'];
		$_SESSION['lastname'] 	= $row['last_name'];
		header("Location: ../protected/home.php");
	} else {
		$userid_generator = uniqid(rand(), false);
		$date = date("Y/m/d");
		mysql_query("INSERT INTO users (user_pid, username, password, datetime_registered)
		VALUES('$userid_generator', '$email', '$password', '$date')")or die(mysql_error());
		$_SESSION['userid']	= $userid_generator;
		$_SESSION['firstname'] 	= $row['first_name'];
		$_SESSION['lastname'] 	= $row['last_name'];

	$leaders_query = "SELECT * FROM leaders";
	$leaders   = mysql_query($leaders_query);

		$id = $row['id'];
		mysql_query("INSERT IGNORE INTO friends (node1id, node2id, is_leader, friends_since, friend_type)
		VALUES('$id', '$userid_generator', 'Yes', '$date', 'full)")or die(mysql_error());	
}
	}
?>

for some reason the while loop doesn't seem to work. It leaves a blank screen. Any help?

[johanafm]

Fix your error related settings in php.ini and you will not get blank screens anymore, but rather get informative information about the error. Well, either that, or a blank screen and useful stuff in the error log depending on how you set it up.

[Derokorian]

Also, on an unrelated note, this line:

    if ($email == $row['username'] && $password == $row['password']) { 

Should always be true since you are only looking for the row(s) with that information matching via the way the query is written.

[inulled]

What settings in php.ini should I change? and okay, so does something like the following work:

if ($email != $row['username'] && $password != $row['password']) {

[bradgrafelman]

inulled;10988533 wrote:

What settings in php.ini should I change?

error_reporting should be set to E_ALL and display_errors (or log_errors, if we're talking about the production environment) should be set to On.

inulled;10988533 wrote:

and okay, so does something like the following work:

if ($email != $row['username'] && $password != $row['password']) {

Both of them "work" in the sense that they don't cause parse errors, but neither of them make any sense logically speaking.

If the email and password don't match a row in the DB, the contents of your while() loop will never get executed since MySQL won't return any rows in the result set.

Furthermore, even if the 'else' branch of the code inside the while() loop did magically get executed, you've got a few problems:

1. Why is datetime_registered not a DATETIME or DATE column?

2. Again, since no rows will be returned from the DB that don't match the email or password, this:

           $_SESSION['firstname']     = $row['first_name']; 
           $_SESSION['lastname']     = $row['last_name'];

   doesn't make any sense.

3. You perform a SELECT query here:

           $leaders_query = "SELECT * FROM leaders"; 
           $leaders   = mysql_query($leaders_query); 

   but then never do anything with the result set. Why?

   Also note that you should avoid 'SELECT ' queries - instead, only SELECT the columns from which you actually need data.
   

4. Again, this:
   

   $id = $row['id']; 

   makes no sense.

5. Why is friends_since not a DATETIME or DATE column?

6. You've got an error in the INSERT IGNORE query at the end (missing single quote).

[inulled]

    <?php
        include("global-settings.php");
        session_start();
        mysql_connect($dbhost, $dbuser, $dbpass)or die("Could Not Connect: " . mysql_error());
        mysql_select_db($dbname) or die(mysql_error());
        $email       = mysql_real_escape_string(strip_tags($_POST['email']));
        $password  = mysql_real_escape_string(strip_tags(sha1($_POST['password'])));
        $result  = mysql_query("SELECT * FROM users WHERE username='$email' AND password='$password'");

    if(mysql_num_rows($result) > 0) {
        $row = mysql_fetch_array($result);
        $_SESSION['user_pid']    = $row['user_pid'];
        $_SESSION['firstname']   = $row['first_name'];
        header("Location: ../protected/home.php");
    } else {
    	$row = mysql_fetch_array($result);
        $userid_generator = uniqid(rand(), false);
        $date = date("Y/m/d");
        mysql_query("INSERT INTO users (user_pid, username, password, datetime_registered) 
        VALUES('$userid_generator', '$email', '$password', '$date')") or die(mysql_error()); 
        $_SESSION['userid']     = $userid_generator;

          mysql_query("SELECT * FROM leaders");  

         $id = $row['id'];
         mysql_query("INSERT IGNORE INTO friends (node1id, node2id, is_leader, friends_since, friend_type)
	     VALUES('$id', '$userid_generator', 'Yes', '$date', 'full')") or die(mysql_error());     
    }
?>

Okay so I've worked on the code a little bit, and it still returns a blank screen. But when I refresh the page it headers out. I've also checked my php.ini file and below is what's set:

; display_errors
; Default Value: On
; Development Value: On
; Production Value: on

; error_reporting
; Default Value: E_ALL & ~E_NOTICE
; Development Value: E_ALL | E_STRICT
; Production Value: E_ALL & ~E_DEPRECATED

And with the SELECT * Leaders statement, I'm trying to pull all the rows from the Leaders table and insert them into the friends table.

[bradgrafelman]

Why do you have this:

$row = mysql_fetch_array($result);

in the else branch? The 'else' branch will only execute if the number of rows is less than or equal to 0 (in other words, no rows in the result set), so why are you trying to... fetch a row?

inulled;10988538 wrote:

Okay so I've worked on the code a little bit, and it still returns a blank screen.

Isn't that to be expected? If the 'else' branch of your code executes, you never output anything nor do you redirect the user anywhere.

inulled;10988538 wrote:

I've also checked my php.ini file and below is what's set

The code snippet you showed us contains only comments, it doesn't actually do anything or define any PHP directive.

inulled;10988538 wrote:

And with the SELECT * Leaders statement, I'm trying to pull all the rows from the Leaders table and insert them into the friends table.

For one, you aren't trying to "pull" any rows at all. Again, you just execute a SELECT statement but never attempt to retrieve any rows or otherwise do anything at all with the result set.

Furthermore... why are you even trying to do that?? Every time a new user is created, you want to duplicate the entire Leaders table at that moment in the friends table? That doesn't really seem logical or useful.

[inulled]

Okay so how do I fix the if...else statement? How should it be coded?