Advice on Database Query..

Mad_T

Hi
I'm using a couple of queries to search a database.
This works well but is slow as I'm cascading the queries..

Below is an example of what I mean... (LDAP queries)

<?
	   $dn = "cn=user";
 	   $filter="(objectclass=user)";
 	   $justthese = array('cn','telephone','guid','ID','email');
 	   $sr=ldap_search($ds, $dn, $filter, $justthese);
 	   $info = ldap_get_entries($ds, $sr);
       		for ($n=0; $n<$info['count']; $n++) {				
				$cn = $info[$n]['cn'][0];
				$email = $info[$n]['email'][0];
				$ID = $info[$n]['id'][0];

   $dn = "cn=Device";
   $filter="(objectclass=device)(userid=$id)";
   $justthese = array('cn','system','guid','ID','userid');
   $sr=ldap_search($ds, $dn, $filter, $justthese);
   $info = ldap_get_entries($ds, $sr);
   		for ($n=0; $n<$info['count']; $n++) {				
			$cn = $info[$n]['cn'][0];
			$system = $info[$n]['system'][0];
			$userid = $info[$n]['userid'][0];

   	}		
  } 
?>

I'm sure there's a better way of writing this... that will make it faster.

Thanks 🙂

dalecosp

I don't know if there is or not ... I do see a couple of head-scratchers (well, for me they're head-scratchers, anyway.

You've already assigned $cn in the top loop ... why are you over-writing it in the bottom?

Also, in the top loop you create a variable "$ID", but a few lines later you call it "$id". As far as I know, those aren't the same variable. That just might be a bug that could cause some problems, but I'm certainly not an expert on such things....

Mad_T

Thanks for the reply.

The $cn was an error on my part..
the $ID vs $id again a typo on my part.

I've got multiple nested queries... which work, but seem slow.
I wondered if there was a better way to write this to speed up the extraction of the data.

Would arrays help and could they be used to search with in each other ?

Thanks