[RESOLVED] Array duplicating..

tkruise

<?php 

$time = mktime(date('H')-2, date('i'), date('s'));
$hora = gmdate("H:i:s", $time); 
$users = array(
                                'username' => 'Admin',
                                'password' => '123',
                                );

            //      print_r($users);


    foreach($users as $value => $key){
    echo 'Testing,  ' . $value .  ' is ' . $key . ' and the ' . $value . ' is' . $key . ' .';
    }
    echo 'Right now, its ' . $hora;


?>

I was studying arrays when I came to this, the first echo is outputing 2 times, whats wrong?
I wanted to output

'Testing, username is admin and the password is 123.'

jeepin81

b/c you were echoing the $value & $key twice.

You also had an extra ',' in your array.

try this:

<?php 

$time = mktime(date('H')-2, date('i'), date('s')); 
$hora = gmdate("H:i:s", $time); 
$users = array( 'username' => 'Admin','password' => '123'); 



    foreach($users as $value => $key){ 
    	echo 'Testing,  ' . $value .  ' is ' . $key; 
    	echo '<br/>';
	} 
    echo 'Right now, its ' . $hora; 

?>

johanafm

jeepin81;10989435 wrote:
You also had an extra ',' in your array.

What you call an "extra" , is in fact perfectly valid php syntax and some people prefer always using trailing array element commas to avoid syntax errors when adding more elements.

Bonesnap

Trailing commas in arrays always sketch me out. I don't understand why they're there to avoid syntax errors when adding additional elements to the array can be done as simply as $array[] = $value;. I guess it's more of a personal preference.

bradgrafelman

Bonesnap;10989664 wrote:
Trailing commas in arrays always sketch me out. I don't understand why they're there to avoid syntax errors when adding additional elements to the array can be done as simply as $array[] = $value;. I guess it's more of a personal preference.

We're not talking about adding entries to arrays during runtime - it's while actually editing the code that it comes in handy. For example, you'll find a lot of trailing commas in phpBB source code because it makes creating mods easier - you just insert a new line in an array for the mod (which also contains a trailing comma) at the end rather than writing some logic condition that adds a comma to the preceding array entry if necessary.

Bonesnap

bradgrafelman;10989680 wrote:
We're not talking about adding entries to arrays during runtime - it's while actually editing the code that it comes in handy. For example, you'll find a lot of trailing commas in phpBB source code because it makes creating mods easier - you just insert a new line in an array for the mod (which also contains a trailing comma) at the end rather than writing some logic condition that adds a comma to the preceding array entry if necessary.

I see, so it's used for when you don't have access to the actual source code? I'm confused, because can't you just add another comma if you're going to add additional elements to the array? Just seems trivial to me. I mean, if you're already there modifying the source code, just make sure there's another comma. shrug

Or maybe I'm misunderstanding this.

laserlight

Bonesnap wrote:
I see, so it's used for when you don't have access to the actual source code?

No, bradgrafelman's example is concerned with an automated edit made to say, a configuration file written in PHP.

Bonesnap wrote:
I'm confused, because can't you just add another comma if you're going to add additional elements to the array?

You could.

Bonesnap wrote:
Just seems trivial to me. I mean, if you're already there modifying the source code, just make sure there's another comma. shrug

Consider this style:

$x = array(
    'hello',
    'world'
);

It is conceivable that a maintainer may forget to add the comma:

$x = array(
    'hello',
    'world'
    'Bonesnap'
);

whereas this would be more consistent and such a mistake would be less likely:

$x = array(
    'hello',
    'world',
    'Bonesnap',
);

But if you were writing this instead:

$x = array('hello', 'world');

then such a trailing comma probably makes less sense.

Bonesnap

It's conceivable a maintainer could forget to do anything. The worst that would happen would be a syntax error, upon which you find the line with the error and the fix would be obvious.

Maybe I'm weird, but if I were to add another element to the array in the first example, I'd start my cursor on the line of the last (currently) element, and then press the comma key and then enter. I guess it's just how I learned and it's become second nature to me.

laserlight

Bonesnap wrote:
It's conceivable a maintainer could forget to do anything.

Of course. But if you can reduce the chance of a mistake, even one that is likely to be detected and fixed, or make it easier for an automated edit via an install script for a mod/plugin/update/etc, or simply be stylistically consistent with surrounding code, why not?

Bonesnap

laserlight;10990040 wrote:
Of course. But if you can reduce the chance of a mistake, even one that is likely to be detected and fixed, or make it easier for an automated edit via an install script for a mod/plugin/update/etc, or simply be stylistically consistent with surrounding code, why not?

I guess I just view it differently. I don't "see" a chance of a mistake because to me putting the commas between the array elements is as "normal" as putting semicolons to the end of statements. Other than the automated edit, I don't see any real gain for using it. That said, I'm not saying don't use it. I just wouldn't.