[RESOLVED] Log in parsing error

[AlexMK92]

Hi guys; I'm pretty new to PHP and im currently taking my A levels, for my project I am making a website that uses a server side log in system which allows users to access there account, sure this shouldn't be too hard for many of you to debug!
Here's the code I have presently

<?php
		//Execute the the following script once "submit" button is pressed
	if(isset($_POST['submit']));
			// Include the connection.php file
				include('scripts/connection.php');

	//List of variables that are assigned against the Register.php
{
	$username = $_POST['username'];
	$password = $_POST['password'];
	$password2 = $_POST['password2'];
	$email = $_POST['email'];
	$email2 = $_POST['email2'];
	$firstname = $_POST['firstname'];
	$lastname = $_POST['lastname'];
	$dob = $_POST['dob'];
	$address = $_POST['address'];
	$address2 = $_POST['address2'];
	$town = $_POST['town'];
	$county = $_POST['county'];
	$postcode = $_POST['postcode'];
	$contact = $_POST['contact'];


	//Else statement to force a valid e-mail syntax to be inputted
	//Echo statemment outputs error message to browser
	if(!filter_var($email,FILTER_VALIDATE_EMAIL) || !filter_var($email2,FILTER_VALIDATE_EMAIL))	
		{
			echo 'A valid E-mail is required.';
		}
	//Statement to say if Contact is not equal to numeric string then present error.
	elseif(!empty($contact))
		{
			if(!is_numeric($contact))
				{
					echo 'Enter a valid Contact No.';
				}
		}
	if($password != $password2)
		{
			echo "Passwords do not match!";
		}
	elseif($email != $email2)
		{
			echo 'Emails do not match!';
		}
	//  statement to distinguish if the named fields are populated.
	// echo statemement is the output if the value is false for any of the variable $
	elseif
	(empty($username) || empty($password) || empty($password2) ||	empty($firstname) || empty($lastname) || empty($dob) ||	empty($address) || empty($town) || empty($county) || empty($postcode))
		{
			echo ' All fields marked with an * are required';
		}
	else
		{
			$password = md5($password);
			$sql = mysql_query("INSERT INTO users(username,password,email,firstname,lastname,dob,address1,address2,town,county,postcode,contact,time)
			VALUES('$username','$password','$email','$firstname','$lastname','$dob','$address1','$address2','$town','$county','$postcode','$contact', now())") or die(mysql_error());

			if($sql)
				{
					echo 'Successfully submitted, you may now login';
				}
		}
}
?>

I can also place in the included files if needed in future, register.php is merely a HTML form built up in <P> blocks and the other two files are the SQL connection file and CSS sheet.
When I run this from my WAMP server I receive an "undefined Index" error and then below my form is still presented, now I know undefined Index normally means that the variable hasnt been defined? but whats confusing me is the fact that previosly whilst developing this code, this error did not appear.

Any help would be greatly appreciated

Thanks
Alex.

[AlexMK92]

Quick update guys; I've adapted my script to imrpove some functionalities, the script does function properly and post the information to the database, its just annoying as the index error always pops up every time I start the form, once I hit the register button once and the page is refreshed all index errors disappear...

<?php
/////////////////////////////////////////////////////////
// Project : Absolute Beginners log in system ///////////
// Purpose : A2 Level Coursework for ICT ////////////////
// Teacher : Mr L Hawkins ///////////////////////////////
// Student : Alex Sims //////////////////////////////////
// Candidate No. : 4173 /////////////////////////////////
// Centre No : 27168 ////////////////////////////////////
/////////////////////////////////////////////////////////


		// Include the connection.php file
			include('scripts/connection.php');
	//Execute the the following script once "submit" button is pressed
if(isset($_POST['submit']));


/////////////////////////////////////////////////////////////////////////////////


	//List of variables that are assigned against the Register.php
{
	$username = $_POST['username'];
	$password = $_POST['password'];
	$password2 = $_POST['password2'];
	$email = $_POST['email'];
	$email2 = $_POST['email2'];
	$firstname = $_POST['firstname'];
	$lastname = $_POST['lastname'];
	$dob = $_POST['dob'];
	$address = $_POST['address'];
	$address2 = $_POST['address2'];
	$town = $_POST['town'];
	$county = $_POST['county'];
	$postcode = $_POST['postcode'];
	$contact = $_POST['contact'];

    // End of assigned variables



/////////////////////////////////////////////////////////////////////////////////



	// This code looks into the SQL database and distinguishes whether the

	$fetch = mysql_query("SELECT * FROM users WHERE email = '$email'") or die(mysql_error());
	$fetch = mysql_query("SELECT * FROM users WHERE username = '$username'") or die (mysql_error());
	$num_rows = mysql_num_rows($fetch);


/////////////////////////////////////////////////////////////////////////////////


	//Else statement to force a valid e-mail syntax to be inputted
	//Echo statemment outputs error message to browser

	if(!filter_var($email,FILTER_VALIDATE_EMAIL) || !filter_var($email2,FILTER_VALIDATE_EMAIL))	
		{
			echo 'A valid E-mail is required.';
		}

	//Statement to say if Contact is not equal to numeric string then present error.
	elseif(!empty($contact))
		{
			if(!is_numeric($contact))
				{
					echo 'Enter a valid Contact No.';
				}
/////////////////////////////////////////////////////////////////////////////////
			}
		if($password != $password2)
			{
				echo "Passwords do not match!";
			}
		elseif($email != $email2)
			{
				echo 'Emails do not match!';
			}

		// PASSWORD AND EMAIL MATCH VALIDATION
/////////////////////////////////////////////////////////////////////////////////



	//  statement to distinguish if the named fields are populated.
	// echo statemement is the output if the value is false for any of the variable $
	elseif
	(empty($username) || empty($password) || empty($password2) ||	empty($firstname) || empty($lastname) || empty($dob) ||	empty($address) || empty($town) || empty($county) || empty($postcode))
		{
			echo ' All fields marked with an * are required';
		}
	// End of presence check validation



/////////////////////////////////////////////////////////////////////////////////



	// IF the username or email in the DB is Greather than or = to 1 then echo this message
	elseif($num_rows >= 1)
	{
		echo 'This E-Mail Address already exists in our database please try again';
	}
	// End of existing user validation



/////////////////////////////////////////////////////////////////////////////////

	else
		{
			$password = md5($password);
			$sql = mysql_query("INSERT INTO users(username,password,email,firstname,lastname,dob,address1,address2,town,county,postcode,contact,time)
			VALUES('$username','$password','$email','$firstname','$lastname','$dob','$address','$address2','$town','$county','$postcode','$contact', now())") or die(mysql_error());

			if($sql)
				{
					echo 'Successfully submitted, you may now login';
				}
		}
}


/////////////////////////////////////////////////////////////////////////////////
?>

[Bonesnap]

Can you post the actual error?

[AlexMK92]

Sure I get
Notice: Undefined index: username in C:\wamp\www\PHPLogin\scripts\valid.php on line 24
Notice: Undefined index: username in C:\wamp\www\PHPLogin\scripts\valid.php on line 25
Notice: Undefined index: username in C:\wamp\www\PHPLogin\scripts\valid.php on line 26
Notice: Undefined index: username in C:\wamp\www\PHPLogin\scripts\valid.php on line 27
and so on, this appears true all the way up to line 37 (which is this part of the code)

$username = $_POST['username'];
        $password = $_POST['password'];
        $password2 = $_POST['password2'];
        $email = $_POST['email'];
        $email2 = $_POST['email2'];
        $firstname = $_POST['firstname'];
        $lastname = $_POST['lastname'];
        $dob = $_POST['dob'];
        $address = $_POST['address'];
        $address2 = $_POST['address2'];
        $town = $_POST['town'];
        $county = $_POST['county'];
        $postcode = $_POST['postcode'];
        $contact = $_POST['contact'];

[johanafm]

AlexMK92;10989782 wrote:

	if(isset($_POST['submit']));

See anything suspicious here?

[AlexMK92]

Hmm, looks fine to me, but then again I'm a newbie!! I don't believe that's wrong?

[johanafm]

This is not syntactically wrong, but it does alter the program flow in a non-intended way.

;

[AlexMK92]

unfortunately after changing that, the error did not disappear, hmm so confused!

[johanafm]

You removed the ; so you now have exactly this?

    if(isset($_POST['submit']))
    {

[AlexMK92]

you my friend are a life saver!!
such a stupid mistake, I missed out the curly brace so therefore the index's on the variables were left open to the parser hence the error
Thank you!!

[Weedpacket]

Incidentally, these aren't parser errors; a parser error would mean that the script can't even start - because it can't be parsed.