[RESOLVED] PHP Upgrade Broke Script...I Think!

GoNorthWest

Hi,

I had a form handling script that was running on my website which was working fine while I was running PHP v5.2.4. I had to upgrade to 5.2.14 in order to resolve a dependency for wikimedia, and now my script is having issues. The odd thing is that it partly works, and I cannot figure out for the life of me what's going on. Here's the general deal :

I send to the script via my browser the following parameters:

app-test.php?latitude=32.1754&longitude=-111.09375

The info gets grabbed like this:

$latitude = $_GET['latitude'];
$longitude = $_GET['longitude'];

I then return a form that is populated with the values, just in case the user wants to tweak them, and to have them add a bit more information. Here is the form code :

 <tr>
    <td><input type="text" name="latitude" size="40" value="<?php $latitude ?>"></td>
  </tr>
  <tr>
    <td><strong> Longitude </strong></td>
  </tr>
  <tr>
    <td><input type="text" name="longitude" size="40" value="<?php $longitude ?>"></td>
  </tr>

All I am getting in the returned form is the actual text you see in the value= section. It was working before the upgrade, and stopped after. Nothing else changed.

The other odd part is that I present a static map image using the lat/long coords passed to the script using this line:

    <?php
    printf ("<img src=\"http://maps.googleapis.com/maps/api/staticmap?center=%s,%s&markers=color:blue|%s,%s&zoom=15&size=300x150&sensor=false\">", $latitude, $longitude, $latitude, $longitude);
    ?>

That still works perfectly. So, I know the lat/long sent to the script are being used to set the variables. I just cannot figure out why it won't populate the form field with the info, and is putting the php code in instead!

I'm sure I could make this work with the printf statement like I do for my map, but I'm more interested in understanding why this isn't working. Does anybody have any thoughts?

Thanks!

Mark

Weedpacket

GoNorthWest wrote:
All I am getting in the returned form is the actual text you see in the value= section.

I'm actually surprised it was working to begin with:

<td><input type="text" name="latitude" size="40" value="<?php $latitude ?>"></td>

would usually just output

<td><input type="text" name="latitude" size="40" value="">

because the bit in the PHP tags doesn't output anything.

I'm also at a loss as to how PHP in one part of the page can be parsed, compiled and executed while PHP in another part of the same page isn't even parsed. The only way I can see to pull off a trick like that is if the whole form - embedded PHP tags and all - is itself inside a literal PHP string and then that string is being output later on.

dalecosp

Concur, can't even make this happen with short_open_tag=ON....

dalecosp

Is all the code in the same script?

GoNorthWest

dalecosp;10990088 wrote:
Concur, can't even make this happen with short_open_tag=ON....

So, I assure you that this worked at one time. I have a database of lat/long values to prove it!

Assuming it didn't, though, for a minute...what are your suggestions on how to make this work? I basically just need to populate a form with values that passed to a script via a URL. I've used this method before multiple times and it's worked, but I'm always open for more elegant solutions!

And, yep, it's all in one script.

Thanks!

Mark

bradgrafelman

GoNorthWest;10990103 wrote:
So, I assure you that this worked at one time. I have a database of lat/long values to prove it!

We're not saying that your application never worked... just that the code you've shown us above never did.

This:

<?php
1+1;
2+2;
3+3;
1*2*3*4*5*6*7*8;
?>

is equivalent to doing this:

<?php
?>

since you never actually do anything, such as [man]echo[/man] or [man]print[/man] something.

GoNorthWest

So why would it not put in the value for the $latitude variable there? It's been defined in the code at the start of the script. That's what it's done in the past.

bradgrafelman

GoNorthWest;10990106 wrote:
So why would it not put in the value for the $latitude variable there?

Because this:

<?php $var; ?>

is no different than this:

<?php 1+1; ?>

which is, again, no different than:

<?php ?>

since you aren't telling PHP to do anything (such as echo/print the variable's value).

GoNorthWest;10990106 wrote:
That's what it's done in the past.

Alright, then I challenge you to name any version of PHP (well, PHP 4.0-current, I don't have any experience with PHP 3 and earlier) where this:

<?php $variable ?>

actually outputs the value of the variable.

GoNorthWest

I'm more interested in understanding how to make this work than proving that it's worked in the past. Do you have a method that WILL work? I'm open to learning!

bradgrafelman

GoNorthWest;10990108 wrote:
Do you have a method that WILL work?

I've been saying it all along... [man]echo[/man] or [man]print[/man] the variable.

GoNorthWest

Using this now and it works:

value="<?php echo $_GET['latitude']; ?>"

Thanks!