while loop problem

Beffic

So when I take out the While loop it will post:

$message = "<b><u>Messages while you were offline:</u></b><br />";

Post with no problem. But with the while loop that will not post at all nether the content within the while loop... Any idea what would be causing this?

$finder = "SELECT * FROM `chatroommessage` WHERE `to`='".$char['username']."'";
$findOfflineMessages = mysql_query($finder);
if(mysql_num_rows($findOfflineMessages) > 1){
	$message = "<b><u>Messages while you were offline:</u></b><br />";
	while($findMsg = mysql_fetch_assoc($findOfflineMessages)){
		$message .= $findMsg['message'];
	}

$activeTime = time();
$query = mysql_query("INSERT INTO `chatroom` (`date`, `userlevel`, `username`, `to`, `message`) VALUES ('".$activeTime."', '4', 'PM', '".$char['username']."', '".$message."')");
}

Weedpacket

I don't see anything getting "posted" at all. Nor, which might be more to the point, do I see you escaping any text before inserting it into the query.

(I'm going to resist commenting on the db structure - even if I do find it slightly odd-looking.)

Beffic

I am not producing my code for some other guy to buy. So the way I structure my database is my own decision and not part of this question. But if it could be causing a problem that would be great info to know. Now on to the point...

All of this is getting posted to a database for me to use in my chat room, so I am not posting with an echo or a print.

Now, what do you mean by escaping the text?

Weedpacket

Oh, so by "post" you mean "insert".

And do you mean you've never found the need to use [man]mysql_real_escape_string[/man] in case the strings you're inserting into the database contain quotes?

Beffic

Yes insert,

and no I have never had to use that before which actually might be the problem in this case. I have always tried avoiding the quotes as much as possible in the database.

Beffic

Well I gave that a try but am still in the same situation. Maybe I am not understand the mysql_real_escape_string that much...

while($findMsg = mysql_fetch_assoc($findOfflineMessages)){
		$message .= mysql_real_escape_string($findMsg['message']);
	}

Beffic

bump

Bonesnap

mysql_real_escape_string is used when inserting data into the database, not retrieving or displaying data.

Beffic

I am a little confused. I would put the mysql_real_escape_string withing the insert query around $message?

Bonesnap

Beffic;10990448 wrote:
I am a little confused. I would put the mysql_real_escape_string withing the insert query around $message?

That's correct. And possibly around $char['username'], too, though I am not sure where that is coming from. Put it around $message at the very least.

Beffic

Okay, so this is what I am understanding.

    $query = mysql_query("INSERT INTO `chatroom` (`date`, `userlevel`, `username`, `to`, `message`) VALUES ('".$activeTime."', '4', 'PM', '".$char['username']."', '".mysql_real_escape_string($message)."')");

Still my problem remains. This is a sample of what the message column holds.

From <a href='javascript:toptell("Shilo");'>Shilo</a>: from Blue Evil Slug. Remaining: 16 [1319504248]

Weedpacket

Beffic wrote:
I have always tried avoiding the quotes as much as possible in the database.

Beffic wrote:
From <a href='javascript:toptell("Shilo");'>Shilo</a>: from Blue Evil Slug. Remaining: 16 [1319504248] 
[emphasis mine]

Is an insertion happening? If yes, what does it end up containing? If not, what error messages are you getting from the database server?

Is the selection working? I.e., does the "SELECT message" - I mean, "SELECT *" actually return anything?

(Okay, I tried to resist but....you're letting your style and design get itself deeply mixed with your data: if you ever want to change the appearance of something you'll probably have a LOT of work to do. Unless this is a caching mechanism, which is why I didn't say anything. Oh, and 1997 called; they want their tags back.)