[RESOLVED] default value

rdztech

Hi,

Below are my code. Please help me:
1) How to remove the below error. i dont know how to set initial value for 'q'.

"Connected to DatabaseYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 "

2) After select an option, the bar remain the default value 'id' . I want the value changed to selected one... in my pull down menu.

Thank you.

=radzi=

<div class="pulldown"> 
<form method="GET" action="<?=$self?>" > 
Sort by: 
<select id="q" name="q"> 
<optgroup label="Lorry Info"> 
<option value="id" >id</option> 
<option value="Lorry_No" >Lorry No</option> 
<option value="Location" >Location</option> 
<option value="Type" >Type</option> 
</optgroup> 
<optgroup label="Date Due"> 
<option value="Road_Tax_Expiry">Road Tax Expiry</option> 
<option value="Puspakom_Expiry">Puspakom Expiry</option> 
<option value="Mileage">Mileage</option> 
</optgroup> 
</select> 
<input type="submit" value="show »" /> 
</form> 
</div> 


<?php

$Sortby = $_REQUEST['q'];

mysql_connect("localhost", "user", "pass") or die(mysql_error());
echo "Connected to MySQL<br />";
mysql_select_db("warisanm_fleet") or die(mysql_error());
echo "Connected to Database";


// Get all the data from the "example" table
$result = mysql_query("SELECT * FROM fleet ORDER BY $Sortby") 
or die(mysql_error());  


echo "<table border='1'>";
echo "<tr> <th>ID</th> <th>Lorry No</th> <th>Trailer No</th> <th>Logo No</th> <th>Location</th> <th>Type</th> <th>Road Tax Expiry</th> <th>Puspakom Expiry</th> <th>Mileage</th> <th>Shell Card Limit</th> <th>Revenue</th> <th>Tyre</th> <th>Maintenance</th> <th>Fuel Consumption</th>  <th>Driver Name</th> <th>Remarks</th>  </tr>";




// keeps getting the next row until there are no more to get
while($row = mysql_fetch_array( $result )) {
	// Print out the contents of each row into a table
	echo "<tr><td>"; 
	echo $row['id'];
     echo "</td><td>";
	echo $row['Lorry_No'];
	echo "</td><td>"; 
	echo $row['Trailer_No'];
     echo "</td><td>"; 
	echo $row['Logo_No'];
	echo "</td><td>"; 
	echo $row['Location'];
	echo "</td><td>"; 
	echo $row['Type'];
	echo "</td><td>"; 
	echo $row['Road_Tax_Expiry'];
	echo "</td><td>"; 
	echo $row['Puspakom_Expiry'];
	echo "</td><td>"; 
	echo $row['Mileage'];
	echo "</td><td>"; 
	echo $row['Shell_Card_Limit'];
	echo "</td><td>"; 
	echo $row['Revenue'];
	echo "</td><td>"; 
	echo $row['Tyre'];
	echo "</td><td>"; 
	echo $row['Maintenance'];
	echo "</td><td>"; 
	echo $row['Fuel_Consumption'];
	echo "</td><td>"; 
	echo $row['Driver_Name'];
	echo "</td><td>"; 
	echo $row['Remarks'];
	echo "</td></tr>";  

} 

echo "</table>";
?>

djjjozsi

an If condition would be good for this.

$Sortby = isset($_REQUEST['q']) ? $_REQUEST['q'] : 'fieldname';

plus!
use mysql_fetch_assoc() instead. And here is a trick.
Do not hardcode all the field names, apply a cycle.

while ( $row = mysql_fetch_assoc( $result ) ) {
    echo '<tr>';
    foreach( $row AS $c ) {
        printf( '<td>%s</td>' , $c );
    } 
    echo '</tr>';
}

rdztech

$Sortby = isset($REQUEST['q']) ? $REQUEST['q'] : 'fieldname'; works very well... TQ Sir

rdztech

Both code work very well. TQVM, djjjozsi.

but appreciate if can help me another issue, when I select sorting field, how to remain the selection in pull down menu... currently it will return to default 'id'.

=radzi=

rdztech

rdztech;10990959 wrote:
Both code work very well. TQVM, djjjozsi.

but appreciate if can help me another issue, when I select sorting field, how to remain the selection in pull down menu... currently it will return to default 'id'.

=radzi=

Below is my code:

<div class="pulldown"> 
<form method="GET" action="<?=$self?>" > 
Sort by: 
<select id="q" name="q"> 
<optgroup label="Lorry Info"> 
<option value="id" >id</option> 
<option value="Lorry_No" >Lorry No</option> 
<option value="Location" >Location</option> 
<option value="Type" >Type</option> 
</optgroup> 
<optgroup label="Date Due"> 
<option value="Road_Tax_Expiry">Road Tax Expiry</option> 
<option value="Puspakom_Expiry">Puspakom Expiry</option> 
<option value="Mileage">Mileage</option> 
</optgroup> 
</select> 
<input type="submit" value="show »" /> 
</form> 
</div> 


<?php

$Sortby = isset($_REQUEST['q']) ? $_REQUEST['q'] : 'id'; 

// $Sortby = $_REQUEST['q'];

mysql_connect("localhost", "user", "pass") or die(mysql_error());
echo "Connected to MySQL<br />";
mysql_select_db("warisanm_fleet") or die(mysql_error());
echo "Connected to Database";


// Get all the data from the "example" table
$result = mysql_query("SELECT * FROM fleet ORDER BY $Sortby") 
or die(mysql_error());  



echo "<table border='1'>";
echo "<tr> <th>ID</th> <th>Lorry No</th> <th>Trailer No</th> <th>Logo No</th> <th>Location</th> <th>Type</th> <th>Road Tax Expiry</th> <th>Puspakom Expiry</th> <th>Mileage</th> <th>Shell Card Limit</th> <th>Revenue</th> <th>Tyre</th> <th>Maintenance</th> <th>Fuel Consumption</th>  <th>Driver Name</th> <th>Remarks</th>  </tr>";






// keeps getting the next row until there are no more to get


while ( $row = mysql_fetch_assoc( $result ) ) { 
    echo '<tr>'; 
    foreach( $row AS $c ) { 
        printf( '<td>%s</td>' , $c ); 
    } 
    echo '</tr>'; 
} 


echo "</table>";
?>

djjjozsi

i show you in three line, here is the hardcoded version, where you create the select option with a function:

<?php
function v( $value , $option )
{
    /* make sure the $option and $value converted to HTML entities */
    $value = htmlspecialchars( $value );
    $option = htmlspecialchars( $option );
    // set the selected tag if you have a selected item
    $selected = (isset( $_REQUEST["q"]) AND $_REQUEST["q"] == $value )?'selected="selected"' : '';
    // read more about printf!
    printf( "<option value='%s' %s>%s</option>\r" , $value , $selected , $option );
} 

?>
<select id="q" name="q">
<optgroup label="Lorry Info">
<?php
v( 'id' , 'id' );
v( 'Lorry_No' , 'Lorry No' );
v( 'Location' , 'Location' );
// ... and so on!
?>

Instead of doing such a bad hardcoded listboxes, try to save the field names from an array and render the options from this.

rdztech

Thank you Sir, now my code fully functional as below. TQVM...

<?php
function v( $value , $option )
{
/ make sure the $option and $value converted to HTML entities /
$value = htmlspecialchars( $value );
$option = htmlspecialchars( $option );
// set the selected tag if you have a selected item
$selected = (isset( $REQUEST["q"]) AND $REQUEST["q"] == $value )?'selected="selected"' : '';
// read more about printf!
printf( "<option value='%s' %s>%s</option>\r" , $value , $selected , $option );
}
?>

<?php

$Sortby = isset($REQUEST['q']) ? $REQUEST['q'] : 'id';

mysql_connect("localhost", "warisanm_fleet", "warisan007") or die(mysql_error());
echo "Connected to MySQL<br />";
mysql_select_db("warisanm_fleet") or die(mysql_error());
echo "Connected to Database";

// Get all the data from the "example" table
$result = mysql_query("SELECT * FROM fleet ORDER BY $Sortby")
or die(mysql_error());

echo "<table border='1'>";
echo "<tr> <th>ID</th> <th>Lorry No</th> <th>Trailer No</th> <th>Location</th> <th>Logo No</th> <th>Type</th> <th>Road Tax Expiry</th> <th>Puspakom Expiry</th> <th>Mileage</th> <th>Shell Card Limit</th> <th>Revenue</th> <th>Tyre</th> <th>Maintenance</th> <th>Fuel Consumption</th> <th>Driver Name</th> <th>Remarks</th> </tr>";

// keeps getting the next row until there are no more to get

while ( $row = mysql_fetch_assoc( $result ) ) {
echo '<tr>';
foreach( $row AS $c ) {
printf( '<td>%s</td>' , $c );
}
echo '</tr>';
}

echo "</table>";
?>

rdztech

http://www.warisanmovers.com/operations/fms/resultsort.php TQVM

djjjozsi

rdztech;10990987 wrote:
http://www.warisanmovers.com/operations/fms/resultsort.php TQVM

Your Welcome! Next time you should use the PHP BB tags around your PHP codes for a better read, please.

rdztech

djjjozsi;10990988 wrote:
Your Welcome! Next time you should use the PHP BB tags around your PHP codes for a better read, please.

This is the first time I use php. PHP BB should mean remarks '//' if I'm not mistaken...😕

djjjozsi

when you are posting here a PHP code, try to select it, and press on the PHP icon (last icon on the top).

rdztech

Did it. TQ...

<?php
function v( $value , $option )
{
/ make sure the $option and $value converted to HTML entities /
$value = htmlspecialchars( $value );
$option = htmlspecialchars( $option );
// set the selected tag if you have a selected item
$selected = (isset( $REQUEST["q"]) AND $REQUEST["q"] == $value )?'selected="selected"' : '';
// read more about printf!
printf( "<option value='%s' %s>%s</option>\r" , $value , $selected , $option );
}
?>

<form method="GET" action="<?=$self?>" >
<select id="q" name="q">
<optgroup label="Lorry Info">
<?php
v( 'id' , 'id' );
v( 'Lorry_No' , 'Lorry No' );
v( 'Location' , 'Location' );
v( 'Type' , 'Type' );
?>
<optgroup label="Expiry Date">
<?php
v( 'Road_Tax_Expiry' , 'Road_Tax_Expiry' );
v( 'Puspakom_Expiry' , 'Puspakom_Expiry' );
v( 'Mileage' , 'Mileage' );
?>
</select>
<input type="submit" value="show »" />
</form>
</div>

<?php

$Sortby = isset($REQUEST['q']) ? $REQUEST['q'] : 'id';

mysql_connect("localhost", "warisanm_fleet", "warisan007") or die(mysql_error());
echo "Connected to MySQL<br />";
mysql_select_db("warisanm_fleet") or die(mysql_error());
echo "Connected to Database";

// Get all the data from the "example" table
$result = mysql_query("SELECT * FROM fleet ORDER BY $Sortby")
or die(mysql_error());

echo "<table border='1'>";
echo "<tr> <th>ID</th> <th>Lorry No</th> <th>Trailer No</th> <th>Location</th> <th>Logo No</th> <th>Type</th> <th>Road Tax Expiry</th> <th>Puspakom Expiry</th> <th>Mileage</th> <th>Shell Card Limit</th> <th>Revenue</th> <th>Tyre</th> <th>Maintenance</th> <th>Fuel Consumption</th> <th>Driver Name</th> <th>Remarks</th> </tr>";

// keeps getting the next row until there are no more to get

while ( $row = mysql_fetch_assoc( $result ) ) {
echo '<tr>';
foreach( $row AS $c ) {
printf( '<td>%s</td>' , $c );
}
echo '</tr>';
}

echo "</table>";
?>