PHP - Help ASAP Please! - PHPBuilder Forums

PHP - Help ASAP Please!

micky007

Hi Guys,

I've managed to code what i need it do to but i have an issue, below is my code:

$postcode=$_GET['postcode'];

function countchar ($string) { 

$resultpostcode = strlen ($string)  -   substr_count($string, ' '); 
echo $resultpostcode;  

} 

countchar ($postcode);


if ( $resultpostcode == 6 ) {

	echo "Postcode1 ";
	echo substr($postcode, 0, 3);
	echo "<br>";
	echo "Postcode2 ";
	echo substr($postcode, 3);

} elseif( $resultpostcode == 7 ){

	echo "Postcode1 ";
	echo substr($postcode, 0, 4);
	echo "<br>";
	echo "Postcode2 ";
	echo substr($postcode, 4);

}else {
	echo "error";
}

If the value of postcoderesult is 6 (it even outputs 6) then it wont echo what it should be doing, the same if its 7. It just keeps echoing Error.

Any help would be great please.

Thank you.

Weedpacket

$resultpostcode only has a value inside the function. You return the value from the function, but you never do anything with it. So outside the function $resultpostcode doesn't have any value.

$resultpostcode = countchar($postcode);

micky007

Hi,

Thanks for your reply, I've tried what you said and still doesn't work 🙁

postcodesplit.php?postcode=WA28PR

<?php
$postcode=$_GET['postcode']; 

function countchar ($string) { 

$resultpostcode = strlen ($string)  -   substr_count($string, ' '); 
echo $resultpostcode;   

} 

countchar ($postcode); 
echo "<br><br>";
$resultpostcode = countchar($postcode); 
echo "<br><br>";

if ( $resultpostcode == 6 ) { 

    echo "Postcode1 "; 
    echo substr($postcode, 0, 3); 
    echo "<br>"; 
    echo "Postcode2 "; 
    echo substr($postcode, 3); 

} elseif( $resultpostcode == 7 ){ 

    echo "Postcode1 "; 
    echo substr($postcode, 0, 4); 
    echo "<br>"; 
    echo "Postcode2 "; 
    echo substr($postcode, 4); 

}else { 
    echo "error"; 
} 
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>
</body>
</html>

Output:

6

6

error

bradgrafelman

I think Weedpacket misread your function, since it actually doesn't return anything.

Change the function so that it [man]return[/man]s data rather than simply printing it to screen.