Criteria Check not working

[andyj_84]

Hi, I'm wanting to check that an offer in my db is less than 999 and that the offer is still valid i.e. today is 19/11/11 and offer expires 20/11/11. If it is apply a discount. And if it's 999 or the offer has expired then don't apply a discount. When I try this it just applies the discount unless the offer id is 999. Here's my code.

$sql = 'SELECT * FROM `offers` order by offerid desc limit 1';

$rs=mysql_query($sql);

while ($row=mysql_fetch_array($rs))
{
$offid=$row["offerid"];
$start = date ("j/n/y");
$end = date ("j/n/y",strtotime($row["offerexp"]));

if ($offid<999 and strtotime($start) <= strtotime($end)){
echo ("<input type=\"hidden\" name=\"offid\" value=\"$offid\">");
echo ("You are entitled to a discount of ").$row["offerdisc"];
}
else
if ($offid=999 or strtotime($start) > strtotime($end)){
echo ("<input type=\"hidden\" name=\"offid\" value=\"$offid\">");
echo ("There are currently no offers.");
}
}

[bradgrafelman]

For one, why isn't the "offerexp" column a DATETIME column?

Second, why not add the conditions that you want (offer ID isn't 999 and the offer hasn't expired yet) to a WHERE condition in your query? There's no sense in SELECT'ing a bunch of rows that you don't even want, not to mention the fact that it would be much more efficient to let the SQL server do the comparisons and only return the row(s) you want.

Finally, note that you've got a problem in your PHP syntax here:

if ($offid=999 or strtotime($start) > strtotime($end)){ 

Note that you are assigning the value of 999 to the variable $offid rather than comparing the two values. To do the latter, you need a comparison operator (such as a double equal sign).