Contact.php form is sending empty emails

tomkilbourn

Hello,

I am trying to get my Contact.php mailing form to work but am having a little difficulty in making the "name" and "email" address fields of the sender appear in the emails I recieve when I test the form.

The form is actually sending emails and the ReCaptcha is working and the message displaying wether the form captcha was entered correctly or not is also working.

The code is sending me emails without the name of the sender or their email address displayed. I am only recieving "Email sent from:" and "has sent you a message:-"

What am I doing wrong?

<?php
	// DEMO to use reCAPTCHA library on a form
	//
	//	courtesy Spectrum Nashville
	//	http://www.spectrum-nashville.com
	//	
	//  provide the Public Key and Private Key for your account here:

define( API_PUBLIC_KEY, xxxxxxxxxxxxxxx' );
define( API_PRIVATE_KEY, xxxxxxxxxxxxxxx'  );

//
//	once the keys have been provided above, this demo should work without any further changes to the code below
//
//	include the recaptcha library file here
//
require_once('recaptchalib.php');
//
//	the $validated variable will switch to true in the code below if a valid CAPTCHA is submitted (see code below).
//	do not change this.
//
$validated = false;
?>

<?php 
	// 

//
//	see the form below and look for the hidden input named 'validate' to see how this works. This is a nice flag to
//	indicate to us that the validation should be attempted. The first time a user browses to this page, there will be
//	no 'validate' variable in the $_POST[] array, so no validation is attempted and no error message will be generated.
//
//	do not change any of this code.
//
if( $_POST['validate'] === 'yes' ) { 
	$response = recaptcha_check_answer( API_PRIVATE_KEY,
									   	$_SERVER['REMOTE_ADDR'],
										$_POST['recaptcha_challenge_field'],
										$_POST['recaptcha_response_field']
										);

	if( ! $response->is_valid ) {		
		//
		// captcha failed -- display the error message
		//
		//	change this to whatever message you want to display. you could even perform other form validations
		//	and display messages about other required fields, etc., here if you want.
		//	use the CSS in the <head> section above to determine how your error message "box" will appear.
		//
		echo '<div id="recaptcha_error_box">The reCAPTCHA failed with this message: '.$response->error.'<br />Please try again.</div>';
		// by default now, let the flow-of-control fall back into the <form> below so the user can try again
	}
	else {
		//	set $validated to true so we know later in our document not to show the form again
		//	don't change this.
		$validated = true;
		//
		//	YOUR CODE HERE....
$to = 'me@me.com';  

$subject = 'Email query from me.com';    

$message = "Email sent from: $email \n $yourname has sent you a message:- \n $message"; 
$headers = 'From: queries@me.com' . "\r\n" . 
'Reply-To: queries@me.com' . "\r\n" . 
'X-Mailer: PHP/' . phpversion(); 
mail($to, $subject, $message, $headers) or exit('mail FAIL');  

			//
			// at this point, th form was submitted with valid reCAPTCHA, so go do whatever you wanted to do.
			// for the demo, we'll just echo back the values from the form.
			//
			//	you could also send an email message, add or update database records, etc.
			//
?>
<p>The reCAPTCHA successfully validated! Here is the information you provided:</p>

<p>Name:</p>
<strong><?php echo stripslashes(htmlentities($_POST['your_name'])); ?></strong></p>
<p">Email:</p>
<p><?php echo stripslashes(htmlentities($_POST['your_email'])); ?></strong></p>
<p>reCAPTCHA:</p>
<p><strong>Validated Successfully</strong></p>

<?php
}	/* end if( ! is_valid ) */
} /* end if($_POST['validate']==='yes') */ 
?>	 

<?php if( ! $validated ) { ?>

<p>The demo form begins here:</p>

<form method="post">

<p>Your Name:</p>
<input name="your_name" value="<?php echo stripslashes(htmlentities($_POST['your_name'])); ?>" />

<p>Your Email:</p>
<input name="your_email" value="<?php echo stripslashes(htmlentities($_POST['your_email'])); ?>" />

<?php echo recaptcha_get_html(API_PUBLIC_KEY); ?>
<input type="hidden" name="validate" value="yes" />
<input type="submit" value="Try It" />
</form>
<?php } /* end if( ! $validated ) */ ?>

Tom 🙂

djjjozsi

Hi!

firstly:

$message = "Email sent from: $email \n $yourname has sent you a message:- \n $message";

In this code i cannot see where you have made pairs the form variables with PHP global variables?

Use the $_POST array to grab your input values.

Derokorian

$message = "Email sent from: $email \n $yourname has sent you a message:- \n $message";

At no point is $email,$yourname, or $message ever defined, so the parser has nothing to insert there. If you had error_reporting set to E_ALL you would have gotten 3 undefined variables here. You prolly want to use $POST['your_email'] and $POST['your_name'] however there is not an input for message so I'm not sure where you expected this variable from.

tomkilbourn

Ive added the $your_name, $your_email and $your_message variables and added "your_message" to the form section of code -

<?php
//Currently sending blank emails
	// DEMO to use reCAPTCHA library on a form
	//
	//	courtesy Spectrum Nashville
	//	http://www.spectrum-nashville.com
	//	
	//  provide the Public Key and Private Key for your account here:

define( API_PUBLIC_KEY, xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' );
define( API_PRIVATE_KEY, '6LdjT8oSAAAAAKHnjGBhoxxxxxxxxxxxxxxx'  );

//
//	once the keys have been provided above, this demo should work without any further changes to the code below
//
//	include the recaptcha library file here
//
require_once('recaptchalib.php');
//
//	the $validated variable will switch to true in the code below if a valid CAPTCHA is submitted (see code below).
//	do not change this.
//
$validated = false;
?>

<?php 
	// 

//
//	see the form below and look for the hidden input named 'validate' to see how this works. This is a nice flag to
//	indicate to us that the validation should be attempted. The first time a user browses to this page, there will be
//	no 'validate' variable in the $_POST[] array, so no validation is attempted and no error message will be generated.
//
//	do not change any of this code.
//
if( $_POST['validate'] === 'yes' ) { 
	$response = recaptcha_check_answer( API_PRIVATE_KEY,
	$_POST['your_email'] ,
	$_POST['your_name'],
	$_POST['your_message'],
	$_SERVER['REMOTE_ADDR'],
	$_POST['recaptcha_challenge_field'],
	$_POST['recaptcha_response_field']
										);

	if( ! $response->is_valid ) {		
		//
		// captcha failed -- display the error message
		//
		//	change this to whatever message you want to display. you could even perform other form validations
		//	and display messages about other required fields, etc., here if you want.
		//	use the CSS in the <head> section above to determine how your error message "box" will appear.
		//
		echo '<div id="recaptcha_error_box">The reCAPTCHA failed with this message: '.$response->error.'<br />Please try again.</div>';
		// by default now, let the flow-of-control fall back into the <form> below so the user can try again
	}
	else {
		//	set $validated to true so we know later in our document not to show the form again
		//	don't change this.
		$validated = true;
		//
		//	YOUR CODE HERE....
$to = 'tomkilbourn1976@hotmail.com';  

$subject = 'Email query from tomkilbourn.com';    

$your_message = "Email sent from: $email \n $your_name has sent you a message:- \n $your_message"; 
$headers = 'From: queries@tomkilbourn.com' . "\r\n" . 
'Reply-To: queries@tomkilbourn.com' . "\r\n" . 
'X-Mailer: PHP/' . phpversion(); 
mail($to, $subject, $your_message, $headers) or exit('mail FAIL');  

			//
			// at this point, th form was submitted with valid reCAPTCHA, so go do whatever you wanted to do.
			// for the demo, we'll just echo back the values from the form.
			//
			//	you could also send an email message, add or update database records, etc.
			//
?>
<p>The reCAPTCHA successfully validated! Here is the information you provided:</p>

<p>Name:</p>
<strong><?php echo stripslashes(htmlentities($_POST['your_name'])); ?></strong></p>
<p">Email:</p>
<p><?php echo stripslashes(htmlentities($_POST['your_email'])); ?></strong></p>
<p>reCAPTCHA:</p>
<p><strong>Validated Successfully</strong></p>

<?php
}	/* end if( ! is_valid ) */
} /* end if($_POST['validate']==='yes') */ 
?>	 

<?php if( ! $validated ) { ?>

<p>The demo form begins here:</p>

<form method="post">

<p>Your Name:</p>
<input name="your_name" value="<?php echo stripslashes(htmlentities($_POST['your_name'])); ?>" />

<p>Your Email:</p>
<input name="your_email" value="<?php echo stripslashes(htmlentities($_POST['your_email'])); ?>" />

<p>Your Message:</p>
<input name="your_message" value="<?php echo stripslashes(htmlentities($_POST['your_message'])); ?>" />

<?php echo recaptcha_get_html(API_PUBLIC_KEY); ?>
<input type="hidden" name="validate" value="yes" />
<input type="submit" value="Try It" />
</form>
<?php } /* end if( ! $validated ) */ ?>

..but when I submit the form Im getting the message "For security reasons, you must pass the remote ip to reCAPTCHA". But I have the keys, and the recaptchalib.php file uploaded.

Any ideas?

tomkilbourn

This is where Im up to, the form is sending, the captcha and captcha messages are working, but Im still recieving blank emails -

<?php
 $errors = null;  

//Currently sending blank emails
	// DEMO to use reCAPTCHA library on a form
	//
	//	courtesy Spectrum Nashville
	//	http://www.spectrum-nashville.com
	//	
	//  provide the Public Key and Private Key for your account here:
	require_once('recaptchalib.php'); 
$publickey = ""; // you got this from the signup page  

$privatekey = ""; 

//
//	once the keys have been provided above, this demo should work without any further changes to the code below
//
//	include the recaptcha library file here
//

//
//	the $validated variable will switch to true in the code below if a valid CAPTCHA is submitted (see code below).
//	do not change this.
//

// 

//
//	see the form below and look for the hidden input named 'validate' to see how this works. This is a nice flag to
//	indicate to us that the validation should be attempted. The first time a user browses to this page, there will be
//	no 'validate' variable in the $_POST[] array, so no validation is attempted and no error message will be generated.
//
//	do not change any of this code.
//
if (isset($_POST['submit']))  
{   

$yourname = $_POST['yourname'];  

$email = $_POST['email'];  

$message = $_POST['message']; 
$response = recaptcha_check_answer ($privatekey, 
$_SERVER["REMOTE_ADDR"], 
$_POST["recaptcha_challenge_field"], 
$_POST["recaptcha_response_field"]); 

	if( ! $response->is_valid ) {		
		//
		// captcha failed -- display the error message
		//
		//	change this to whatever message you want to display. you could even perform other form validations
		//	and display messages about other required fields, etc., here if you want.
		//	use the CSS in the <head> section above to determine how your error message "box" will appear.
		//
		echo '<div id="recaptcha_error_box">The reCAPTCHA failed with this message: '.$response->error.'<br />Please try again.</div>';
		// by default now, let the flow-of-control fall back into the <form> below so the user can try again
	}
	else {
		//	set $validated to true so we know later in our document not to show the form again
		//	don't change this.
if(count($errors)==0){ 
		//
		//	YOUR CODE HERE....
$to = 'tomkilbourn1976@hotmail.com';  

$subject = 'Email query from tomkilbourn.com';    

$message = "Email sent from: $email \n $yourname has sent you a message:- \n $message"; 
$headers = 'From: queries@tomkilbourn.com' . "\r\n" . 
'Reply-To: queries@tomkilbourn.com' . "\r\n" . 
'X-Mailer: PHP/' . phpversion(); 
mail($to, $subject, $your_message, $headers) or exit('mail FAIL');  

			 echo '<p>3) Thank you for emailing me! Your Message has been sent.</p>';
			// at this point, th form was submitted with valid reCAPTCHA, so go do whatever you wanted to do.
			// for the demo, we'll just echo back the values from the form.
			//
			//	you could also send an email message, add or update database records, etc.
			//
	}
?>


<?php
}	/* end if( ! is_valid ) */
} /* end if($_POST['validate']==='yes') */ 
?>	 

<?php if( ! $validated ) { ?>

<p>The demo form begins here:</p>
<form id="tomsform" method="POST" action="demo.php"> 
<p>Name</p> 
<input type="text" name="yourname" size="19" value="<?php echo (isset($yourname)) ? $yourname : '';?>" class="textbox"> 
<?php 
if(isset($errors['yourname'])) echo $errors['yourname']; 
?> 
<br> 
<p>Email Address</p> 
<input type="text" name="email" size="19" value="<?php echo (isset($email)) ? $email : '';?>" class="textbox"> 
<?php 
if(isset($errors['email'])) echo $errors['email']; 
?> 
<br> 
<p>Message</p> 
<textarea rows="9" name="message" cols="30" class="textbox"><?php echo (isset($message)) ? $message: '';?></textarea> 
<br> 
<br> 
<?php echo recaptcha_get_html($publickey, $errors); ?>  

<input type="submit" value="Submit" name="submit" class="go"> 
</form>
<?php } /* end if( ! $validated ) */ ?>

tomkilbourn

I think I have cracked it, could someone take a look at the code and see what they think?

<?php
 $errors = null;  

//Currently sending blank emails

require_once('recaptchalib.php'); 
$publickey = "xxxxxxxxxxxxxxxxxx"; // you got this from the signup page  

$privatekey = "xxxxxxxxxxxxxxxxxxxxxxxxx"; 


if (isset($_POST['submit']))  

{   

$yourname = $_POST['yourname'];  

$email = $_POST['email'];  

$message = $_POST['message']; 
$response = recaptcha_check_answer ($privatekey, 
$_SERVER["REMOTE_ADDR"], 
$_POST["recaptcha_challenge_field"], 
$_POST["recaptcha_response_field"]); 

	if( ! $response->is_valid ) {		

		echo '<div id="recaptcha_error_box">The reCAPTCHA failed with this message: '.$response->error.'<br />Please try again.</div>';
		// by default now, let the flow-of-control fall back into the <form> below so the user can try again
	}
	else {
		//	set $validated to true so we know later in our document not to show the form again
		//	don't change this.
if(count($errors)==0){ 
		//
		//	YOUR CODE HERE....
$to = me@me.com';  

$subject = 'Email query from me.com';    

$message = "Email sent from: $email \n $yourname has sent you a message:- \n $message"; 
$headers = 'From: queries@me.com' . "\r\n" . 
'Reply-To: queries@me.com' . "\r\n" . 
'X-Mailer: PHP/' . phpversion(); 
mail($to, $subject, $message, $headers) or exit('mail FAIL');  

			 echo '<p>3) Thank you for emailing me! Your Message has been sent.</p>';
			// at this point, th form was submitted with valid reCAPTCHA, so go do whatever you wanted to do.
			// for the demo, we'll just echo back the values from the form.
			//
			//	you could also send an email message, add or update database records, etc.
			//
	}
?>


<?php
}	/* end if( ! is_valid ) */
} /* end if($_POST['validate']==='yes') */ 
?>	 

<?php if( ! $validated ) { ?>

<p>The demo form begins here:</p>
<form id="tomsform" method="POST" action="demo.php"> 
<p>Name</p> 
<input type="text" name="yourname" size="19" value="<?php echo (isset($yourname)) ? $yourname : '';?>" class="textbox"> 
<?php 
if(isset($errors['yourname'])) echo $errors['yourname']; 
?> 
<br> 
<p>Email Address</p> 
<input type="text" name="email" size="19" value="<?php echo (isset($email)) ? $email : '';?>" class="textbox"> 
<?php 
if(isset($errors['email'])) echo $errors['email']; 
?> 
<br> 
<p>Message</p> 
<textarea rows="9" name="message" cols="30" class="textbox"><?php echo (isset($message)) ? $message: '';?></textarea> 
<?php 
if(isset($errors['message'])) echo $errors['message']; 
?> 
<br> 
<br> 
<?php echo recaptcha_get_html($publickey, $errors); ?>  

<input type="submit" value="Submit" name="submit" class="go"> 
</form>
<?php } /* end if( ! $validated ) */ ?>

djjjozsi

in this line, you missed the starting apostrofe ( after API_PUBLIC_KEY, )

  define( API_PUBLIC_KEY, xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' );

never post private keys on forums, with this information hackers easily pass your captcha!

djjjozsi

do you think these values always filled? If i don't fill a mandatory field, like my email, you will et an emty message.

$yourname = $_POST['yourname'];  

$email = $_POST['email'];  

$message = $_POST['message'];

You should use if and isset and strlen to get if these values have been filled or not.

tomkilbourn

Form validation, is the next step!

🙂