highlight_string

[joane1]

hi, in my bbcode I hace an array in wich I find a code and I replace it with html code.

$find = array(
...
...
'{[code](\r\n|\r|\n)*(.+)

}'):

$replace = array(
...
...
'<pre>\2</pre>');
[/code]

Now, I want to highlighting the code and I edit in this way:

$find = array(
...
...
'{[code](\r\n|\r|\n)*(.+)

}'):

function highstring($a) {
$split = "SPLIT";
$a = explode($split, highlight_string("<?php $split$replace[2]$split ?>", true));

        return '<pre>' . $a[1] . '</pre>';

}

$replace = array(
...
...
"highstring('\2')";

[/code]
but doesn't work. Where is wrong?

[Derokorian]

I may be wrong, but I don't think you can put a function call in the replace like that. For my BBCode I use preg_match to create the find value, then I process that value to make the replacement value. Here is my code, its part of a class I made (if you'd like to see the class as it stands now just ask) but I hope it helps you understand what I mean:

<?php

class BBCodes {
	private $PHPreplace = array();
	private $str;

const PHPPattern = '#\[PHP\](.+?)\[\/PHP\]#is';

/**
 * fullClean parses ALL BBCodes of the given string
 */
public function fullClean($input) {
	$this->str = $input;
	$this->PHPFind();
	// Lots of other BBCode processing here
	$this->PHPReplace();
	return $this->str;
}

private function PHPFind() {
	//*/ Set up replace array for PHP tags
	if( preg_match_all(self::PHPPattern,$this->str,$matches) ) {
		foreach( $matches[1] as $k => $v ) {
			$this->PHPreplace[$k] = '<div class="code">'.$this->PHPHighlight($v).'</div>';
		}
	}
}

private function PHPHighlight($str) {
	//*/ Highlights a string using highlight_string after checking for use of opening tags
	$added = FALSE;
	$firstopen = strpos($str,'<?php');
	$firstclose = strpos($str,'?>');
	if( $firstopen === FALSE ) {
		$str = '<?php '.$str;
		$added = TRUE;
	} elseif( $firstclose !== FALSE && $firstclose < $firstopen ) {
		$str = '<?php '.$str;
		$added = TRUE;
	}
	$str = highlight_string($str,TRUE);
	if( $added === TRUE ) {
		$open = substr($str,0,37);
		$close = substr($str,87);
		$str = $open.$close;
	}
	return $str;
}

private function PHPReplace() {
	//*/ Set up replace array for PHP tags (post BB filtering, so the BB tags don't get changed when IN php code)
	if( preg_match_all(self::PHPPattern,$this->str,$matches) ) {
		foreach( $matches[0] as $k => $v ) {
			$PHPfind[$k] = $v;
		}
		//*/ Replace PHP tags + containing strings with highlighted version
		$this->str = str_replace($PHPfind,$this->PHPreplace,$this->str);
		foreach( $this->PHPreplace as $k => $v ) {
			unset($this->PHPreplace[$k]);
		}
	}
}

[joane1]

Derokorian;10991629 wrote:

I may be wrong, but I don't think you can put a function call in the replace like that.

why not? your code is a bit complicated for me.

I use a similar thing and it works:

function GetImage($img) {
    list($width, $height, $type, $attr) = @getimagesize($img);
        return ' <img src="' . $img . '" ' . $attr . ' title="photo" />';
}

and in array

$replace = array( 
... 
... 
"imgResize('\\2')",
...

Can you help me to resolve, if possibile, with a similar way?

[Derokorian]

Have you tried it on its own, and not being part of the array? This is how I develop, get each part working on its own, then combine them. Also your response doesn't make sense to me as the 2 code snippets you provided seem to have no correlation to each other, or I'm missing something. But if your saying that a different part is working with a function call in the replace, then I have no idea why it wouldn't be working. I would suggest taking it out and doing it separate until it works as intended. Then input the working regex + replacement into the arrays.

[joane1]

i tried the highstring() its own and it works fine.
i can't combine my function and the array...

[Derokorian]

By on its own, are you saying you did something like this:

preg_replace('{[code](\r\n|\r|\n)*(.+)

}',"highstring('\2')",$str);
[/code]
and it works as expected, or are you saying the function on its own works? If you did something like the snippet, would you mind showing the full code that's not working in arrays?

[joane1]

here the full code:

function MyFunction() {

$find = array(
        '{\[email\](\r\n|\r|\n)*([a-zA-Z0-9\._-]+@(([a-zA-Z0-9_-])+\.)+[a-z]{2,4})\[/email\]}siU',
        '{\[quote\](\r\n|\r|\n)*(.+)\[/quote\]}siU',
        '{\[code\](\r\n|\r|\n)*(.+)\[/code\]}siU'
        );

$replace = array(
        '<a href="mailto:\\2">\\2</a>',
        '<div style="background-color:#EEEEEE;">\\2</div>',
        '<div style="background-color:#FFFFFF;"><pre>\\2</pre></div>'
        );

$mytext = preg_replace($find, $replace, $mytext);
}

[Weedpacket]

If you want to use a function call as the replacement value there are two approaches:

1. Add the "e" modifier to the pattern. Then after substituting matches the replacement string will effectively be run through [man]eval[/man]. But this is ugly and hairy and all the other bad stuff that goes with eval. So the alternative is

2. Use [man]preg_replace_callback[/man] and name the function that the matches will be passed to (or, starting in PHP 5.3, explicitly define an (anonymous) function in-place.)

[joane1]

i tried in this way:

function MyFunction() {

$find = array(
        '{\[email\](\r\n|\r|\n)*([a-zA-Z0-9\._-]+@(([a-zA-Z0-9_-])+\.)+[a-z]{2,4})\[/email\]}siU',
        '{\[quote\](\r\n|\r|\n)*(.+)\[/quote\]}siU',
        '{\[code\](\r\n|\r|\n)*(.+)\[/code\]}siU'
        );

function highstring() {
    $split = "SPLIT";
    $a = explode($split, highlight_string("<?php $split$find[2]$split ?>", true));
    return preg_replace_callback($find, create_function("$find[2]","<pre>$a[1]</pre>"), $a[1]);
    } 


$replace = array(
        '<a href="mailto:\\2">\\2</a>',
        '<div style="background-color:#EEEEEE;">\\2</div>',
        "highstring('\\2')"
        );

$mytext = preg_replace($find, $replace, $mytext);
} 

but without success.

[Weedpacket]

Two reasons for that: your created function doesn't return a value, and the first argument to create_function() is supposed to contain the names of the variables the created function uses. What you're creating is equivalent to writing

function anonymous($find[2])
{
   "<pre>$a[1]</pre>";
}

Which isn't going to work at all. (Incidentally, since PHP 5.3, you could write the function directly, without using create_function()).

Going back to what you had originally:

$find = array(
...
...
'{[code](\r\n|\r|\n)*(.+)

}'):

$replace = array(
...
...
'<pre>\2</pre>'); [/code]
You want the function called by preg_replace_callback to take the second reference and return the highlighted version. So a function that does something like this:

function code_tag_callback($match)
{
// Strictly speaking, you shouldn't need the <pre>,
// since highlight_string() already returns its results
// wrapped in the more meaningful <code> tags.
    return '<pre>' . highlight_string($match[2]) . '</pre>';
}

Now you could use create_function() here, but since it's going to do the same thing every time it's called it's more efficient all round to just create it once as an ordinary function and use it. I called it "code_tag_callback()" up there, so the preg_replace_callback call would be

preg_replace_callback('{[code](\r\n|\r|\n)*(.+)

}', 'code_tag_callback', $whatever)[/code]

[joane1]

I do not think I've got it right.
The code:

function MyFunction() {

$find = array(
        '{\[email\](\r\n|\r|\n)*([a-zA-Z0-9\._-]+@(([a-zA-Z0-9_-])+\.)+[a-z]{2,4})\[/email\]}siU',
        '{\[quote\](\r\n|\r|\n)*(.+)\[/quote\]}siU',
        '{\[code\](\r\n|\r|\n)*(.+)\[/code\]}siU'
        );

function code_tag_callback($find) {
	$split = "SPLIT";
    $a = explode($split, highlight_string("<?php $split$find[2]$split ?>", true));
    return '<pre>' . highlight_string($find[2]) . '</pre>';
}

$replace = array(
        '<a href="mailto:\\2">\\2</a>',
        '<div style="background-color:#EEEEEE;">\\2</div>',
        "preg_replace_callback('{[code](\r\n|\r|\n)*(.+)

}', 'code_tag_callback', $mytext)"
);

$mytext = preg_replace($find, $replace, $mytext);
}
[/code]

Be patient...

[johanafm]

"preg_replace_callback('This will do nothing since it's a string, not a function call')";

preg_replace_callback('Will look for this pattern', 'and_call_this_function', 'searching in this text');

Other than that, $mytext is not defined, so there is nothing to be found. But this should give you a warning. Turn on error reporting / logging and set error_reporting to E_ALL and you will get needed information like this.

[joane1]

the code edited:

function MyFunction() {

$find = array(
        '{\[email\](\r\n|\r|\n)*([a-zA-Z0-9\._-]+@(([a-zA-Z0-9_-])+\.)+[a-z]{2,4})\[/email\]}siU',
        '{\[quote\](\r\n|\r|\n)*(.+)\[/quote\]}siU',
        '{\[code\](\r\n|\r|\n)*(.+)\[/code\]}siU'
        );

function code_tag_callback($find) {
    $split = "SPLIT";
    $a = explode($split, highlight_string("<?php $split$find[2]$split ?>", true));
    return '<pre>' . highlight_string($find[2]) . '</pre>';
}

$replace = array(
        '<a href="mailto:\\2">\\2</a>',
        '<div style="background-color:#EEEEEE;">\\2</div>',
        "preg_replace_callback('[code](\r\n|\r|\n)*(.+)

', 'code_tag_callback', $find[2])"
);

$mytext = preg_replace($find, $replace, $mytext);
}
[/code]

simply, it returns printed in page:

preg_replace_callback('[ code]( | | )*(.+)[/ code]', 'code_tag_callback', {\[ code\](\r\n|\r|\n)*(.+)\[/ code\]}siU)

[johanafm]

This

"preg_replace_callback('[code](\r\n|\r|\n)*(.+)

', 'code_tag_callback', $find[2])"
[/code]
is still nothing but a string. As far as PHP is concerned, it's not different from

"hello world"

[joane1]

i understand what you say but i don't know how to apply it to my code...

[johanafm]

Remove the string delimiters so it's treated as code instead of a string. It's the exact same thing as the difference between these

"echo 'This will output nothing. The entire line is a string literal. There will be no side effects at all such as output of any kind. But it is till perfectly ok for the PHP parser.'";

echo 'This will output something because the echo statement deals with writing the string literal FOLLOWING the echo keyword to the output stream. But this time the echo keyword is NOT part of the string literal!';

You may also note the difference in the color used for "echo" on the first line and the last line. One is red (string literal), the other is green (PHP keyword / language construct).