paging php same results after next

xextra

hello... Im not sure what im doing wrong exactly.. but when i click next it will say 20 30 etc in the browser address but it won't show the correct items... it shows the same as the first page even though there is only 25 records.. heres my code -

<?php include "header.php";?>
				<?php

			@ $db = mysql_pconnect($mysql['host'], $mysql['user'], $mysql['pass']);

			if (!$db)
			{
				die("error");
			}
			mysql_select_db($mysql['db']);


			$query = "SELECT * FROM images LIMIT 0, 10";


			$result = mysql_query($query);

			$num_results = mysql_num_rows($result);
			for ($i = 0; $i < $num_results; $i++)
			{
				$row = mysql_fetch_array($result);
				$id = $row['id'];
				echo '<img src="uploads/' . $id . '" border="1"><br>';


			}


if (!isset($_GET['startrow']) or !is_numeric($_GET['startrow'])) {

  $startrow = 0;

} else {
  $startrow = (int)$_GET['startrow'];
}


$fetch = mysql_query("SELECT * FROM images LIMIT $startrow, 10")or
die(mysql_error());




echo '<a href="'.$_SERVER['PHP_SELF'].'?startrow='.($startrow+10).'">Next</a>';


$prev = $startrow - 10;


if ($prev >= 0)
    echo '<a href="'.$_SERVER['PHP_SELF'].'?startrow='.$prev.'">Previous</a>';

?>


<?

include "footer.php";
?>

Any pointers would greatly be appreciated.

dagon

the only query you use results from is:

$query = "SELECT * FROM images LIMIT 0, 10";

xextra

do I need to remove it ? Or do I need to add in more code somewhere? ha im a complete newbie to this side...

bradgrafelman

Well that code tells MySQL to always retrieve 10 results starting from #0. If you want pagination to happen, then you'll have to actually implement it.

Search the board for numerous examples, but the idea is all the same - you'll want to tell MySQL which 10 rows you want it to return (meaning your page number, or whatever unit you're using, should be used to increase 0 to the correct number).

xextra

Thank you for your help so far with this.. I'm still a bit lost here. So I'm missing code correct? Or I did my code incorrectly? I will begin to search shortly.

xextra

I tried looking around on the forums.. Maybe I am searching for the incorrect english words.. Could someone please point out what lines may be wrong? Or a site or program that is helpful for newbies like me.. please

Is this a incorrect line in the code ?
$startrow = 0

johanafm

You presently have a limit of 0, 10, which means 10 rows are retrieved, which in turn means 10 results per page. So for every page into the set that is requested, you need to increment the starting position by 10 * pagenumber.

# Instead of 0, 10
$startpos = $pagenumber * 10;
$limit = "$startpos, 10";

xextra

I understand what your saying about the 10... But when i try to change the code I keep getting nothing but errors or it doesnt seem to work correctly. My english is horrible.. And its hard for me to say the right thing to make things more understandable... but by the sounds of it. I am missing a few lines of code.

johanafm

You have code and errors? Where are they?

xextra

no no error... Im kind of starting from the begining again... I just have forgotten way to much.. brain damage is a pain.. Anywho.. I will come back to this sometime in the future..