Function with 2 argument error

[__NEW__]

Hi , I write this function for count rows. but this not work for me.

function ctab($table,$uid){
     $sql = mysql_query("SELECT COUNT(*) rowcount FROM $table WHERE uid=$uid;");
     $sql = mysql_fetch_array($sql); // mysql_fetch_array or assoc ?
return $sql[0];

For Display :

echo ctab("perum,2"); // perum is Mysql table and 2 is user id

this Function is Best and Fast For Count Rows ?

NOTE : im new php coder. im so sorry IF my question is simple;

[bradgrafelman]

First problem I see is your function call:

ctab("perum,2")

That's calling the ctab() function and passing only one argument. That single argument is the seven-character string "perum,2". Instead, you should be passing two separate arguments (which I'm guessing are the string "perum" and the integer 2, respectively).

[__NEW__]

Oh Thanks bradgrafelman, i change this to This and worked :

ctab("perum","2");

mysql_fetch_assoc Better Or mysql_fetch_array ? i know assoc faster array!

This function is good,bad, .... ?! whats your vote?

[johanafm]

Read the documentation for [man]mysql_fetch_assoc[/man] and [man]mysql_fetch_array[/man]. One returns an associtive array, the other can return an associative array, an array with numerical indices or an array which has both numerical and associative indices.

A little extra work would be needed for the "both" case. Other than that, if you select two columns with identical identifiers, you'd need a numerical array to reference them both (since one would be overwritten by the other in an associative array), but you could also instead provide aliases to differentiate between them using an associative array.

In my opinion, an associative array is always better to use since $row['name'] provides a lot more information when reading the code than $row[12].

[__NEW__]

johanafm, I agree your opinion, Thanks. whats your vote to this function ?

[Weedpacket]

Irrelevant: you use whichever is best in your situation - whatever that happens to be at the time. This is programming, not a democracy.