[RESOLVED] mysql update statement

vang

hi,

I'm having some problem with this function. Pls help, thanks.

function dbUpdate($table, $fieldname, $values, $match, $id)
{
$fieldname = implode("," , $fieldname);
$data = implode("," , $values);

$sql = "UPDATE $table SET ($fieldname = $data) WHERE $match = $id";
$res = mysql_query($sql) or die('error');

}

execution:
$fieldnames = array(code, name, status);
$values = array('test2', 'test456', 'TP');

dbUpdate(item, $fieldnames, $values, id, 19);

bradgrafelman

Echo out $sql prior to executing it and I think you'll find why it isn't working.

Furthermore, where do you properly sanitize/prepare the values for use in a SQL query?

EDIT: Also, when posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

Bonesnap

First, what's the problem? You haven't told us what the actual issue is.

Second, right off the bat I can see there's a problem here:

dbUpdate(item, $fieldnames, $values, id, 19);

You have two variables without the dollar sign, and I'm going to go out on a limb and assume they're not constants. If they're intended to be strings then enclose them in quotes.

Same issue here:

$fieldnames = array(code, name, status);

Were you programming in JavaScript right before writing this function? 😉

vang

Hi,

I'm getting this:

UPDATE item SET (code,name,status = test2,test456,TP) WHERE id = 19

bradgrafelman

Yes, I realize that based on the code you showed us. Does that not look seriously wrong to you? If not, you might want to read the MySQL manual page for the UPDATE query to learn what the proper syntax is.

vang

thanks 🙂