[RESOLVED] Pagination problem

[akmal1981]

Dear experts,

I've read various solutions on the error undefined index in google but i still couldnt figured out what is wrong with my code.

The original code (line 4,5, and 6) was running just fine until I included pagination code inside 🙁

Notice: Undefined index: type in C:\xampp\htdocs\cimb10\getlocationxyz.php on line 4

Notice: Undefined index: location in C:\xampp\htdocs\cimb10\getlocationxyz.php on line 5

Notice: Undefined index: price in C:\xampp\htdocs\cimb10\getlocationxyz.php on line 6

i've been pulling my hair trying to figure out what's wrong and included isset as advised in other websites , but still 😕 please please help

<?php 


$gType=$_GET['type'];
$gLocation = $_GET['location'];
$gPrice = $_GET['price'];

$con = mysql_connect('localhost', 'root', ''); 
if (!$con) { 
	die('Could not connect: ' . mysql_error()); 
} 

include 'paginationconnect.php';

$per_page = 2;  

$pages_query = mysql_query("SELECT COUNT(*) FROM property");
$pages = ceil(mysql_result($pages_query,0)/$per_page);   

$page = (isset($_GET['page'])) ? (int)$_GET['page'] : 1;
$start = ($page-1)*$per_page; 

mysql_select_db("a_database", $con); 

if ($gType == "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property LIMIT $start,$per_page";

} else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' and price='" . $gPrice ."' LIMIT $start,$per_page";

} else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and price='" . $gPrice ."' LIMIT $start,$per_page";

} else if($gType <> "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and location='" . $gLocation ."' LIMIT $start,$per_page";
} 

      else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' LIMIT $start,$per_page";
} 

      else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' LIMIT $start,$per_page";
} 

      else if($gType == "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where price='" . $gPrice . "' LIMIT $start,$per_page";
} 

     else {
	$sql = " SELECT Type,Price1,Location FROM property where type='" .$gType . "' and location='" . $gLocation . "' and price='" . $gPrice . "' LIMIT $start,$per_page" ;
}


$result = mysql_query($sql); 
echo "<table border='1'> <tr> <th>Type</th> <th>Price</th> <th>Location</th> </tr>"; 

while($row = mysql_fetch_array($result)) { 
	echo "<tr>"; 
	echo "<td>" . $row['Type'] . "</td>"; 
	echo "<td>" . $row['Price1'] . "</td>"; 
	echo "<td>" . $row['Location'] . "</td>"; 
	echo "</tr>"; }    

	echo "</table>"; 

if($pages >=1 && $page<= $pages){

for($x=1;$x<=$pages;$x++)  {

echo ($x == $page) ? '<strong><a href="?page='.$x.'">'.$x.'</a> </strong>' : '<a href="?page='.$x.'">'.$x.'</a> ' ;

}}

	mysql_close($con); 

?>

[akmal1981]

i read something about repressing the notice but im not sure whether this is good idea ??

really really appreciate if someone could give tips for the problem above.

[Bonesnap]

The three GET variables don't exist. Where are these values coming from?

[akmal1981]

Hi Bonesnap,

the values come from columns named 'type' , 'location' and 'price' from 'property' table.

errr i hope that explains ? sorry im noob at programming im not sure i've answered your question.

prior to adding the pagination codes, there were no error/notice on the three GET variables. So, I dont understand when you explained the GET variables dont exist 🙁

Basically my codes have 3 dropdown menus (property type, price and location) which will call data from 'property' table. All was working fine until I just added pagination into this php file.

[akmal1981]

i've also tested the pagination code separately in other file (and it was working ok) before incorporating the code into getlocationxyz.php above (which then went haywire)

[akmal1981]

dear all,

i went through the lines again.

The notice / error wont appear until i added additional codes of pagination (see line 124 onwards). Please , any tips ? 😕

<?php 




$gType = $_GET['type'];
$gLocation = $_GET['location'];
$gPrice = $_GET['price'];


echo $gType; 
echo $gLocation;
echo $gPrice;

/*database connection here*/

$con = mysql_connect('localhost', 'root', ''); 
if (!$con) { 
	die('Could not connect: ' . mysql_error()); 
} 

mysql_select_db("a_database", $con); 

/*find how many rows in the table*/

$sql = "SELECT count(*) FROM property";
$result = mysql_query($sql,$con) or trigger_error("SQL",E_USER_ERROR);
$r=mysql_fetch_row($result);
$numrows = $r[0];

// number of rows to show per page
   $rowsperpage = 2;
// find out total pages
   $totalpages = ceil($numrows/$rowsperpage);

   echo $totalpages;

// get the current page or set a default

	if(isset($_GET['currentpage']) && is_numeric($_GET['currentpage'])) {
	$currentpage=(int) $_GET['currentpage'];
	} else {
	$currentpage=1;
	}

	echo $currentpage;

// if current page is greater than total pages, set current page to last page
if($currentpage > $totalpages) {
$currentpage = $totalpages;
}

// if current page is less than first page
if ($currentpage < 1) {
$currentpage = 1;
}

// offset of the list based on current page
$offset = ($currentpage-1)*$rowsperpage;

echo $offset;


// get info from database

if ($gType == "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property LIMIT $offset,$rowsperpage";

} else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' and price='" . $gPrice ."' LIMIT $offset,$rowsperpage";

} else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and price='" . $gPrice ."' LIMIT $offset,$rowsperpage";

} else if($gType <> "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and location='" . $gLocation ."' LIMIT $offset,$rowsperpage";
} 

      else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' LIMIT $offset,$rowsperpage";
} 

      else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' LIMIT $offset,$rowsperpage";
} 

      else if($gType == "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where price='" . $gPrice . "' LIMIT $offset,$rowsperpage";
} 

     else {
	$sql = " SELECT Type,Price1,Location FROM property where type='" .$gType . "' and location='" . $gLocation . "' and price='" . $gPrice . "' LIMIT $offset,$rowsperpage" ;
}



echo $sql;

$result = mysql_query($sql); 

echo $result;

echo "<table border='1'> <tr> <th>Type</th> <th>Price</th> <th>Location</th> </tr>"; 
while($row = mysql_fetch_array($result)) { 
	echo "<tr>"; 
	echo "<td>" . $row['Type'] . "</td>"; 
	echo "<td>" . $row['Price1'] . "</td>"; 
	echo "<td>" . $row['Location'] . "</td>"; 
	echo "</tr>"; } 
	echo "</table>"; 
	mysql_close($con); 

// build the pagination link
// range of num links to show
$range = 3;

// if not on page 1, dont show back links
if ($currentpage > 1) {
echo "<a href = '{$_server['PHP_SELF']}?currentpage=1'><<</a>";
$prevpage = $currentpage-1;
echo "<a href='{$_server['PHP_SELF']}?currentpage=$prevpage'><</a>";
}

//	 ERROR STARTS HERE   WHYYYYYYYYYY ?????????
// loop to show links to range of pages around current page

for ($x = ($currentpage - $range); $x < (($currentpage + $range) + 1); $x++) {
   // if it's a valid page number...
   if (($x > 0) && ($x <= $totalpages)) {
      // if we're on current page...
      if ($x == $currentpage) {
         // 'highlight' it but don't make a link
         echo " [<b>$x</b>] ";
      // if not current page...
      } else {
         // make it a link
         echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$x'>$x</a> ";
      } // end else
   } // end if 
} // end for



// if not on last page, show forward and last page links        

if ($currentpage != $totalpages) {
   // get next page
   $nextpage = $currentpage + 1;
    // echo forward link for next page 
   echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$nextpage'>></a> ";
   // echo forward link for lastpage
   echo " <a href='{$_SERVER['PHP_SELF']}?currentpage=$totalpages'>>></a> ";
} // end if


?>

[bradgrafelman]

Look at your links:

echo "<a href = '{$_server['PHP_SELF']}?currentpage=1'><<</a>"; 

First problem: where do you define the variable $_server?

Second problem, look at the very beginning of your script:

    $gType = $_GET['type']; 
    $gLocation = $_GET['location']; 
    $gPrice = $_GET['price']; 

What happens to these three parameters once one of your pagination links is clicked?

[akmal1981]

ermm the second problem .... i'll have a look again few hours later , thank you for the tips , too brain dead now haha

i guess if i click other pagination link the parameters ermmm it echoed some funny numbers , instead of ALL ALL ALL (when i clicked every 'all' in my dropdown list) uh i hope i make sense

[bradgrafelman]

The point is, you aren't including those in the query string of your links, so the values in those variables are lost once you click on those links.

[akmal1981]

ermm query string of my links ..... ermm i'll tinker around

thank you very much for the tips Bradgrafelman , and HAPPY NEW YEAR EVERYONE !!!

p/s : will visit this thread again in couple of hours haha

[akmal1981]

hi guys , last day of year and here i am haha

for first problem , i've changed to $_SERVER['REQUEST_URI'] (after reading other website about it) , i am not sure whether this is the correct solution (??) but the undefined variable notices are no longer around.

read the manual but to be honest i still not sure why it works. Second part of the problem ... well ... will look at it later the code still went bonkers

[akmal1981]

hello again !

Thanks for the tips. After I searched in the internet I did something like this but still after clicking page 2 etc still didnt work ? 😕 from line 119 onwards :

	// if not on page 1, dont show back links
	if ($currentpage > 1) {
	echo "<a href = '{$_server['REQUEST_URI']}?currentpage=1 &gType = $gType &gLocation = $gLocation &gPrice = $gPrice'><<</a>";  

	$prevpage = $currentpage-1;
	echo "<a href='{$_server['REQUEST_URI']}?currentpage=$prevpage &gType = $gType &gLocation = $gLocation &gPrice = $gPrice'><</a>";
	}

//	 ERROR STARTS HERE   WHYYYYYYYYYY ?????????
// loop to show links to range of pages around current page

for ($x = ($currentpage - $range); $x < (($currentpage + $range) + 1); $x++) {
   // if it's a valid page number...
   if (($x > 0) && ($x <= $totalpages)) {
      // if we're on current page...
      if ($x == $currentpage) {
         // 'highlight' it but don't make a link
         echo " [<b>$x</b>] ";
      // if not current page...
      } else {
         // make it a link
         echo " <a href='{$_SERVER['REQUEST_URI']}?currentpage=$x &gType = $gType &gLocation = $gLocation &gPrice = $gPrice'>$x</a> ";
      } // end else
   } // end if 
} // end for



// if not on last page, show forward and last page links        

if ($currentpage != $totalpages) {
   // get next page
   $nextpage = $currentpage + 1;
    // echo forward link for next page 
   echo " <a href='{$_SERVER['REQUEST_URI']}?currentpage=$nextpage &gType = $gType &gLocation = $gLocation &gPrice = $gPrice'>></a> ";
   // echo forward link for lastpage
   echo " <a href='{$_SERVER['REQUEST_URI']}?currentpage=$totalpages &gType = $gType &gLocation = $gLocation &gPrice = $gPrice'>>></a> ";
   echo $_SERVER['REQUEST_URI'];
} // end if

[bradgrafelman]

One problem I see is that URLs can contain no spaces, yet all of your links contain several spaces.

[akmal1981]

Hi Bradgrafelman !

thank you , i did something like this for all the links:

method 1 (space after nextpage) :

echo " <a href='{$_SERVER['REQUEST_URI']}?currentpage=$nextpage &gType=$gType&gLocation=$gLocation&gPrice=$gPrice'>></a> ";

method 2 (no space for all) :

echo " <a href='{$_SERVER['REQUEST_URI']}?currentpage=$nextpage&gType=$gType&gLocation=$gLocation&gPrice=$gPrice'>></a> ";

Both still didnt work but i suspect this could be the error: other than the above getlocationxyz.php , I have another two php files which are getprice.php and gettype.php . I didnt put any pagination codes inside and I wonder that could be why the whole thing didnt work ? example of my getprice.php is :

<?php 
	$q=$_GET["q"]; 
	$con = mysql_connect('localhost', 'root', ''); 
	if (!$con) { 
		die('Could not connect: ' . mysql_error()); 
	} 

mysql_select_db("a_database", $con); 



    if ($q == 1) {
	$sql="SELECT Type,Price1,Location FROM property"; 
} else if($q == 2){
	$sql="SELECT Type,Price1,Location FROM property WHERE type='code1'"; 
} else if($q == 3){
	$sql="SELECT Type,Price1,Location FROM property WHERE type='code2'"; 		
} else if($q == 4){
            $sql="SELECT Type,Price1,Location FROM property WHERE type='code3'"; 
    }


$result = mysql_query($sql); 
echo "<table border='1'> <tr>  <th>Type</th> <th>Price</th> <th>Location</th>  </tr>";
while($row = mysql_fetch_array($result)) { 
	echo "<tr>"; 
	echo "<td>" . $row['Type'] . "</td>"; 
	echo "<td>" . $row['Price1'] . "</td>"; 
	echo "<td>" . $row['Location'] . "</td>"; 
	echo "</tr>"; } 
	echo "</table>"; 
	mysql_close($con); 
?>

again , sorry for my noob question . im doing website for a company im working for and this could help saving $$$ rather than engaging external website developers (plus it is kinda interesting to learn, but hard for me haha )

[akmal1981]

Dear all,

for benefits to other prog noobs

1) Changed $server['REQUEST_URI'] to $SERVER['REQUEST_URI']

2) The working code, thanks to Bradgrafel ie. URLs can contain no space

Thanks to all !! the website is far from over but at least overcame one of the hurdles !!!

<?php 




$gType = $_GET['type'];
$gLocation = $_GET['location'];
$gPrice = $_GET['price'];
$gHref = $_GET['href'];

if($gHref == '')
	$gHref="ContactUs_OurTeam(2).html#";

echo $gType; 
echo $gLocation;
echo $gPrice;

echo "Hunsho Noar";	
/*database connection here*/

$con = mysql_connect('localhost', 'root', ''); 
if (!$con) { 
	die('Could not connect: ' . mysql_error()); 
} 

mysql_select_db("a_database", $con); 

/*find how many rows in the table*/

$sql = "SELECT count(*) FROM property";
$result = mysql_query($sql,$con) or trigger_error("SQL",E_USER_ERROR);
$r=mysql_fetch_row($result);
$numrows = $r[0];

// number of rows to show per page
   $rowsperpage = 2;
// find out total pages
   $totalpages = ceil($numrows/$rowsperpage);

   echo $totalpages;

// get the current page or set a default

	if(isset($_GET['currentpage']) && is_numeric($_GET['currentpage'])) {
	$currentpage=(int) $_GET['currentpage'];
	} else {
	$currentpage=1;
	}

	echo "<br> current page: ".$currentpage."<br>";

// if current page is greater than total pages, set current page to last page
if($currentpage > $totalpages) {
$currentpage = $totalpages;
}

// if current page is less than first page
if ($currentpage < 1) {
$currentpage = 1;
}

// offset of the list based on current page
$offset = ($currentpage-1)*$rowsperpage;

echo $offset;


// get info from database
echo "---------------------<br>";
	echo $gType."<br>";
	echo $gLocation."<br>";
	echo $gPrice."<br>";
echo "---------------------";

if ($gType == "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property LIMIT $offset,$rowsperpage";

} else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' and price='" . $gPrice ."' LIMIT $offset,$rowsperpage";

} else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and price='" . $gPrice ."' LIMIT $offset,$rowsperpage";

} else if($gType <> "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and location='" . $gLocation ."' LIMIT $offset,$rowsperpage";
} 

      else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' LIMIT $offset,$rowsperpage";
} 

      else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' LIMIT $offset,$rowsperpage";
} 

      else if($gType == "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where price='" . $gPrice . "' LIMIT $offset,$rowsperpage";
} 

     else {
	$sql = " SELECT Type,Price1,Location FROM property where type='" .$gType . "' and location='" . $gLocation . "' and price='" . $gPrice . "' LIMIT $offset,$rowsperpage" ;
}


echo "<br>";
echo $sql;
echo  "<br>";

$result = mysql_query($sql); 

echo $result;

// a  bit different here , didnt exactly follow the tutorial should re-look ?

echo "<table border='1'> <tr> <th>Type</th> <th>Price</th> <th>Location</th> </tr>"; 
while($row = mysql_fetch_array($result)) { 
	echo "<tr>"; 
	echo "<td><a href='$gHref'>" . $row['Type'] . "</a></td>"; 
	echo "<td>" . $row['Price1'] . "</td>"; 
	echo "<td>" . $row['Location'] . "</td>"; 
	echo "</tr>"; } 
	echo "</table>"; 
	mysql_close($con); 

// build the pagination link
// range of num links to show
$range = 3;

// if not on page 1, dont show back links
if ($currentpage > 1) {
echo "<a href = '{$_SERVER['REQUEST_URI']}&currentpage=1&href='ContactUs_OurTeam(2).html#' &gType=$gType &gLocation=$gLocation &gPrice=$gPrice'><<</a>";   // original code was $_server['PHP_SELF']
$prevpage = $currentpage-1;
echo "&nbsp;<a href='{$_SERVER['REQUEST_URI']}&currentpage=$prevpage&href='ContactUs_OurTeam(2).html#' &gType=$gType &gLocation=$gLocation &gPrice=$gPrice'><</a>";
}

//	 ERROR STARTS HERE   WHYYYYYYYYYY ?????????
// loop to show links to range of pages around current page

for ($x = ($currentpage - $range); $x < (($currentpage + $range) + 1); $x++) {
   // if it's a valid page number...
   if (($x > 0) && ($x <= $totalpages)) {
      // if we're on current page...
      if ($x == $currentpage) {
         // 'highlight' it but don't make a link
         echo " [<b>$x</b>] ";
      // if not current page...
      } else {
         // make it a link
         //echo " <a href='{$_SERVER['REQUEST_URI']}?currentpage=$x&href='ContactUs_OurTeam(2).html#' &gType=$gType &gLocation=$gLocation &gPrice=$gPrice'>$x</a> ";
		 echo " <a href='{$_SERVER['REQUEST_URI']}&gType=$gType&gLocation=$gLocation&gPrice=$gPrice&currentpage=$x&href=ContactUs_OurTeam(2).html'>$x</a> ";
      } // end else
   } // end if 
} // end for



// if not on last page, show forward and last page links        

if ($currentpage != $totalpages) {
   // get next page
   $nextpage = $currentpage + 1;
    // echo forward link for next page 
   echo " <a href='{$_SERVER['REQUEST_URI']}&currentpage=$nextpage&href='ContactUs_OurTeam(2).html#'&gType=$gType &gLocation=$gLocation &gPrice=$gPrice'>></a> ";
   // echo forward link for lastpage
   echo "&nbsp;<a href='{$_SERVER['REQUEST_URI']}&currentpage=$totalpages&href='ContactUs_OurTeam(2).html#'&gType=$gType &gLocation=$gLocation &gPrice=$gPrice'>>></a> ";
   //echo $_SERVER['REQUEST_URI'];
} // end if
echo $_SERVER['REQUEST_URI'];

?>