[RESOLVED] Not getting value I expect from a button click

[timski72]

Hi Guys,

I have generated a grid with an option to edit or delete a video (see Form.jpg attached).

The value of each button is the video id that is displayed in column 1. When clicking the delete/edit button I was hoping to use the value to delete/edit that specific video id but the value of the button is always the last video id and not the one I am clicking. I am guessing the value of button will always be the value of the last loop? How can I get the value of the button the user clicks?

Here's the generated HTML.

</tr><tr>
	      	<td><div align="left">196</div></td>
    		<td><div align="left">the_men_are_cleaning_the_cars</div></td>
        <td><div align="left"><a href="#" ><img src="..//images/themonkeyisinthetree.png" width="40" alt="..//images/themonkeyisinthetree.png" /></a></div></td>
    		<td><div align="left">5</div></td>
    		<td><div align="left">Describe the scene if appropriate. Can be left blank.</div></td>
    		<td><div align="left">
    			<input type="hidden" name="VideoToEdit" value=" 196 "/>
    			<input type="submit" name="button" id="edit" value="edit"/>
      		</div></td>
    		<td><div align="left\
    			<input type="hidden" name="VideoToDelete" value=" 196"/>
    			<input type="submit" name="button" id="delete" value="delete"/>
      		</div></td>
    </tr>
<tr>
	      	<td><div align="left">197</div></td>
    		<td><div align="left">the_men_are_cleaning_the_cars</div></td>
        <td><div align="left"><a href="#" ><img src="..//images/themonkeyisinthetree.png" width="40" alt="..//images/themonkeyisinthetree.png" /></a></div></td>
    		<td><div align="left">6</div></td>
    		<td><div align="left">Describe the scene if appropriate. Can be left blank.</div></td>
    		<td><div align="left">
    			<input type="hidden" name="VideoToEdit" value=" 197 "/>
    			<input type="submit" name="button" id="edit" value="edit"/>
      		</div></td>
    		<td><div align="left\
    			<input type="hidden" name="VideoToDelete" value=" 197"/>
    			<input type="submit" name="button" id="delete" value="delete"/>
      		</div></td>
    </tr>

Thanks,
Tim.

[jeepin81]

we cannot tell you anything about a possible loop issue w/o seeing your PHP script.

In regard to the posted HTML you have 2 errors:

</tr><tr> 
              <td><div align="left">196</div></td> 
            <td><div align="left">the_men_are_cleaning_the_cars</div></td> 
        <td><div align="left"><a href="#" ><img src="..//images/themonkeyisinthetree.png" width="40" alt="..//images/themonkeyisinthetree.png" /></a></div></td> 
            <td><div align="left">5</div></td> 
            <td><div align="left">Describe the scene if appropriate. Can be left blank.</div></td> 
            <td><div align="left"> 
                <input type="hidden" name="VideoToEdit" value=" 196 "/> 
                <input type="submit" name="button" id="edit" value="edit"/> 
              </div></td> 
            <td><div align="left"> <!-- #### MISSING closing quote and closing '>' ##### -->
                <input type="hidden" name="VideoToDelete" value=" 196"/> 
                <input type="submit" name="button" id="delete" value="delete"/> 
              </div></td> 
    </tr> 
<tr> 
              <td><div align="left">197</div></td> 
            <td><div align="left">the_men_are_cleaning_the_cars</div></td> 
        <td><div align="left"><a href="#" ><img src="..//images/themonkeyisinthetree.png" width="40" alt="..//images/themonkeyisinthetree.png" /></a></div></td> 
            <td><div align="left">6</div></td> 
            <td><div align="left">Describe the scene if appropriate. Can be left blank.</div></td> 
            <td><div align="left"> 
                <input type="hidden" name="VideoToEdit" value=" 197 "/> 
                <input type="submit" name="button" id="edit" value="edit"/> 
              </div></td> 
            <td><div align="left"> <!-- #### MISSING closing quote and closing '>' ##### -->
                <input type="hidden" name="VideoToDelete" value=" 197"/> 
                <input type="submit" name="button" id="delete" value="delete"/> 
              </div></td> 
    </tr> 

line 11 & 26 of the code you posted. see my comments. Also, take advantage of syntax highlighting to see when there is an error.

[timski72]

Of course - doh. Here's the code that generates the HTML.

while ($row = mysqli_fetch_row($showAllVidsResult)) {
    // As a loop always starts at zero, need to add 1 to $i for sequence
     echo "<tr>
	      	<td><div align=\"left\">" . $row[0] . "</div></td>
    		<td><div align=\"left\">" . $row[1] . "</div></td>
        	<td><div align=\"left\">" . "<a href=\"#\" ><img src=\"$Thumb\" width=\"40\" alt=\"$Thumb\" /></a>" .
       		 "</div></td>
    		<td><div align=\"left\">" . $row[2] . "</div></td>
    		<td><div align=\"left\">" . $row[3] . "</div></td>
    		<td><div align=\"left\">
    			<input type=\"hidden\" name=\"VideoToEdit\" value=\" $row[0] \"/>
    			<input type=\"submit\" name=\"button\" id=\"edit\" value=\"edit\"/>
      		</div></td>
    		<td><div align=\"left\
    			<input type=\"hidden\" name=\"VideoToDelete\" value=\" $row[0]\"/>
    			<input type=\"submit\" name=\"button\" id=\"delete\" value=\"delete\"/>
      		</div></td>
    </tr>\n";
}

And this is the code I wanted to use to derive which video to edit/delete.

 

switch (@$_POST['button']) {
            // User hit validate button
        case "edit":
        // User has hit one of the edit buttons
            // Check there is a value to edit
            // The value is from the hidden element of the edit button setup thus in the html
            // 	<input type="hidden" name="VideoToEdit" value="$row[0]">
            if (isset($_POST['VideoToEdit']))
                // Set the value of the video to edit from $_POST
                $videoToEdit = $_POST['VideoToEdit'];
            // Open database

    echo $videoToEdit;
    	break;
 

Thanks,
Tim.

[cretaceous]

more html comments:
No point in wrapping all the content of your "td"s with "div" tags
tds and divs do similar things..

plus align='left' is not correct for divs and will do nothing

this

 <td><div align=\"left\">" . $row[0] . "</div></td>  

should just be:

 <td align=\"left\">" . $row[0] . "</td>  

or

 <td style='text-align:left'>" . $row[0] . "</td>  

but since "left" is default you don't usually need to specify it

it then looks like you need to wrap each of these:

 <input type=\"hidden\" name=\"VideoToEdit\" value=\" $row[0] \"/>
                <input type=\"submit\" name=\"button\" id=\"edit\" value=\"edit\"/> 

in a "form" open and close tag

even if you do have a form tag there (I can't see one) you can't have multiple submit buttons in one form, that you expect to do different things, just because they happen to be next to a hidden 'videtoedit' input
each needs to be a different form (using your method)

[Derokorian]

Also:

     echo "<tr>
              <td><div align=\"left\">" . $row[0] . "</div></td>
            <td><div align=\"left\">" . $row[1] . "</div></td>
            <td><div align=\"left\">" . "<a href=\"#\" ><img src=\"$Thumb\" width=\"40\" alt=\"$Thumb\" /></a>" .
                "</div></td>
            <td><div align=\"left\">" . $row[2] . "</div></td>
            <td><div align=\"left\">" . $row[3] . "</div></td>
            <td><div align=\"left\">
                <input type=\"hidden\" name=\"VideoToEdit\" value=\" $row[0] \"/>
                <input type=\"submit\" name=\"button\" id=\"edit\" value=\"edit\"/>
              </div></td>
            <td>[b][SIZE="4"][COLOR="Red"]<div align=\"left\[/COLOR][/SIZE][/b]
                <input type=\"hidden\" name=\"VideoToDelete\" value=\" $row[0]\"/>
                <input type=\"submit\" name=\"button\" id=\"delete\" value=\"delete\"/>
              </div></td>
    </tr>\n"; 

As I highlighted your code produces the invalid HTML crataceous warned you of.

[timski72]

Thanks for your help guys.

I removed the div tags and the needless left aligns and generally tidied the HTML.

I also put each button within a form and the script works now.

Removing the crud makes the whole thing easier to read too so thanks for the pointers.

Tim.