[RESOLVED] Assign table to variable

[akmal1981]

Hello it's me again.

My pagination is working well 😃 and I am doing slight modification to the code. I am having trouble which I hope explains well in the following :

//some other codes here

//display table

$outputList = '';
	echo "<table border='1'> <tr> <th>Type</th> <th>Price</th> <th>Location</th> </tr>"; 
	while($row = mysql_fetch_array($result)) { 
		echo "<tr>"; 
		echo "<td><a href='$gHref'>" . $row['Type'] . "</a></td>"; 
		echo "<td>" . $row['Price1'] . "</td>"; 
		echo "<td>" . $row['Location'] . "</td>"; 
		echo "</tr>"; } 
		echo "</table>"; 
		mysql_close($con); 

	$outputList .= '<h1>' . $gType . '</h1><h2>' . $gPrice . ' </h2><hr />';

I want to show the $outputList into my html body using print

<div style: "whatever  here"> <?php print "$outputList"; ?> </div>

I am not sure how to 'insert' table into my $outputList and print in my html. Can someone please help me on this 😕

[akmal1981]

hi guys i solved it the ugly way :queasy: and it's working the way i wanted :

1) however im sure there is a better way to code this , any suggestion is much welcomed:

2) having problem with number of pages. For example, the data from database should be displayed in 2 pages only , but the code runs until page 3 and 4 . In other words, page 1 and 2 display data but page 3 and 4 empty. I wondering if the pagination can show 2 pages only 😕

<?php 




$gType = $_GET['type'];
$gLocation = $_GET['location'];
$gPrice = $_GET['price'];
//$gHref = $_GET['href'];

//if($gHref == '')
$gHref="ContactUs_OurTeam(2).html#";

$con = mysql_connect('localhost', 'root', ''); 
if (!$con) { 
	die('Could not connect: ' . mysql_error()); 
} 

mysql_select_db("a_database", $con); 

/*find how many rows in the table*/

$sql = "SELECT count(*) FROM property";
$result = mysql_query($sql,$con) or trigger_error("SQL",E_USER_ERROR);
$r=mysql_fetch_row($result);
$numrows = $r[0];
//$nr = mysql_num_rows($sql); // Get total of Num rows from the database query

// number of rows to show per page
   $rowsperpage = 2;
// find out total pages
   $totalpages = ceil($numrows/$rowsperpage);

   echo $totalpages;

// get the current page or set a default

	if(isset($_GET['currentpage']) && is_numeric($_GET['currentpage'])) {
	$currentpage=(int) $_GET['currentpage'];
	} else {
	$currentpage=1;
	}

	echo "<br> current page: ".$currentpage."<br>";

// if current page is greater than total pages, set current page to last page
if($currentpage > $totalpages) {
$currentpage = $totalpages;
}

// if current page is less than first page
if ($currentpage < 1) {
$currentpage = 1;
}

// offset of the list based on current page
$offset = ($currentpage-1)*$rowsperpage;

// This creates the numbers to click in between the next and back buttons
$centerPages = "";
$sub1 = $currentpage - 1;  // replace $pn with $currentpage
$sub2 = $currentpage - 2;
$add1 = $currentpage + 1;
$add2 = $currentpage + 2;
if ($currentpage == 1) {
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $currentpage . '</span> &nbsp;';
	$centerPages .=  '&nbsp; <a href="'.$_SERVER['REQUEST_URI'].'&currentpage='.$add1.'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice.'">'.$add1.'</a> &nbsp;';
} else if ($currentpage == $totalpages) {
	$centerPages .= '&nbsp; <a href="' . $_SERVER['REQUEST_URI'] . '&currentpage=' . $sub1 .'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice. '">' . $sub1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $currentpage . '</span> &nbsp;';
} else if ($currentpage > 2 && $currentpage < ($totalpages - 1)) {
	$centerPages .= '&nbsp; <a href="' . $_SERVER['REQUEST_URI'] . '&currentpage=' . $sub2 . '&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice.'">' . $sub2 . '</a> &nbsp;';
	$centerPages .= '&nbsp; <a href="' . $_SERVER['REQUEST_URI'] . '&currentpage=' . $sub1 .'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice. '">' . $sub1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $currentpage . '</span> &nbsp;';
	$centerPages .= '&nbsp; <a href="' . $_SERVER['REQUEST_URI'] . '&currentpage=' . $add1 .'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice. '">' . $add1 . '</a> &nbsp;';
	$centerPages .= '&nbsp; <a href="' . $_SERVER['REQUEST_URI'] . '&currentpage=' . $add2 .'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice. '">' . $add2 . '</a> &nbsp;';
} else if ($currentpage > 1 && $currentpage < $totalpages) {
	$centerPages .= '&nbsp; <a href="' . $_SERVER['REQUEST_URI'] . '&currentpage=' . $sub1 .'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice. '">' . $sub1 . '</a> &nbsp;';
    $centerPages .= '&nbsp; <span class="pagNumActive">' . $currentpage . '</span> &nbsp;';
	$centerPages .= '&nbsp;<a href="'. $_SERVER['REQUEST_URI'] . '&currentpage=' . $add1 . '&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice.'">' . $add1 . '</a> &nbsp;';
}


 ///////////////////////////////////// Adam's Pagination Display Setup /////////////////////////////////////////////////////////////////////
$paginationDisplay = ""; // Initialize the pagination output variable   //akmal : no change here
// This code runs only if the last page variable is ot equal to 1, if it is only 1 page we require no paginated links to display
if ($totalpages != "1"){   //akmal : instead of $lastpage insert $totalpages
    // This shows the user what page they are on, and the total number of pages
    $paginationDisplay .= 'Page <strong>' . $currentpage . '</strong> of ' . $totalpages. '&nbsp;  &nbsp;  &nbsp; '; // instead of $pn insert $currentpage
    // If we are not on page 1 we can place the Back button
    if ($currentpage != 1) {   // again, change the $pn here
        $previous = $currentpage - 1;    // no change
       // $paginationDisplay .=  '&nbsp;  <a href="' . $_SERVER['PHP_SELF'] . '?currentpage=' . $previous . '"> Back</a> ';
		$paginationDisplay .=  '&nbsp;<a href="'.$_SERVER['REQUEST_URI'].'&currentpage='.$previous.'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice.'"> Back</a>';
    } 
    // Lay in the clickable numbers display here between the Back and Next links
    $paginationDisplay .= '<span class="paginationNumbers">' . $centerPages . '</span>';   

    // If we are not on the very last page we can place the Next button
    if ($currentpage != $totalpages) {
        $nextPage = $currentpage + 1;
        //$paginationDisplay .=  '&nbsp;  <a href="' . $_SERVER['PHP_SELF'] . '?currentpage=' . $nextPage . '"> Next</a> ';
		$paginationDisplay .=  '&nbsp;<a href="'.$_SERVER['REQUEST_URI'].'&currentpage='.$nextPage.'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice.'"> Next</a>';
    } 
}
///////////////////////////////////// END Adam's Pagination Display Setup ///////////////////////////////////////////////////////////////////////////

?>

<html>
<head>
<title>STAMC stupid Pagination</title>
<style type="text/css">

.pagNumActive {
    color: #000;
    border:#060 1px solid; background-color: #D2FFD2; padding-left:3px; padding-right:3px;
}
.paginationNumbers a:link {
    color: #000;
    text-decoration: none;
    border:#999 1px solid; background-color:#F0F0F0; padding-left:3px; padding-right:3px;
}
.paginationNumbers a:visited {
    color: #000;
    text-decoration: none;
    border:#999 1px solid; background-color:#F0F0F0; padding-left:3px; padding-right:3px;
}
.paginationNumbers a:hover {
    color: #000;
    text-decoration: none;
    border:#060 1px solid; background-color: #D2FFD2; padding-left:3px; padding-right:3px;
}
.paginationNumbers a:active {
    color: #000;
    text-decoration: none;
    border:#999 1px solid; background-color:#F0F0F0; padding-left:3px; padding-right:3px;
}

</style>
</head>
<body>
   <div style="margin-left:64px; margin-right:64px;">
     <h2>Total Items: <?php echo $numrows ; ?></h2>
   </div> 
    <div style="margin-left:58px; margin-right:58px; padding:6px; background-color:#FFF; border:#999 1px solid;"><?php echo $paginationDisplay; ?></div>

<div style="margin-left:64px; margin-right:64px;">

<?php print "the table should be here :";




// query the database

if ($gType == "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
$sql = "SELECT Type,Price1,Location FROM property LIMIT $offset,$rowsperpage";

} else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' and price='" . $gPrice ."' LIMIT $offset,$rowsperpage";

} else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and price='" . $gPrice ."' LIMIT $offset,$rowsperpage";

} else if($gType <> "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' and location='" . $gLocation ."' LIMIT $offset,$rowsperpage";
} 

      else if($gType <> "ALL" and $gLocation == "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where type='" . $gType . "' LIMIT $offset,$rowsperpage";
} 

      else if($gType == "ALL" and $gLocation <> "ALL" and $gPrice == "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where location='" . $gLocation . "' LIMIT $offset,$rowsperpage";
} 

      else if($gType == "ALL" and $gLocation == "ALL" and $gPrice <> "ALL") {
	$sql = "SELECT Type,Price1,Location FROM property where price='" . $gPrice . "' LIMIT $offset,$rowsperpage";
} 

     else {
	$sql = " SELECT Type,Price1,Location FROM property where type='" .$gType . "' and location='" . $gLocation . "' and price='" . $gPrice . "' LIMIT $offset,$rowsperpage" ;
}

$result = mysql_query($sql); 

echo "<table border='1'> <tr> <th>Type</th> <th>Price</th> <th>Location</th> </tr>"; 
while($row = mysql_fetch_array($result)) { 
	echo "<tr>"; 
	echo "<td><a href='$gHref'>" . $row['Type'] . "</a></td>"; 
	echo "<td>" . $row['Price1'] . "</td>"; 
	echo "<td>" . $row['Location'] . "</td>"; 
	echo "</tr>"; } 
	echo "</table>"; 

?>
</div> 

  <div style="margin-left:58px; margin-right:58px; padding:6px; background-color:#FFF; border:#999 1px solid;"><?php echo $paginationDisplay; ?></div>
</body>
</html>

[akmal1981]

anyone anyone ??

[niroshan]

Hi akmal1981,

please read the comments inside the code,

<?php
//I USED YOUR CONNECTION BUT I PREFER YOU GET FAMILIER WITH PDO
$con = mysql_connect('localhost', 'root', '');
if (!$con) {
	die('Could not connect: ' . mysql_error());
}
mysql_select_db("builder", $con);


//LITTLE BIT OF VALIDATION IF USER ACCESS THE PAGE WITHOUT TYHE GET PARAMETERS
$gType = isset($_GET['type']) ? $_GET['type'] : 'ALL';
$gLocation = isset($_GET['location']) ? $_GET['location'] : 'ALL';
$gPrice = isset($_GET['price']) ? $_GET['price'] : 'ALL';
$gHref="ContactUs_OurTeam(2).html#";

//GOT RID OF ALL THE IF CONDITIONS. IF THE VALUES ARE NOT EQUAL TO 'ALL', USE THEM IN THE QUERY

$subQuery = array();

if($gType <> 'ALL')
	$subQuery[] = 'type = \''.$gType.'\'';	
if($gLocation <> 'ALL')
	$subQuery[] = 'location = \''.$gLocation.'\'';	
if($gPrice <> 'ALL')
	$subQuery[] = 'price = \''.$gPrice.'\'';	


/*
****FIRST BUG IN YOUR CODE*****

IN YOUR CODE YOU DONT CONSIDER THE FILTERS WHEN GETTING THE TOTAL RECORDS FOR THE PAGINATION, BUT IN THE ACTUAL DISPLAY QUERY YOU CONSIDER ABOUT THE FILTERS.

CONSIDER BELOW SCENARIO,

PROPERTY
--------
Type 		Price1
SOMETHING	100
SOMETHING	200
SOMETHING	300

LETS SAY YOU WANT ALL THE PROPERTIES WHICH PRICE EQUAL 400. THIS WILL RETURN 0 RECODS RIGHT. BUT SINCE YOUR TOTAL RECORDS QUERY WILL ALWAYS RETURN THE TOTAL NO OF RECODS IN THE TABLE IT WILL RETURN 3. THATS WHY YOU ALWAYS GET THE PAGINATION PAGES EVEN THOUGH YOU DONT HAVE ANY VALUES RELEVENT TO YOUR QUERY.
*/
$sql = "SELECT count(*) FROM property";

if(count($subQuery) > 0)
	$sql .= ' WHERE '.implode('AND ', $subQuery);

$result = mysql_query($sql,$con) or trigger_error("SQL",E_USER_ERROR);
$r=mysql_fetch_row($result);
$numrows = $r[0];
$rowsperpage = 2;
$totalpages = ceil($numrows/$rowsperpage);
$currentpage = isset($_GET['currentpage']) ? $_GET['currentpage'] : 1;    

$offset = ($currentpage - 1) * $rowsperpage;

$centerPages = "";
$paginationDisplay = "";

//SIMPLYFIED YOUR CODE JUST INTO ONE FOR LOOP
for($page = 1; $page <= $totalpages; $page++)
{
	 if ($page == $currentpage)
		  $centerPages .= '&nbsp; <span class="pagNumActive">'.$page.'</span>';
	 else
		  $centerPages .= '&nbsp; <a href="test.php?currentpage='.$page.'&type='.$gType.'&location='.$gLocation.'&price='.$gPrice.'">'.$page.'</a>';
}

/*
****SECOND BUG IN YOUR CODE*****
IF YOU CHECK YOUR CODE YOU`LL HAVE THIS IF CONDITION AS,

if ($totalpages != "1")

WHY USE DOUBLE CODE FOR 1? IT`S A INTERGER NOT A STRING.	
*/
if ($totalpages != 1) {

$paginationDisplay .= 'Page <strong>' . $currentpage . '</strong> of ' . $totalpages. '&nbsp;  &nbsp;  &nbsp; '; // instead of $pn insert $currentpage

/*
****THIRD BUG IN YOUR CODE*****
IN YOUR CODE YOU USE $_SERVER['REQUEST_URI'] AS THE HREF VALUE. WHY? JUST USE THE FILENAME DIRECTLY.

AND ALSO I SEE YOU HAVE USED,

<a href="'.$_SERVER['REQUEST_URI'].'&currentpage='.$add1.'&gType'.$gType.'&gLocation'.$gLocation.'&gPrice'.$gPrice.'">

LOOK AT THE GET VARIABLES.
1. THEY ARE SHOULD CHANGE AS,
- gType SHOULD BE type
- gLocation SHOULD BE location
- gPrice SHOULD BE price

2. WHERE IS THE EQUAL (=) SIGN AFTER EACH GET VARIABLE?
*/
	if ($currentpage != 1) {
        $previous = $currentpage - 1;      

        $paginationDisplay .=  '&nbsp;<a href="test.php?currentpage='.$previous.'&type='.$gType.'&location='.$gLocation.'&price='.$gPrice.'"> Back</a>';
    }

    $paginationDisplay .= '<span class="paginationNumbers">' . $centerPages . '</span>';   

    if ($currentpage != $totalpages) {
        $nextPage = $currentpage + 1;
        $paginationDisplay .=  '&nbsp;<a href="test.php?currentpage='.$nextPage.'&type='.$gType.'&location='.$gLocation.'&price='.$gPrice.'"> Next</a>';
    }
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>
<style type="text/css">
.pagNumActive {
	color: #000;
	border:#060 1px solid;
	background-color: #D2FFD2;
	padding-left:3px;
	padding-right:3px;
}
.paginationNumbers a:link {
	color: #000;
	text-decoration: none;
	border:#999 1px solid;
	background-color:#F0F0F0;
	padding-left:3px;
	padding-right:3px;
}
.paginationNumbers a:visited {
	color: #000;
	text-decoration: none;
	border:#999 1px solid;
	background-color:#F0F0F0;
	padding-left:3px;
	padding-right:3px;
}
.paginationNumbers a:hover {
	color: #000;
	text-decoration: none;
	border:#060 1px solid;
	background-color: #D2FFD2;
	padding-left:3px;
	padding-right:3px;
}
.paginationNumbers a:active {
	color: #000;
	text-decoration: none;
	border:#999 1px solid;
	background-color:#F0F0F0;
	padding-left:3px;
	padding-right:3px;
}
</style>
<body>
<?php
if($numrows == 0)
	echo 'No Records found';
else
{
?>
    <br> current page: <?php echo $currentpage; ?> <br>
    <div style="margin-left:64px; margin-right:64px;">
      <h2>Total Items: <?php echo $numrows ; ?></h2>
    </div>
    <div style="margin-left:58px; margin-right:58px; padding:6px; background-color:#FFF; border:#999 1px solid;"><?php echo $paginationDisplay; ?></div>
    <div style="margin-left:64px; margin-right:64px;">
    <?php
    $sql = 'SELECT Type,Price1,Location FROM property';

    if(count($subQuery) > 0)
        $sql .= ' WHERE '.implode('AND ', $subQuery);

    $sql .= ' LIMIT '.$offset.','.$rowsperpage;

    $result = mysql_query($sql);
    ?>
      <table border='1'>
        <tr>
          <th>Type</th>
          <th>Price</th>
          <th>Location</th>
        </tr>
        <?php
        while($row = mysql_fetch_array($result)) {
            echo "<tr>";
            echo "<td><a href='$gHref'>" . $row['Type'] . "</a></td>";
            echo "<td>" . $row['Price1'] . "</td>";
            echo "<td>" . $row['Location'] . "</td>";
            echo "</tr>"; 
        }
    ?>
      </table>
    </div>
    <div style="margin-left:58px; margin-right:58px; padding:6px; background-color:#FFF; border:#999 1px solid;"><?php echo $paginationDisplay; ?></div>
<?php
}
?>
</body>
</html>

[akmal1981]

whoa thanks a lot man !!! I will have a look at the comments thanks a bunch !

[akmal1981]

this stuff is hard for me :xbones:

[akmal1981]

thanks niroshan !