[RESOLVED] HTTP 500 error from browser

dcjones

Hi all,

I have just upgraded from PHP 5.1 to 5.3.x.

I have a script which prior to the upgrade was working without error. Now when the same script is run I get a HTTP 500 error from the browser.

I have narrowed the cause down but I cannot see why when I remove the code from the script it runs without error.

if($totalPages_fids == 0){ 

// Display image

}else {

while ($row_fids = mysql_fetch_assoc($fids)) {
	if(!empty($row_fids['Flight'])) { 
		print date("H:i", strtotime($row_fids['ScheduledTime']));
		print str_replace(" ","", $row_fids['Flight']);
		print $row_fids['Logo'];
		print $row_fids['IATALookup'];

// IF I REMOVE THIS IF STATEMENT THE SCRIPT RUN WITHOUR ERROR
				if(strpos($row_fids['RemarksWithTime'], "Cancelled" == 0 )){
					print $row_fids['RemarksWithTime'];
				} else {
					print $row_fids['RemarksWithTime'];

// END IF
				}
			print $row_fids['Terminal'];
		}
	}
}

Can anyone see why this is happening.

bradgrafelman

You never show us how you define $fids or whether or not you do any error checking before you assume that it contains a valid MySQL result resource, so I'd be suspicious there. Plus, a 500 error could be caused by a parse error, and since you've omitted an unknown amount of code, I'd also be suspicious there.

What you should do first, however, is figure out what the error actually is rather than have us play the guessing game. Check your server's error logs and/or PHP's error logs to see what the problem is.

Derokorian

This part of a line:

strpos($row_fids['RemarksWithTime'], "Cancelled" == 0 )

Is all wrong, because the == 0 is within the function call, not a comparative to the return of that function call. Also what is the point of this if/else? Both true evaluation and false evaluation results in the exact same command, so why not just have that command?

                if(strpos($row_fids['RemarksWithTime'], "Cancelled" == 0 )){ 
                    print $row_fids['RemarksWithTime']; 
                } else { 
                    print $row_fids['RemarksWithTime']; 

// END IF 
                }

Should just be

print $row_fids['RemarksWithTime'];

Since that is being run no matter the result of the if statement.

dcjones

Hi all,

many thanks for your replies.

I found out what the cause was, in the php.ini file the "short_open_tag" was disabled.

bradgrafelman

I would say the real cause of your problem was the use of the short tags rather than the full '<?php' tags. The former depends on server configuration, while the latter simply works in all PHP configurations.